Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8199594: Add doc describing how (?x) ignores spaces in character classes #3577

Closed

Conversation

igraves
Copy link
Member

@igraves igraves commented Apr 19, 2021

Clarifying note on comments mode to explicitly note that whitespace within character classes is ignored.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Integration blocker

 ⚠️ The change requires a CSR request to be approved.

Issue

  • JDK-8199594: Add doc describing how (?x) ignores spaces in character classes

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3577/head:pull/3577
$ git checkout pull/3577

Update a local copy of the PR:
$ git checkout pull/3577
$ git pull https://git.openjdk.java.net/jdk pull/3577/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3577

View PR using the GUI difftool:
$ git pr show -t 3577

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3577.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 19, 2021

👋 Welcome back igraves! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 19, 2021
@openjdk
Copy link

openjdk bot commented Apr 19, 2021

@igraves The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Apr 19, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 19, 2021

Webrevs

Copy link
Member

@bplb bplb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all right. Probably a CSR is in order.

@openjdk
Copy link

openjdk bot commented Apr 19, 2021

@igraves This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 19, 2021
@igraves
Copy link
Member Author

igraves commented Apr 19, 2021

Will put a /csr in to be safe.

@igraves
Copy link
Member Author

igraves commented Apr 19, 2021

/csr

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Apr 19, 2021
@openjdk
Copy link

openjdk bot commented Apr 19, 2021

@igraves has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@igraves please create a CSR request and add link to it in JDK-8199594. This pull request cannot be integrated until the CSR request is approved.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Apr 19, 2021
Copy link
Member

@stuart-marks stuart-marks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor wording adjustments. Please update the CSR accordingly and I'll review it too.

src/java.base/share/classes/java/util/regex/Pattern.java Outdated Show resolved Hide resolved
src/java.base/share/classes/java/util/regex/Pattern.java Outdated Show resolved Hide resolved
@igraves
Copy link
Member Author

igraves commented Apr 22, 2021

Wording updated per @stuart-marks's suggestions. Thanks! CSR updated accordingly.

@bridgekeeper
Copy link

bridgekeeper bot commented May 20, 2021

@igraves This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 17, 2021

@igraves This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org csr Pull request needs approved CSR before integration rfr Pull request is ready for review
3 participants