Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265486: ProblemList javax/sound/midi/Sequencer/Recording.java on macosx-aarch64 #3579

Closed
wants to merge 1 commit into from

Conversation

vidmik
Copy link
Contributor

@vidmik vidmik commented Apr 19, 2021

The javax/sound/midi/Sequencer/Recording.java (tier3) test fails intermittently on macosx-aarch64. Let's problem list it for now.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265486: ProblemList javax/sound/midi/Sequencer/Recording.java on macosx-aarch64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3579/head:pull/3579
$ git checkout pull/3579

Update a local copy of the PR:
$ git checkout pull/3579
$ git pull https://git.openjdk.java.net/jdk pull/3579/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3579

View PR using the GUI difftool:
$ git pr show -t 3579

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3579.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 19, 2021

👋 Welcome back mikael! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 19, 2021
@openjdk
Copy link

openjdk bot commented Apr 19, 2021

@vidmik To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

@vidmik
Copy link
Contributor Author

vidmik commented Apr 19, 2021

/label sound

@openjdk openjdk bot added the sound client-libs-dev@openjdk.org label Apr 19, 2021
@openjdk
Copy link

openjdk bot commented Apr 19, 2021

@vidmik
The sound label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Apr 19, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 19, 2021

@vidmik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265486: ProblemList javax/sound/midi/Sequencer/Recording.java on macosx-aarch64

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • e0fd5fc: 8265028: JDWP debug agent thread lookup can be made faster

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 19, 2021
@vidmik
Copy link
Contributor Author

vidmik commented Apr 19, 2021

Thank you Phil!
/integrate

@openjdk openjdk bot closed this Apr 19, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 19, 2021
@openjdk
Copy link

openjdk bot commented Apr 19, 2021

@vidmik Since your change was applied there has been 1 commit pushed to the master branch:

  • e0fd5fc: 8265028: JDWP debug agent thread lookup can be made faster

Your commit was automatically rebased without conflicts.

Pushed as commit ab22407.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@vidmik vidmik deleted the 8265486-plist-8265485 branch April 29, 2021 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated sound client-libs-dev@openjdk.org
3 participants