Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265445: Introduce the new client property for mac: apple.awt.windowAppearance #3583

Closed
wants to merge 1 commit into from

Conversation

avu
Copy link

@avu avu commented Apr 20, 2021

Implemented apple.awt.windowAppearance client property


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Integration blocker

 ⚠️ The change requires a CSR request to be approved.

Issue

  • JDK-8265445: Introduce the new client property for mac: apple.awt.windowAppearance

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3583/head:pull/3583
$ git checkout pull/3583

Update a local copy of the PR:
$ git checkout pull/3583
$ git pull https://git.openjdk.java.net/jdk pull/3583/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3583

View PR using the GUI difftool:
$ git pr show -t 3583

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3583.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 20, 2021

👋 Welcome back avu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 20, 2021
@openjdk
Copy link

openjdk bot commented Apr 20, 2021

@avu The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt label Apr 20, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 20, 2021

Webrevs

@mlbridge
Copy link

mlbridge bot commented Apr 20, 2021

Mailing list message from Alexey Ushakov on awt-dev:

Could anyone from the dev team review my CSR request for this change: https://bugs.openjdk.java.net/browse/JDK-8265447 <https://bugs.openjdk.java.net/browse/JDK-8265447> ?

Best Regards,
Alexey

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/awt-dev/attachments/20210420/61ce00e0/attachment.htm>

1 similar comment
@mlbridge
Copy link

mlbridge bot commented Apr 20, 2021

Mailing list message from Alexey Ushakov on awt-dev:

Could anyone from the dev team review my CSR request for this change: https://bugs.openjdk.java.net/browse/JDK-8265447 <https://bugs.openjdk.java.net/browse/JDK-8265447> ?

Best Regards,
Alexey

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/awt-dev/attachments/20210420/61ce00e0/attachment.htm>

…ppearance

Implemented apple.awt.windowAppearance client property
@prrace
Copy link
Contributor

prrace commented May 21, 2021

/csr

@openjdk openjdk bot added the csr label May 26, 2021
@openjdk
Copy link

openjdk bot commented May 26, 2021

@prrace this pull request will not be integrated until the CSR request JDK-8265447 for issue JDK-8265445 has been approved.

@openjdk
Copy link

openjdk bot commented May 26, 2021

@avu this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8265445
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict label May 26, 2021
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 23, 2021

@avu This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 21, 2021

@avu This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awt csr merge-conflict rfr
2 participants