8260690: JConsole User Guide Link from the Help menu is not accessible by keyboard

[skodanda]

Hi All,

Could you please review this JConsole fix for JDK-17?

Problem:
JConsole User Guide Link from the Help menu is not accessible by keyboard.

Fix:
The JConsole User Guide Link can be highlighted and can now be accessed using keyboard.

Using the TAB key, the link can be highlighted and ENTER or SPACE key will browse the link.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8260690: JConsole User Guide Link from the Help menu is not accessible by keyboard

Reviewers

• Alexey Ivanov (@aivanov-jdk - Reviewer)
• Dmitry Markov (@dmarkov20 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3587/head:pull/3587
$ git checkout pull/3587

Update a local copy of the PR:
$ git checkout pull/3587
$ git pull https://git.openjdk.java.net/jdk pull/3587/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3587

View PR using the GUI difftool:
$ git pr show -t 3587

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3587.diff

[bridgekeeper]

👋 Welcome back skodanda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@skodanda The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (524a1834)

[bridgekeeper]

@skodanda This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[openjdk]

@skodanda This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260690: JConsole User Guide Link from the Help menu is not accessible by keyboard

Reviewed-by: aivanov, dmarkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 524 new commits pushed to the master branch:

• 9eaa4af: 8267056: tools/jpackage/share/RuntimePackageTest.java fails with NoSuchFileException
• e094f3f: 8266856: Make element void
• 7a63ff7: 8267370: [Vector API] Fix several crashes after JDK-8256973
• 83b3607: 8266642: improve ResolvedMethodTable hash function
• 1c7a131: 8267350: Archived old interface extends interface with default method causes crash
• 005d8a7: 8256372: [macos] Unexpected symbol was displayed on JTextField with Monospaced font
• 81f39ed: 8261205: AssertionError: Cannot add metadata to an intersection type
• 7b98400: 8267348: Rewrite gc/epsilon/TestClasses.java to use Metaspace with less classes
• ca93399: 8267235: [macos_aarch64] InterpreterRuntime::throw_pending_exception messing up LR results in crash
• b7b6acd: 8267481: Make sure table row has correct number of cells
• ... and 514 more: https://git.openjdk.java.net/jdk/compare/f1d4ae6cc974912a66b96e624ee0ec46c9ec8fc2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk, @dmarkov20) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@skodanda Only Committers are allowed to sponsor changes.

[skodanda]

/integrate

[openjdk]

@skodanda
Your change (at version 524a183) is now ready to be sponsored by a Committer.

[dmarkov20]

/sponsor

[openjdk]

@dmarkov20 @skodanda Since your change was applied there have been 525 commits pushed to the master branch:

• e48d7d6: 8264218: Public method javax.swing.JMenu.setComponentOrientation() has no spec
• 9eaa4af: 8267056: tools/jpackage/share/RuntimePackageTest.java fails with NoSuchFileException
• e094f3f: 8266856: Make element void
• 7a63ff7: 8267370: [Vector API] Fix several crashes after JDK-8256973
• 83b3607: 8266642: improve ResolvedMethodTable hash function
• 1c7a131: 8267350: Archived old interface extends interface with default method causes crash
• 005d8a7: 8256372: [macos] Unexpected symbol was displayed on JTextField with Monospaced font
• 81f39ed: 8261205: AssertionError: Cannot add metadata to an intersection type
• 7b98400: 8267348: Rewrite gc/epsilon/TestClasses.java to use Metaspace with less classes
• ca93399: 8267235: [macos_aarch64] InterpreterRuntime::throw_pending_exception messing up LR results in crash
• ... and 515 more: https://git.openjdk.java.net/jdk/compare/f1d4ae6cc974912a66b96e624ee0ec46c9ec8fc2...master

Your commit was automatically rebased without conflicts.

Pushed as commit b5d32bb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[TheRealMDoerr]

/backport jdk11u-dev

[openjdk]

@TheRealMDoerr Unknown command backport - for a list of valid commands use /help.