Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265326: Strange Characters in G1GC GC Log #3589

Closed
wants to merge 2 commits into from

Conversation

fmatte1
Copy link

@fmatte1 fmatte1 commented Apr 20, 2021

There was an character formating issue on mac-os due to usage of "
FormatBuffer<128>"
Used explicit variable to hold the FormatBuffer


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3589/head:pull/3589
$ git checkout pull/3589

Update a local copy of the PR:
$ git checkout pull/3589
$ git pull https://git.openjdk.java.net/jdk pull/3589/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3589

View PR using the GUI difftool:
$ git pr show -t 3589

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3589.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 20, 2021

👋 Welcome back fmatte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 20, 2021
@openjdk
Copy link

openjdk bot commented Apr 20, 2021

@fmatte1 The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Apr 20, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 20, 2021

Webrevs

FormatBuffer<128> _format("Concurrent %s Cycle", _state == FullMark ? "Mark" : "Undo");
GCTraceConcTime(Info, gc) tt(_format);
Copy link
Contributor

@tschatzl tschatzl Apr 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FormatBuffer<128> _format("Concurrent %s Cycle", _state == FullMark ? "Mark" : "Undo");
GCTraceConcTime(Info, gc) tt(_format);
FormatBuffer<128> title("Concurrent %s Cycle", _state == FullMark ? "Mark" : "Undo");
GCTraceConcTime(Info, gc) tt(title);

Leading underscores are reserved for members of structs and classes in Hotspot. I suggested title here, but format would be as good.

Apart from that lgtm. Thanks for investigating this.

Copy link
Contributor

@kstefanj kstefanj Apr 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was just about to make the same comment :)

Copy link
Author

@fmatte1 fmatte1 Apr 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tomas for the review, will update with title

@openjdk
Copy link

openjdk bot commented Apr 20, 2021

@fmatte1 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265326: Strange Characters in G1GC GC Log

Reviewed-by: tschatzl, sjohanss, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

  • 7879adb: 8265343: Update Debian-based cross-compilation recipes
  • 98cb81b: 8265237: String.join and StringJoiner can be improved further
  • ed477da: 8264945: Optimize the code-gen for Math.pow(x, 0.5)
  • 7146104: 8265421: java/lang/String/StringRepeat.java test is missing a memory requirement
  • b5c92ca: 8265106: IGV: Enforce en-US locale while parsing ideal graph
  • 3de0dcb: 8265483: All-caps “JAVA” in the top navigation bar
  • 739769c: 8265411: Avoid unnecessary Method::init_intrinsic_id calls
  • a22ad03: 8264983: Add gtest for JDK-8264008
  • 91b08b7: 8261779: JCK test api/javax_crypto/EncryptedPrivateKeyInfo/Ctor4.html is failing with assertion error when assertions enabled
  • 2fcd920: 8261183: Follow on to Make lists of normal filenames
  • ... and 16 more: https://git.openjdk.java.net/jdk/compare/072ae7ec5e38fc0353f2bb7dcaa23d261403be16...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tschatzl, @kstefanj, @kimbarrett) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Apr 20, 2021
Copy link
Author

@fmatte1 fmatte1 left a comment

Updated, as per the Thomas suggestions

@fmatte1
Copy link
Author

fmatte1 commented Apr 20, 2021

/integrate

@openjdk openjdk bot added the sponsor label Apr 20, 2021
@openjdk
Copy link

openjdk bot commented Apr 20, 2021

@fmatte1
Your change (at version 630a944) is now ready to be sponsored by a Committer.

@fmatte1
Copy link
Author

fmatte1 commented Apr 20, 2021

@tschatzl Please sponsor this change (I am not a committer),
Thanks,

@tschatzl
Copy link
Contributor

tschatzl commented Apr 20, 2021

Will do after the 24h wait period expires tomorrow.

Copy link
Contributor

@kstefanj kstefanj left a comment

Looks good.

Did you do any further analysis why the explicit variable was needed? I see there is at least one more place where a FormatBuffer is used in a constructor.

@kimbarrett
Copy link

kimbarrett commented Apr 20, 2021

Looks good.

The lifetime of the FormatBuffer temporary ends when the declaration statement ends, not when the declared variable's lifetime ends.

@fmatte1
Copy link
Author

fmatte1 commented Apr 21, 2021

Thanks Stefan and Kim for the reviews,

Copy link
Contributor

@tschatzl tschatzl left a comment

Still good.

@tschatzl
Copy link
Contributor

tschatzl commented Apr 21, 2021

/sponsor

@openjdk openjdk bot closed this Apr 21, 2021
@openjdk openjdk bot added integrated and removed sponsor ready rfr labels Apr 21, 2021
@openjdk
Copy link

openjdk bot commented Apr 21, 2021

@tschatzl @fmatte1 Since your change was applied there have been 26 commits pushed to the master branch:

  • 7879adb: 8265343: Update Debian-based cross-compilation recipes
  • 98cb81b: 8265237: String.join and StringJoiner can be improved further
  • ed477da: 8264945: Optimize the code-gen for Math.pow(x, 0.5)
  • 7146104: 8265421: java/lang/String/StringRepeat.java test is missing a memory requirement
  • b5c92ca: 8265106: IGV: Enforce en-US locale while parsing ideal graph
  • 3de0dcb: 8265483: All-caps “JAVA” in the top navigation bar
  • 739769c: 8265411: Avoid unnecessary Method::init_intrinsic_id calls
  • a22ad03: 8264983: Add gtest for JDK-8264008
  • 91b08b7: 8261779: JCK test api/javax_crypto/EncryptedPrivateKeyInfo/Ctor4.html is failing with assertion error when assertions enabled
  • 2fcd920: 8261183: Follow on to Make lists of normal filenames
  • ... and 16 more: https://git.openjdk.java.net/jdk/compare/072ae7ec5e38fc0353f2bb7dcaa23d261403be16...master

Your commit was automatically rebased without conflicts.

Pushed as commit da86029.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@fmatte1 fmatte1 deleted the 8265326_rev1 branch Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
4 participants