8265326: Strange Characters in G1GC GC Log #3589

fmatte1 · 2021-04-20T12:02:58Z

There was an character formating issue on mac-os due to usage of "
FormatBuffer<128>"
Used explicit variable to hold the FormatBuffer

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8265326: Strange Characters in G1GC GC Log

Reviewers

Thomas Schatzl (@tschatzl - Reviewer)
Stefan Johansson (@kstefanj - Reviewer)
Kim Barrett (@kimbarrett - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3589/head:pull/3589
$ git checkout pull/3589

Update a local copy of the PR:
$ git checkout pull/3589
$ git pull https://git.openjdk.java.net/jdk pull/3589/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3589

View PR using the GUI difftool:
$ git pr show -t 3589

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3589.diff

bridgekeeper · 2021-04-20T12:03:45Z

👋 Welcome back fmatte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-04-20T12:05:22Z

@fmatte1 The following label will be automatically applied to this pull request:

hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2021-04-20T12:09:24Z

Webrevs

01: Full - Incremental (630a944b)
00: Full (e82c9087)

tschatzl · 2021-04-20T12:19:08Z

src/hotspot/share/gc/g1/g1ConcurrentMarkThread.cpp

+    FormatBuffer<128> _format("Concurrent %s Cycle", _state == FullMark ? "Mark" : "Undo");
+    GCTraceConcTime(Info, gc) tt(_format);


Suggested change

FormatBuffer<128> _format("Concurrent %s Cycle", _state == FullMark ? "Mark" : "Undo");

GCTraceConcTime(Info, gc) tt(_format);

FormatBuffer<128> title("Concurrent %s Cycle", _state == FullMark ? "Mark" : "Undo");

GCTraceConcTime(Info, gc) tt(title);

Leading underscores are reserved for members of structs and classes in Hotspot. I suggested title here, but format would be as good.

Apart from that lgtm. Thanks for investigating this.

Was just about to make the same comment :)

Thanks Tomas for the review, will update with title

openjdk · 2021-04-20T12:22:30Z

@fmatte1 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265326: Strange Characters in G1GC GC Log

Reviewed-by: tschatzl, sjohanss, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

7879adb: 8265343: Update Debian-based cross-compilation recipes
98cb81b: 8265237: String.join and StringJoiner can be improved further
ed477da: 8264945: Optimize the code-gen for Math.pow(x, 0.5)
7146104: 8265421: java/lang/String/StringRepeat.java test is missing a memory requirement
b5c92ca: 8265106: IGV: Enforce en-US locale while parsing ideal graph
3de0dcb: 8265483: All-caps “JAVA” in the top navigation bar
739769c: 8265411: Avoid unnecessary Method::init_intrinsic_id calls
a22ad03: 8264983: Add gtest for JDK-8264008
91b08b7: 8261779: JCK test api/javax_crypto/EncryptedPrivateKeyInfo/Ctor4.html is failing with assertion error when assertions enabled
2fcd920: 8261183: Follow on to Make lists of normal filenames
... and 16 more: https://git.openjdk.java.net/jdk/compare/072ae7ec5e38fc0353f2bb7dcaa23d261403be16...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tschatzl, @kstefanj, @kimbarrett) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

fmatte1

Updated, as per the Thomas suggestions

fmatte1 · 2021-04-20T12:33:40Z

/integrate

openjdk · 2021-04-20T12:34:21Z

@fmatte1
Your change (at version 630a944) is now ready to be sponsored by a Committer.

fmatte1 · 2021-04-20T12:35:02Z

@tschatzl Please sponsor this change (I am not a committer),
Thanks,

tschatzl · 2021-04-20T13:08:40Z

Will do after the 24h wait period expires tomorrow.

kstefanj

Looks good.

Did you do any further analysis why the explicit variable was needed? I see there is at least one more place where a FormatBuffer is used in a constructor.

kimbarrett · 2021-04-20T19:52:40Z

Looks good.

The lifetime of the FormatBuffer temporary ends when the declaration statement ends, not when the declared variable's lifetime ends.

fmatte1 · 2021-04-21T03:54:54Z

Thanks Stefan and Kim for the reviews,

tschatzl

Still good.

tschatzl · 2021-04-21T11:47:06Z

/sponsor

openjdk · 2021-04-21T11:48:57Z

@tschatzl @fmatte1 Since your change was applied there have been 26 commits pushed to the master branch:

7879adb: 8265343: Update Debian-based cross-compilation recipes
98cb81b: 8265237: String.join and StringJoiner can be improved further
ed477da: 8264945: Optimize the code-gen for Math.pow(x, 0.5)
7146104: 8265421: java/lang/String/StringRepeat.java test is missing a memory requirement
b5c92ca: 8265106: IGV: Enforce en-US locale while parsing ideal graph
3de0dcb: 8265483: All-caps “JAVA” in the top navigation bar
739769c: 8265411: Avoid unnecessary Method::init_intrinsic_id calls
a22ad03: 8264983: Add gtest for JDK-8264008
91b08b7: 8261779: JCK test api/javax_crypto/EncryptedPrivateKeyInfo/Ctor4.html is failing with assertion error when assertions enabled
2fcd920: 8261183: Follow on to Make lists of normal filenames
... and 16 more: https://git.openjdk.java.net/jdk/compare/072ae7ec5e38fc0353f2bb7dcaa23d261403be16...master

Your commit was automatically rebased without conflicts.

Pushed as commit da86029.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8265326: Strange Characters in G1GC GC Log

e82c908

openjdk bot added the rfr Pull request is ready for review label Apr 20, 2021

openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Apr 20, 2021

tschatzl approved these changes Apr 20, 2021

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 20, 2021

Update g1ConcurrentMarkThread.cpp

630a944

fmatte1 commented Apr 20, 2021

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 20, 2021

kstefanj approved these changes Apr 20, 2021

View reviewed changes

kimbarrett approved these changes Apr 20, 2021

View reviewed changes

tschatzl approved these changes Apr 21, 2021

View reviewed changes

openjdk bot closed this Apr 21, 2021

openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 21, 2021

fmatte1 deleted the 8265326_rev1 branch April 23, 2021 14:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8265326: Strange Characters in G1GC GC Log #3589

8265326: Strange Characters in G1GC GC Log #3589

fmatte1 commented Apr 20, 2021 •

edited by openjdk bot

Loading

bridgekeeper bot commented Apr 20, 2021

openjdk bot commented Apr 20, 2021

mlbridge bot commented Apr 20, 2021 •

edited

Loading

tschatzl Apr 20, 2021

kstefanj Apr 20, 2021

fmatte1 Apr 20, 2021

openjdk bot commented Apr 20, 2021 •

edited

Loading

fmatte1 left a comment

fmatte1 commented Apr 20, 2021

openjdk bot commented Apr 20, 2021

fmatte1 commented Apr 20, 2021

tschatzl commented Apr 20, 2021

kstefanj left a comment

kimbarrett commented Apr 20, 2021

fmatte1 commented Apr 21, 2021

tschatzl left a comment

tschatzl commented Apr 21, 2021

openjdk bot commented Apr 21, 2021

		FormatBuffer<128> _format("Concurrent %s Cycle", _state == FullMark ? "Mark" : "Undo");
		GCTraceConcTime(Info, gc) tt(_format);

8265326: Strange Characters in G1GC GC Log #3589

8265326: Strange Characters in G1GC GC Log #3589

Conversation

fmatte1 commented Apr 20, 2021 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Apr 20, 2021

openjdk bot commented Apr 20, 2021

mlbridge bot commented Apr 20, 2021 • edited Loading

Webrevs

tschatzl Apr 20, 2021

Choose a reason for hiding this comment

kstefanj Apr 20, 2021

Choose a reason for hiding this comment

fmatte1 Apr 20, 2021

Choose a reason for hiding this comment

openjdk bot commented Apr 20, 2021 • edited Loading

fmatte1 left a comment

Choose a reason for hiding this comment

fmatte1 commented Apr 20, 2021

openjdk bot commented Apr 20, 2021

fmatte1 commented Apr 20, 2021

tschatzl commented Apr 20, 2021

kstefanj left a comment

Choose a reason for hiding this comment

kimbarrett commented Apr 20, 2021

fmatte1 commented Apr 21, 2021

tschatzl left a comment

Choose a reason for hiding this comment

tschatzl commented Apr 21, 2021

openjdk bot commented Apr 21, 2021

fmatte1 commented Apr 20, 2021 •

edited by openjdk bot

Loading

mlbridge bot commented Apr 20, 2021 •

edited

Loading

openjdk bot commented Apr 20, 2021 •

edited

Loading