Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265326: Strange Characters in G1GC GC Log #3589

Closed
wants to merge 2 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2001, 2020, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2001, 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -139,8 +139,8 @@ void G1ConcurrentMarkThread::run_service() {
assert(in_progress(), "must be");

GCIdMark gc_id_mark;
GCTraceConcTime(Info, gc) tt(FormatBuffer<128>("Concurrent %s Cycle",
_state == FullMark ? "Mark" : "Undo"));
FormatBuffer<128> _format("Concurrent %s Cycle", _state == FullMark ? "Mark" : "Undo");
GCTraceConcTime(Info, gc) tt(_format);
Copy link
Contributor

@tschatzl tschatzl Apr 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FormatBuffer<128> _format("Concurrent %s Cycle", _state == FullMark ? "Mark" : "Undo");
GCTraceConcTime(Info, gc) tt(_format);
FormatBuffer<128> title("Concurrent %s Cycle", _state == FullMark ? "Mark" : "Undo");
GCTraceConcTime(Info, gc) tt(title);

Leading underscores are reserved for members of structs and classes in Hotspot. I suggested title here, but format would be as good.

Apart from that lgtm. Thanks for investigating this.

Copy link
Contributor

@kstefanj kstefanj Apr 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was just about to make the same comment :)

Copy link
Author

@fmatte1 fmatte1 Apr 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tomas for the review, will update with title


concurrent_cycle_start();