Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265531: doc/building.md should mention homebrew install freetype #3590

Closed
wants to merge 1 commit into from

Conversation

@gdams
Copy link
Contributor

@gdams gdams commented Apr 20, 2021

Updates the docs/building.html guide to include steps to install FreeType on macOS using homebrew.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265531: doc/building.md should mention homebrew install freetype

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3590/head:pull/3590
$ git checkout pull/3590

Update a local copy of the PR:
$ git checkout pull/3590
$ git pull https://git.openjdk.java.net/jdk pull/3590/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3590

View PR using the GUI difftool:
$ git pr show -t 3590

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3590.diff

@bridgekeeper bridgekeeper bot added the oca label Apr 20, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 20, 2021

Hi @gdams, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user gdams" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@gdams
Copy link
Contributor Author

@gdams gdams commented Apr 20, 2021

/covered

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 20, 2021

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@openjdk
Copy link

@openjdk openjdk bot commented Apr 20, 2021

@gdams The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build label Apr 20, 2021
@gdams gdams changed the title add macOS freetype install steps to docs/building.html 8265531: doc/building.md should mention homebrew install freetype Apr 20, 2021
@gdams
Copy link
Contributor Author

@gdams gdams commented Apr 20, 2021

/solves JDK-8265531

@openjdk
Copy link

@openjdk openjdk bot commented Apr 20, 2021

@gdams This issue is referenced in the PR title - it will now be updated.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 22, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Apr 22, 2021

@gdams This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265531: doc/building.md should mention homebrew install freetype

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

  • b930bb1: 8265461: G1: Forwarding pointer removal thread sizing
  • f834557: 8258915: Temporary buffer cleanup
  • 31d8a19: 8265105: gc/arguments/TestSelectDefaultGC.java fails when compiler1 is disabled
  • 657f103: 8057543: Replace javac's Filter with Predicate (and lambdas)
  • 8758b55: 8265591: Remove vestiages of intermediate JSR 175 annotation format
  • 33a86b9: 8263621: Convert jdk.compiler to use Stream.toList()
  • 7df0c10: 8265480: add basic JVMCI support for JEP 309: Dynamic Class-File Constants
  • 9499175: 8261090: Store old classfiles in static CDS archive
  • 159f5e1: 8263636: Add --disable-registry option to jhsdb debugd
  • 6d49cc3: 8265453: SafepointMechanism::should_process() should receive JavaThread*
  • ... and 44 more: https://git.openjdk.java.net/jdk/compare/72c88fc45d4cf3575ab636bad0323fd03e9b6791...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Apr 22, 2021
@gdams
Copy link
Contributor Author

@gdams gdams commented Apr 22, 2021

/integrate

@openjdk openjdk bot added the sponsor label Apr 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 22, 2021

@gdams
Your change (at version cf421d5) is now ready to be sponsored by a Committer.

@gdams
Copy link
Contributor Author

@gdams gdams commented Apr 23, 2021

@erikj79 are you happy to sponsor this PR?

@erikj79
Copy link
Member

@erikj79 erikj79 commented Apr 23, 2021

Sure, you need to initiate with the integrate command though.

@gdams
Copy link
Contributor Author

@gdams gdams commented Apr 23, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Apr 23, 2021

@gdams
Your change (at version cf421d5) is now ready to be sponsored by a Committer.

@erikj79
Copy link
Member

@erikj79 erikj79 commented Apr 23, 2021

/sponsor

@openjdk openjdk bot closed this Apr 23, 2021
@openjdk openjdk bot removed the rfr label Apr 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 23, 2021

@erikj79 @gdams Since your change was applied there have been 72 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 5aab160.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@gdams gdams deleted the freetype_mac_doc branch Apr 26, 2021
@gdams
Copy link
Contributor Author

@gdams gdams commented Apr 26, 2021

/backport jdk16u

@openjdk
Copy link

@openjdk openjdk bot commented Apr 26, 2021

@gdams Unknown command backport - for a list of valid commands use /help.

@gdams
Copy link
Contributor Author

@gdams gdams commented Apr 26, 2021

/help

@openjdk
Copy link

@openjdk openjdk bot commented Apr 26, 2021

@gdams Available commands:

  • covered - used when employer has signed the OCA
  • help - shows this text
  • signed - used after signing the OCA
  • test - used to run tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants