Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8265483: All-caps “JAVA” in the top navigation bar #3594

Closed

Conversation

jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented Apr 20, 2021

Please review a moderately simple change to make/Docs.gmk to move the link for "Other Versions" from a "hidden" link in the top nav bar to an explicit link in the "bottom" text. The link is placed to appear after the sentence beginning "For more information..." and before all the legal text (i.e. trademark, copyright, license, etc)

A side effect of moving the link is that the top text reverts to its intended appearance of "Java ...", without all-caps.

As before, the presence of the link is optional, and depends on the specific docs target. It is set up to just appear for the main JDK/JavaSE documentation, and not the other docs bundles, such as docs-reference.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265483: All-caps “JAVA” in the top navigation bar

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3594/head:pull/3594
$ git checkout pull/3594

Update a local copy of the PR:
$ git checkout pull/3594
$ git pull https://git.openjdk.java.net/jdk pull/3594/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3594

View PR using the GUI difftool:
$ git pr show -t 3594

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3594.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 20, 2021

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 20, 2021
@openjdk
Copy link

openjdk bot commented Apr 20, 2021

@jonathan-gibbons The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Apr 20, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 20, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 20, 2021

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265483: All-caps “JAVA” in the top navigation bar

Reviewed-by: iris, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

  • a22ad03: 8264983: Add gtest for JDK-8264008
  • 91b08b7: 8261779: JCK test api/javax_crypto/EncryptedPrivateKeyInfo/Ctor4.html is failing with assertion error when assertions enabled
  • 2fcd920: 8261183: Follow on to Make lists of normal filenames
  • 40ef00c: 8258457: testlibrary_tests/ctw/JarDirTest.java fails with InvalidPathException on windows
  • 3f0da35: 8261392: Exclude testlibrary_tests/ctw/JarDirTest.java
  • 8d0faaf: 8257001: Improve Http Client Support
  • 9bf055d: 8259633: compiler/graalunit/CoreTest.java fails with NPE after JDK-8244543
  • ddc56d1: 8259428: AlgorithmId.getEncodedParams() should return copy
  • ae33d2a: 8258247: Couple of issues in fix for JDK-8249906
  • 2003e91: 8244543: Enhanced handling of abstract classes
  • ... and 18 more: https://git.openjdk.java.net/jdk/compare/e0fd5fc0692ec4319ca7b4419321899a52a156bd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 20, 2021
@jonathan-gibbons
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Apr 21, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 21, 2021
@openjdk
Copy link

openjdk bot commented Apr 21, 2021

@jonathan-gibbons Since your change was applied there have been 29 commits pushed to the master branch:

  • 739769c: 8265411: Avoid unnecessary Method::init_intrinsic_id calls
  • a22ad03: 8264983: Add gtest for JDK-8264008
  • 91b08b7: 8261779: JCK test api/javax_crypto/EncryptedPrivateKeyInfo/Ctor4.html is failing with assertion error when assertions enabled
  • 2fcd920: 8261183: Follow on to Make lists of normal filenames
  • 40ef00c: 8258457: testlibrary_tests/ctw/JarDirTest.java fails with InvalidPathException on windows
  • 3f0da35: 8261392: Exclude testlibrary_tests/ctw/JarDirTest.java
  • 8d0faaf: 8257001: Improve Http Client Support
  • 9bf055d: 8259633: compiler/graalunit/CoreTest.java fails with NPE after JDK-8244543
  • ddc56d1: 8259428: AlgorithmId.getEncodedParams() should return copy
  • ae33d2a: 8258247: Couple of issues in fix for JDK-8249906
  • ... and 19 more: https://git.openjdk.java.net/jdk/compare/e0fd5fc0692ec4319ca7b4419321899a52a156bd...master

Your commit was automatically rebased without conflicts.

Pushed as commit 3de0dcb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jonathan-gibbons jonathan-gibbons deleted the other-versions branch April 21, 2021 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
3 participants