-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8265483: All-caps “JAVA” in the top navigation bar #3594
Conversation
👋 Welcome back jjg! A progress list of the required criteria for merging this PR into |
@jonathan-gibbons The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@jonathan-gibbons This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 28 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@jonathan-gibbons Since your change was applied there have been 29 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 3de0dcb. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review a moderately simple change to
make/Docs.gmk
to move the link for "Other Versions" from a "hidden" link in the top nav bar to an explicit link in the "bottom" text. The link is placed to appear after the sentence beginning "For more information..." and before all the legal text (i.e. trademark, copyright, license, etc)A side effect of moving the link is that the top text reverts to its intended appearance of "Java ...", without all-caps.
As before, the presence of the link is optional, and depends on the specific docs target. It is set up to just appear for the main JDK/JavaSE documentation, and not the other docs bundles, such as docs-reference.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3594/head:pull/3594
$ git checkout pull/3594
Update a local copy of the PR:
$ git checkout pull/3594
$ git pull https://git.openjdk.java.net/jdk pull/3594/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3594
View PR using the GUI difftool:
$ git pr show -t 3594
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3594.diff