Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265591: Remove vestiages of intermediate JSR 175 annotation format #3597

Closed
wants to merge 1 commit into from

Conversation

@jddarcy
Copy link
Member

@jddarcy jddarcy commented Apr 20, 2021

During the recent review of JDK-8228988, I noticed again the comments in the annotation parser about support for the pre-GA annotation format used before JDK 5.0 shipped. During the development of annotations, there was a late change to correct a flaw in the annotation encoding, JDK-5020908.

I don't think it is necessary to carry forward support for this transient format any longer and this changeset removes support from both core reflection and javac.

Clean runs of relevant test; I gauge this fix as no-reg hard.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265591: Remove vestiages of intermediate JSR 175 annotation format

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3597/head:pull/3597
$ git checkout pull/3597

Update a local copy of the PR:
$ git checkout pull/3597
$ git pull https://git.openjdk.java.net/jdk pull/3597/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3597

View PR using the GUI difftool:
$ git pr show -t 3597

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3597.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 20, 2021

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 20, 2021
@jddarcy
Copy link
Member Author

@jddarcy jddarcy commented Apr 20, 2021

/csr

@openjdk openjdk bot added the csr label Apr 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 20, 2021

@jddarcy this pull request will not be integrated until the CSR request JDK-8265608 for issue JDK-8265591 has been approved.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 20, 2021

@jddarcy The following labels will be automatically applied to this pull request:

  • compiler
  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 20, 2021

Webrevs

@jddarcy
Copy link
Member Author

@jddarcy jddarcy commented Apr 20, 2021

PS CSR for the behavioral change: https://bugs.openjdk.java.net/browse/JDK-8265608

@jbf
jbf approved these changes Apr 22, 2021
@openjdk openjdk bot removed the csr label Apr 22, 2021
@jddarcy
Copy link
Member Author

@jddarcy jddarcy commented Apr 22, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Apr 22, 2021

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265591: Remove vestiages of intermediate JSR 175 annotation format

Reviewed-by: jfranck

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 46 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 22, 2021
@openjdk openjdk bot closed this Apr 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 22, 2021

@jddarcy Since your change was applied there have been 46 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 8758b55.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jddarcy jddarcy deleted the jddarcy:8265591 branch Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants