8253118: Avoid unnecessary deopts when OSR nmethods of the same level are present. #360
Conversation
|
👋 Welcome back iveresov! A progress list of the required criteria for merging this PR into |
|
@veresov The following label will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the |
| if (max_osr_level >= expected_comp_level) { // fast check to avoid locking in a typical scenario | ||
| nmethod* osr_nm = inlinee->lookup_osr_nmethod_for(bci, expected_comp_level, false); | ||
| assert(osr_nm == NULL || osr_nm->comp_level() >= expected_comp_level, "lookup_osr_nmethod_for is broken"); | ||
| if (osr_nm != NULL && osr_nm->comp_level() != comp_level) { |
There was a problem hiding this comment.
Should you check '> comp_level' here? expected_comp_level could be CompLevel_simple and as result you can get our_nm with lower level than current comp_level.
There was a problem hiding this comment.
No we shouldn't. That's intentional. Sometimes we have to go to the lower level (3->1 or 2->1) when the method is not compilable at level 4.
|
@veresov This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 103 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
openjdk
bot
added
integrated
|
@veresov Since your change was applied there have been 107 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit b9505df. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
When running with
-XX:TieredStopAtLevel={2|3}the policy tried to switch to OSR method of the same level if those are present, which caused constant deopting. The fix is to consider only higher levels for OSR switches.Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/360/head:pull/360$ git checkout pull/360