-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8168408: Test java/awt/Focus/ActualFocusedWindowTest/ActualFocusedWindowBlockingTest.java fails intermittentently on windows #3602
Conversation
…dowBlockingTest.java fails intermittentently on windows
👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into |
@prsadhuk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/label add awt |
@prsadhuk |
@prsadhuk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 106 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@prsadhuk Since your change was applied there have been 107 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 45c474a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This test was seen to be failing in windows and mac PIT run due to samevm mode issue. It is now passing in default othervm mode.
Several iterations of this test running in all platforms is working fine, link in JBS.
We can remove the test from ProblemList, similar to what we have done for JDK-8254976.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3602/head:pull/3602
$ git checkout pull/3602
Update a local copy of the PR:
$ git checkout pull/3602
$ git pull https://git.openjdk.java.net/jdk pull/3602/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3602
View PR using the GUI difftool:
$ git pr show -t 3602
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3602.diff