Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265700: Regularize throws clauses in BigDecimal #3608

Closed
wants to merge 3 commits into from

Conversation

@jddarcy
Copy link
Member

@jddarcy jddarcy commented Apr 21, 2021

Some throws clauses in BigDecimal are uninformative and could be eliminated. A few explicit throws clauses for surprising exceptions could be added.

These are spec clarifications rather than spec changes.

Follow-up work to #3189.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3608/head:pull/3608
$ git checkout pull/3608

Update a local copy of the PR:
$ git checkout pull/3608
$ git pull https://git.openjdk.java.net/jdk pull/3608/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3608

View PR using the GUI difftool:
$ git pr show -t 3608

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3608.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 21, 2021

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 21, 2021

@jddarcy The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Apr 21, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 21, 2021

Webrevs

@bplb
bplb approved these changes Apr 21, 2021
Copy link
Member

@bplb bplb left a comment

Less is more. Approved.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 21, 2021

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265700: Regularize throws clauses in BigDecimal

Reviewed-by: bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 7116321: 8254565: JFR: Incorrect verification of mirror events

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 21, 2021
@jddarcy
Copy link
Member Author

@jddarcy jddarcy commented Apr 21, 2021

/integrate

@openjdk openjdk bot closed this Apr 21, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 21, 2021

@jddarcy Since your change was applied there has been 1 commit pushed to the master branch:

  • 7116321: 8254565: JFR: Incorrect verification of mirror events

Your commit was automatically rebased without conflicts.

Pushed as commit 9e7c748.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jddarcy jddarcy deleted the jddarcy:8265700 branch Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants