-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8265700: Regularize throws clauses in BigDecimal #3608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back darcy! A progress list of the required criteria for merging this PR into |
Webrevs
|
bplb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Less is more. Approved.
|
@jddarcy This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
@jddarcy Since your change was applied there has been 1 commit pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 9e7c748. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Some throws clauses in BigDecimal are uninformative and could be eliminated. A few explicit throws clauses for surprising exceptions could be added.
These are spec clarifications rather than spec changes.
Follow-up work to #3189.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3608/head:pull/3608$ git checkout pull/3608Update a local copy of the PR:
$ git checkout pull/3608$ git pull https://git.openjdk.java.net/jdk pull/3608/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3608View PR using the GUI difftool:
$ git pr show -t 3608Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3608.diff