Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261168: Convert javadoc tool to use Stream.toList() #3612

Closed

Conversation

@igraves
Copy link
Member

@igraves igraves commented Apr 22, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261168: Convert javadoc tool to use Stream.toList()

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3612/head:pull/3612
$ git checkout pull/3612

Update a local copy of the PR:
$ git checkout pull/3612
$ git pull https://git.openjdk.java.net/jdk pull/3612/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3612

View PR using the GUI difftool:
$ git pr show -t 3612

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3612.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 22, 2021

👋 Welcome back igraves! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 22, 2021

@igraves The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 22, 2021

Loading

Copy link
Contributor

@jonathan-gibbons jonathan-gibbons left a comment

This seems to be a lot more than just an automated IDE cleanup.

Loading

@igraves
Copy link
Member Author

@igraves igraves commented Apr 22, 2021

That's correct. It's not an IDE cleanup, in fact. This is migrating the use of Collectors.toList() to Stream.toList() where the latter gains some performance benefits while properly enforcing immutability. So there is some hand-checking on my part to ensure that the conversion doesn't introduce immutability where it wasn't expected. This is a subtask of JDK-8260559.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 26, 2021

@igraves This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261168: Convert javadoc tool to use Stream.toList()

Reviewed-by: prappo

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 72 new commits pushed to the master branch:

  • 8559a53: 8265394: G1: Improve assert in HeapRegion::reset_not_compacted_after_full_gc
  • 68011c6: 8265928: G1: Update copyright in several files
  • 222f9f0: 8265682: G1: Mutex::_name dangling in HeapRegionRemSet references after JDK-8264146
  • 2b09ff2: 8232765: NullPointerException at Types.eraseNotNeeded() when compiling a class
  • b9f66d9: 8264188: Improve handling of assembly files in the JDK
  • c3ac690: 8261759: ZGC: ZWorker Threads Continue Marking After System.exit() called
  • 31abe68: 8265116: ZGC: Steal local stacks instead of flushing them
  • 83364a4: 8264258: Unknown lookups in the java package give misleading compilation errors
  • a9367db: 8265127: ZGC: Fix incorrect reporting of reclaimed memory
  • 1580a47: 8265911: assert(comp != __null) failed: Compiler instance missing
  • ... and 62 more: https://git.openjdk.java.net/jdk/compare/325edbc364074e103047173c59305ce0b8ad8b00...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jonathan-gibbons, @pavelrappo) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@openjdk openjdk bot added the ready label Apr 26, 2021
@igraves
Copy link
Member Author

@igraves igraves commented Apr 26, 2021

/integrate

Loading

@openjdk openjdk bot added the sponsor label Apr 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 26, 2021

@igraves
Your change (at version 978f35d) is now ready to be sponsored by a Committer.

Loading

@pavelrappo
Copy link
Member

@pavelrappo pavelrappo commented Apr 26, 2021

/sponsor

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 26, 2021

@pavelrappo @igraves Since your change was applied there have been 72 commits pushed to the master branch:

  • 8559a53: 8265394: G1: Improve assert in HeapRegion::reset_not_compacted_after_full_gc
  • 68011c6: 8265928: G1: Update copyright in several files
  • 222f9f0: 8265682: G1: Mutex::_name dangling in HeapRegionRemSet references after JDK-8264146
  • 2b09ff2: 8232765: NullPointerException at Types.eraseNotNeeded() when compiling a class
  • b9f66d9: 8264188: Improve handling of assembly files in the JDK
  • c3ac690: 8261759: ZGC: ZWorker Threads Continue Marking After System.exit() called
  • 31abe68: 8265116: ZGC: Steal local stacks instead of flushing them
  • 83364a4: 8264258: Unknown lookups in the java package give misleading compilation errors
  • a9367db: 8265127: ZGC: Fix incorrect reporting of reclaimed memory
  • 1580a47: 8265911: assert(comp != __null) failed: Compiler instance missing
  • ... and 62 more: https://git.openjdk.java.net/jdk/compare/325edbc364074e103047173c59305ce0b8ad8b00...master

Your commit was automatically rebased without conflicts.

Pushed as commit fb8f0c5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants