New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8198617: java/awt/Focus/6382144/EndlessLoopTest.java fails on mac #3614
Conversation
👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into |
Please check that 6382144 can be verified by the updated test. |
Build without 6382144 fix still fails with the updated test. |
Any further comment on this? |
@prsadhuk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 115 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@prsadhuk Since your change was applied there have been 116 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit ce48f04. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This test was failing earlier in our nightly testing citing "java.lang.RuntimeException: java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location "
Updated test to
use swing components in EDT,
setAutoDelay for mouse events,
add a delay after frame is made visible,
move the frame to center of screen
and dispose of the frame finally.
Several iterations of the test pass in all platforms. Link in JBS.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3614/head:pull/3614
$ git checkout pull/3614
Update a local copy of the PR:
$ git checkout pull/3614
$ git pull https://git.openjdk.java.net/jdk pull/3614/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3614
View PR using the GUI difftool:
$ git pr show -t 3614
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3614.diff