Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8198617: java/awt/Focus/6382144/EndlessLoopTest.java fails on mac #3614

Closed
wants to merge 2 commits into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Apr 22, 2021

This test was failing earlier in our nightly testing citing "java.lang.RuntimeException: java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location "
Updated test to
use swing components in EDT,
setAutoDelay for mouse events,
add a delay after frame is made visible,
move the frame to center of screen
and dispose of the frame finally.

Several iterations of the test pass in all platforms. Link in JBS.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8198617: java/awt/Focus/6382144/EndlessLoopTest.java fails on mac

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3614/head:pull/3614
$ git checkout pull/3614

Update a local copy of the PR:
$ git checkout pull/3614
$ git pull https://git.openjdk.java.net/jdk pull/3614/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3614

View PR using the GUI difftool:
$ git pr show -t 3614

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3614.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 22, 2021

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 22, 2021

@prsadhuk The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt label Apr 22, 2021
@openjdk openjdk bot added the rfr label Apr 22, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 22, 2021

Webrevs

@mrserb
Copy link
Member

@mrserb mrserb commented Apr 25, 2021

Please check that 6382144 can be verified by the updated test.

@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Apr 26, 2021

Please check that 6382144 can be verified by the updated test.

Build without 6382144 fix still fails with the updated test.

@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Apr 27, 2021

Any further comment on this?

@openjdk
Copy link

@openjdk openjdk bot commented Apr 28, 2021

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8198617: java/awt/Focus/6382144/EndlessLoopTest.java fails on mac

Reviewed-by: jdv, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 115 new commits pushed to the master branch:

  • 6b5e5d7: 8266181: compiler/eliminateAutobox/TestEliminateBoxInDebugInfo should be in driver mode
  • 81b1502: 8266161: mark hotspot compiler/rtm tests which ignore VM flags
  • 4a8324d: 8266180: compiler/vectorapi/TestVectorErgonomics should be run in driver mode
  • 0601aba: 8266175: mark hotspot compiler/jsr292 tests which ignore VM flags
  • 69ad8ac: 8266169: mark hotspot compiler/jvmci tests which ignore VM flags
  • 1a2a570: 8266166: mark hotspot compiler/linkage tests which ignore VM flags
  • 5ee58b0: 8266164: mark hotspot compiler/loopstripmining tests which ignore VM flags
  • 1a37bce: 8263779: SSLEngine reports NEED_WRAP continuously without producing any further output
  • 889d246: 8265917: Different values computed by C2 and interpreter/C1 for Math.pow(x, 2.0) on x86_32
  • e144104: 8262908: JFR: Allow JFR to stream events from a known repository path
  • ... and 105 more: https://git.openjdk.java.net/jdk/compare/ca6b1b49ab791d505573fa6ef000faec3b19256c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 28, 2021
mrserb
mrserb approved these changes Apr 28, 2021
@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Apr 28, 2021

/integrate

@openjdk openjdk bot closed this Apr 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 28, 2021

@prsadhuk Since your change was applied there have been 116 commits pushed to the master branch:

  • 0438cea: 8136517: [macosx]Test java/awt/Focus/8073453/AWTFocusTransitionTest.java fails on MacOSX
  • 6b5e5d7: 8266181: compiler/eliminateAutobox/TestEliminateBoxInDebugInfo should be in driver mode
  • 81b1502: 8266161: mark hotspot compiler/rtm tests which ignore VM flags
  • 4a8324d: 8266180: compiler/vectorapi/TestVectorErgonomics should be run in driver mode
  • 0601aba: 8266175: mark hotspot compiler/jsr292 tests which ignore VM flags
  • 69ad8ac: 8266169: mark hotspot compiler/jvmci tests which ignore VM flags
  • 1a2a570: 8266166: mark hotspot compiler/linkage tests which ignore VM flags
  • 5ee58b0: 8266164: mark hotspot compiler/loopstripmining tests which ignore VM flags
  • 1a37bce: 8263779: SSLEngine reports NEED_WRAP continuously without producing any further output
  • 889d246: 8265917: Different values computed by C2 and interpreter/C1 for Math.pow(x, 2.0) on x86_32
  • ... and 106 more: https://git.openjdk.java.net/jdk/compare/ca6b1b49ab791d505573fa6ef000faec3b19256c...master

Your commit was automatically rebased without conflicts.

Pushed as commit ce48f04.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8198617 branch Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awt integrated
3 participants