Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8198619: java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java fails on mac #3618

Closed
wants to merge 4 commits into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Apr 22, 2021

This test was failing in CI nightly testing due to samevm mode issue.
Modified test to use waitForIdle() judiciously, dispose frame in finally block and move the frame to center of screen.
Several iterations of the test pass in all platforms. Link in JBS.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8198619: java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java fails on mac

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3618/head:pull/3618
$ git checkout pull/3618

Update a local copy of the PR:
$ git checkout pull/3618
$ git pull https://git.openjdk.java.net/jdk pull/3618/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3618

View PR using the GUI difftool:
$ git pr show -t 3618

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3618.diff

…al/ButtonGroupLayoutTraversalTest.java fails on mac
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 22, 2021

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 22, 2021

@prsadhuk The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt label Apr 22, 2021
@openjdk openjdk bot added the rfr label Apr 22, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 22, 2021

Webrevs

@mrserb
Copy link
Member

mrserb commented Apr 23, 2021

How did you check that the problem was in the samevm mode?

@prsadhuk
Copy link
Contributor Author

prsadhuk commented Apr 23, 2021

I did not have the logs but it was raised around the same time of other samevm issue Feb 2018 ie, the JBS tests mentioned in JDK-8254976

@openjdk
Copy link

openjdk bot commented Apr 26, 2021

@prsadhuk this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8198619
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict label Apr 26, 2021
@openjdk openjdk bot removed the merge-conflict label Apr 26, 2021
@prsadhuk
Copy link
Contributor Author

prsadhuk commented Apr 27, 2021

Any further comment on this?

@openjdk
Copy link

openjdk bot commented Apr 27, 2021

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8198619: java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java fails on mac

Reviewed-by: aivanov, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 48 new commits pushed to the master branch:

  • 7f4a9f6: 8266088: compiler/arguments/TestPrintOptoAssemblyLineNumbers test should user driver mode
  • f560b89: 8264873: Dependencies: Split ClassHierarchyWalker
  • 0a88f0a: 8255915: jdk/incubator/vector/AddTest.java timed out
  • ab2aec2: 8265938: C2's conditional move optimization does not handle top Phi
  • 5634f20: 8265932: Move safepoint related fields from class Thread to JavaThread
  • b67b2b1: 8265690: Use the latest Ubuntu base image version in Docker testing
  • b2628d1: 8263972: C2: LoadVector/StoreVector type mismatch in MemNode::can_see_stored_value()
  • 377b346: 8264752: SIGFPE crash with option FlightRecorderOptions:threadbuffersize=30M
  • dc323a9: 8263421: Module image file is opened twice during VM startup
  • fbfd4ea: 8265914: Duplicated NotANode and not_a_node
  • ... and 38 more: https://git.openjdk.java.net/jdk/compare/6e5026a8dfa1a47d3ae486d5c85a39bb074c67fa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 27, 2021
mrserb
mrserb approved these changes Apr 27, 2021
@prsadhuk
Copy link
Contributor Author

prsadhuk commented Apr 28, 2021

/integrate

@openjdk openjdk bot closed this Apr 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 28, 2021
@openjdk
Copy link

openjdk bot commented Apr 28, 2021

@prsadhuk Since your change was applied there have been 65 commits pushed to the master branch:

  • 2201e11: 8266055: ZGC: ZHeap::print_extended_on() doesn't disable deferred delete
  • ce48f04: 8198617: java/awt/Focus/6382144/EndlessLoopTest.java fails on mac
  • 0438cea: 8136517: [macosx]Test java/awt/Focus/8073453/AWTFocusTransitionTest.java fails on MacOSX
  • 6b5e5d7: 8266181: compiler/eliminateAutobox/TestEliminateBoxInDebugInfo should be in driver mode
  • 81b1502: 8266161: mark hotspot compiler/rtm tests which ignore VM flags
  • 4a8324d: 8266180: compiler/vectorapi/TestVectorErgonomics should be run in driver mode
  • 0601aba: 8266175: mark hotspot compiler/jsr292 tests which ignore VM flags
  • 69ad8ac: 8266169: mark hotspot compiler/jvmci tests which ignore VM flags
  • 1a2a570: 8266166: mark hotspot compiler/linkage tests which ignore VM flags
  • 5ee58b0: 8266164: mark hotspot compiler/loopstripmining tests which ignore VM flags
  • ... and 55 more: https://git.openjdk.java.net/jdk/compare/6e5026a8dfa1a47d3ae486d5c85a39bb074c67fa...master

Your commit was automatically rebased without conflicts.

Pushed as commit cf92693.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8198619 branch Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awt integrated
3 participants