Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253659: ProblemList sun/security/ec/TestEC.java on linux-aarch64 #362

Closed
wants to merge 3 commits into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Sep 25, 2020

Reduce noise in CI Tier2 by ProblemListing this test.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253659: ProblemList sun/security/ec/TestEC.java on linux-aarch64

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/362/head:pull/362
$ git checkout pull/362

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 25, 2020

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 25, 2020

@dcubed-ojdk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request.

In order to have an RFR email automatically sent to the correct mailing list, you will need to add one or more labels manually using the /label add "label" command. The following labels are valid: 2d awt beans build compiler core-libs hotspot hotspot-compiler hotspot-gc hotspot-jfr hotspot-runtime i18n javadoc jdk jmx kulla net nio security serviceability shenandoah sound swing.

@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented Sep 25, 2020

/label security

@openjdk openjdk bot added the security security-dev@openjdk.org label Sep 25, 2020
@openjdk
Copy link

openjdk bot commented Sep 25, 2020

@dcubed-ojdk
The security label was successfully added.

@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented Sep 25, 2020

/label runtime

@openjdk
Copy link

openjdk bot commented Sep 25, 2020

@dcubed-ojdk The label runtime is not a valid label. These labels are valid:

  • serviceability
  • hotspot
  • sound
  • hotspot-compiler
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • 2d
  • security
  • swing
  • hotspot-runtime
  • jmx
  • build
  • nio
  • beans
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr
  • awt

@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented Sep 25, 2020

/label hotspot-runtime

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Sep 25, 2020
@openjdk
Copy link

openjdk bot commented Sep 25, 2020

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Sep 25, 2020
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 25, 2020
@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented Sep 25, 2020

My Tier2 test job ran sun/security/ec/TestEC.java on all regular Oracle
platforms except for linux-aarch64. I also updated the generic-ARCH
header comment to include 'aarch64' in the list so folks don't have to
wonder whether to use 'aarch64' or 'arm' or 'arm64'.

@mlbridge
Copy link

mlbridge bot commented Sep 25, 2020

Webrevs

iklam
iklam approved these changes Sep 25, 2020
@openjdk
Copy link

openjdk bot commented Sep 25, 2020

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253659: ProblemList sun/security/ec/TestEC.java on linux-aarch64

Reviewed-by: iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 0187567: 8250984: Memory Docker tests fail on some Linux kernels w/o cgroupv1 …

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 25, 2020
@iklam
Copy link
Member

iklam commented Sep 25, 2020

Looks like a trivial change to me.

@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented Sep 25, 2020

@iklam - thanks for the fast review.
/integrate

@openjdk openjdk bot closed this Sep 25, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated labels Sep 25, 2020
@openjdk
Copy link

openjdk bot commented Sep 25, 2020

@dcubed-ojdk Since your change was applied there has been 1 commit pushed to the master branch:

  • 0187567: 8250984: Memory Docker tests fail on some Linux kernels w/o cgroupv1 …

Your commit was automatically rebased without conflicts.

Pushed as commit 9150b90.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr Pull request is ready for review label Sep 25, 2020
@dcubed-ojdk dcubed-ojdk deleted the JDK-8253659 branch Sep 25, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 25, 2020

Mailing list message from Anthony Scarpino on security-dev:

I had the fix in review if you could have waited.

Tony

On 9/25/20 12:30 PM, Daniel D.Daugherty wrote:

@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented Sep 25, 2020

@ascarpino - sorry about that. The last time I checked your bug (about 2 hours ago)
it wasn't "in progress". Please update your fix to remove the test from the
ProblemList.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated security security-dev@openjdk.org
2 participants