Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265681: G1: general cleanup for G1FullGCHeapRegionAttr #3621

Closed
wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Apr 22, 2021

General cleanups of G1FullGCHeapRegionAttr, its APIs and usage.

Regarding the naming, SkipCompaction is another option, but I went with the current version for the consistent ing suffix across all valid states..


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265681: G1: general cleanup for G1FullGCHeapRegionAttr

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3621/head:pull/3621
$ git checkout pull/3621

Update a local copy of the PR:
$ git checkout pull/3621
$ git pull https://git.openjdk.java.net/jdk pull/3621/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3621

View PR using the GUI difftool:
$ git pr show -t 3621

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3621.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 22, 2021

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 22, 2021

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Apr 22, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 22, 2021

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Ship it :)

@openjdk
Copy link

@openjdk openjdk bot commented Apr 23, 2021

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265681: G1: general cleanup for G1FullGCHeapRegionAttr

Reviewed-by: tschatzl, sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

  • 891f72f: 8265606: Reduce allocations in AdapterHandlerLibrary::get_adapter
  • bfc1cd8: 8264320: ShouldNotReachHere in Compile::print_inlining_move_to()
  • 5db64c3: 8265268: Unify ReservedSpace reservation code in initialize and try_reserve_heap
  • 191f1fc: 8265759: Shenandoah: Avoid race for referent in assert
  • b3a319c: 8264842: IGV: different nodes sharing idx are treated as equal
  • 95f0fd6: 8265696: Move CDS sources to src/hotspot/shared/cds
  • a715b09: 8265798: Minimal build broken by JDK-8261090
  • 13d3263: 8265484: Fix up TRAPS usage in GenerateOopMap::compute_map and callers
  • a8ddbd1: 8265683: vmTestbase/nsk/jdb tests failed with "JDWP exit error AGENT_ERROR_INTERNAL(181)"
  • 7a55914: 8264196: Change link_and_cleanup_shared_classes(CATCH) to CHECK
  • ... and 24 more: https://git.openjdk.java.net/jdk/compare/71163213cbbc587842ea2dd5ce90e314ab52f6d5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 23, 2021
Copy link
Contributor

@kstefanj kstefanj left a comment

Very nice cleanup. Looks great!

@albertnetymk
Copy link
Member Author

@albertnetymk albertnetymk commented Apr 26, 2021

Thanks for the review.

/integrate

@openjdk openjdk bot closed this Apr 26, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 26, 2021

@albertnetymk Since your change was applied there have been 52 commits pushed to the master branch:

  • 578a0b3: 8261238: NMT should not limit baselining by size threshold
  • 3bf4c90: 8264317: Lanai: IncorrectUnmanagedImageRotatedClip.java fails on apple M1
  • f1f2afd: 8264028: Typo in javax.management.relation.RelationService::purgeRelations
  • f6e22d1: 8265890: ProblemList sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java on macOS-X64 and Linux-aarch64
  • 0257ac1: 8252089: Remove psParallelCompact internal debug counters
  • 4b7f027: 8231179: Investigate why tools/javac/options/BCPOrSystemNotSpecified.java fails on Window
  • d87a4c3: 8239596: PARAMETER annotation on receiver type does not cause error
  • 52f9d22: 8265884: ProblemList compiler/codecache/jmx/PoolsIndependenceTest.java on macOS-X64
  • 5aed446: 8265403: consolidate definition of CPU features
  • 20a373a: 8265393: VM crashes if both -XX:+RecordDynamicDumpInfo and -XX:SharedArchiveFile options are specified
  • ... and 42 more: https://git.openjdk.java.net/jdk/compare/71163213cbbc587842ea2dd5ce90e314ab52f6d5...master

Your commit was automatically rebased without conflicts.

Pushed as commit 56fbef0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the api branch Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
3 participants