Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8228442: DHKeyExchange/LegacyDHEKeyExchange.java failed due to "SSLException: An established connection was aborted by the software in your host machine" #3622

Closed
wants to merge 2 commits into from

Conversation

@fguallini
Copy link
Contributor

@fguallini fguallini commented Apr 22, 2021

Test DHKeyExchange/LegacyDHEKeyExchange.java has been seen to fail intermittently. There is a thread synchronisation issue that is fixed by:

  • Using SSLSocketTemplate that handles client/server socket configuration and synchronisation before connection
  • Making use of a CountDownLatch and socket linger to facilitate the socket to close gracefully after both ends have finished the transmission

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8228442: DHKeyExchange/LegacyDHEKeyExchange.java failed due to "SSLException: An established connection was aborted by the software in your host machine"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3622/head:pull/3622
$ git checkout pull/3622

Update a local copy of the PR:
$ git checkout pull/3622
$ git pull https://git.openjdk.java.net/jdk pull/3622/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3622

View PR using the GUI difftool:
$ git pr show -t 3622

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3622.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 22, 2021

👋 Welcome back fguallini! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Apr 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 22, 2021

@fguallini The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the security label Apr 22, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 22, 2021

Webrevs

Loading

Copy link
Member

@XueleiFan XueleiFan left a comment

It looks good to me. Thank you!

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 22, 2021

@fguallini This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8228442: DHKeyExchange/LegacyDHEKeyExchange.java failed due to "SSLException: An established connection was aborted by the software in your host machine"

Reviewed-by: xuelei

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 96 new commits pushed to the master branch:

  • 8e31229: 8265327: Remove check_safepoint_and_suspend_for_native_trans()
  • c9b70c8: 8265240: runtime/Thread/SuspendAtExit.java needs updating
  • 891f72f: 8265606: Reduce allocations in AdapterHandlerLibrary::get_adapter
  • bfc1cd8: 8264320: ShouldNotReachHere in Compile::print_inlining_move_to()
  • 5db64c3: 8265268: Unify ReservedSpace reservation code in initialize and try_reserve_heap
  • 191f1fc: 8265759: Shenandoah: Avoid race for referent in assert
  • b3a319c: 8264842: IGV: different nodes sharing idx are treated as equal
  • 95f0fd6: 8265696: Move CDS sources to src/hotspot/shared/cds
  • a715b09: 8265798: Minimal build broken by JDK-8261090
  • 13d3263: 8265484: Fix up TRAPS usage in GenerateOopMap::compute_map and callers
  • ... and 86 more: https://git.openjdk.java.net/jdk/compare/7d01c988cf2b2cfdc055404b0a2f78d5c18746d5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@XueleiFan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@openjdk openjdk bot added the ready label Apr 22, 2021
@fguallini
Copy link
Contributor Author

@fguallini fguallini commented Apr 23, 2021

/integrate

Loading

@openjdk openjdk bot added the sponsor label Apr 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 23, 2021

@fguallini
Your change (at version 82a86ef) is now ready to be sponsored by a Committer.

Loading

@XueleiFan
Copy link
Member

@XueleiFan XueleiFan commented Apr 28, 2021

/sponsor

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 28, 2021

@XueleiFan @fguallini Since your change was applied there have been 189 commits pushed to the master branch:

  • f40bf1d: 8266087: Move 'buffer' declaration in get_user_name_slow() inside of linux specific code
  • ec383ab: 8183374: Refactor java/lang/Runtime shell tests to java
  • 343a4a7: 8185127: Add tests to cover hashCode() method for java supported crypto key types
  • e325a75: 8264593: debug.cpp utilities should be available in product builds.
  • e879f8c: 8265587: IGV: track nodes across matching
  • 164454f: 8265867: thread.hpp defines some enums but no reference
  • 75a2354: 8266028: C2 computes -0.0 for Math.pow(-0.0, 0.5)
  • ca37be1: 8197800: Test java/awt/Focus/NonFocusableWindowTest/NoEventsTest.java fails on Windows
  • cf92693: 8198619: java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java fails on mac
  • 2201e11: 8266055: ZGC: ZHeap::print_extended_on() doesn't disable deferred delete
  • ... and 179 more: https://git.openjdk.java.net/jdk/compare/7d01c988cf2b2cfdc055404b0a2f78d5c18746d5...master

Your commit was automatically rebased without conflicts.

Pushed as commit 7e3bc4c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants