Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8197800: Test java/awt/Focus/NonFocusableWindowTest/NoEventsTest.java fails on Windows #3623

Closed
wants to merge 1 commit into from

Conversation

@prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Apr 22, 2021

This test rootcause which is

sun.awt.SunToolkit$InfiniteLoop
at sun.awt.SunToolkit.realSync(SunToolkit.java:1498)
at sun.awt.SunToolkit.realSync(SunToolkit.java:1426)
at java.awt.Robot.waitForIdle(Robot.java:574)
at NoEventsTest.pause(NoEventsTest.java:50)
at NoEventsTest.performFocusClick(NoEventsTest.java:161)
at NoEventsTest.main(NoEventsTest.java:109)

is found out to be same as with this bug JDK-8000171 via this comment
https://bugs.openjdk.java.net/browse/JDK-8000171?focusedCommentId=13825066&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13825066
which is dup of 8196100: javax/swing/text/JTextComponent/5074573/bug5074573.java fails and and fixed there.

So, we can remove the test from problemlist


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8197800: Test java/awt/Focus/NonFocusableWindowTest/NoEventsTest.java fails on Windows

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3623/head:pull/3623
$ git checkout pull/3623

Update a local copy of the PR:
$ git checkout pull/3623
$ git pull https://git.openjdk.java.net/jdk pull/3623/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3623

View PR using the GUI difftool:
$ git pr show -t 3623

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3623.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 22, 2021

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 22, 2021

@prsadhuk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Apr 22, 2021

/label add awt

@openjdk openjdk bot added the awt label Apr 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 22, 2021

@prsadhuk
The awt label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 22, 2021

Webrevs

@mrserb
Copy link
Member

@mrserb mrserb commented Apr 23, 2021

Looks like the formatting in the description is broken.

@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Apr 23, 2021

Updated

@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Apr 27, 2021

Any further comment on this?

@openjdk
Copy link

@openjdk openjdk bot commented Apr 27, 2021

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8197800: Test java/awt/Focus/NonFocusableWindowTest/NoEventsTest.java fails on Windows

Reviewed-by: aivanov, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 101 new commits pushed to the master branch:

  • 7f4a9f6: 8266088: compiler/arguments/TestPrintOptoAssemblyLineNumbers test should user driver mode
  • f560b89: 8264873: Dependencies: Split ClassHierarchyWalker
  • 0a88f0a: 8255915: jdk/incubator/vector/AddTest.java timed out
  • ab2aec2: 8265938: C2's conditional move optimization does not handle top Phi
  • 5634f20: 8265932: Move safepoint related fields from class Thread to JavaThread
  • b67b2b1: 8265690: Use the latest Ubuntu base image version in Docker testing
  • b2628d1: 8263972: C2: LoadVector/StoreVector type mismatch in MemNode::can_see_stored_value()
  • 377b346: 8264752: SIGFPE crash with option FlightRecorderOptions:threadbuffersize=30M
  • dc323a9: 8263421: Module image file is opened twice during VM startup
  • fbfd4ea: 8265914: Duplicated NotANode and not_a_node
  • ... and 91 more: https://git.openjdk.java.net/jdk/compare/ca6b1b49ab791d505573fa6ef000faec3b19256c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 27, 2021
@aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Apr 27, 2021

Looks good provided it's stable now.
Could you please add the root cause into JBS?
Otherwise it will look as if the test was removed from the problem list without any fix.

JDK-8196100 could be added as duplicate link in JBS and as relates to JDK-8000171

mrserb
mrserb approved these changes Apr 27, 2021
@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Apr 28, 2021

/integrate

@openjdk openjdk bot closed this Apr 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 28, 2021

@prsadhuk Since your change was applied there have been 119 commits pushed to the master branch:

  • cf92693: 8198619: java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java fails on mac
  • 2201e11: 8266055: ZGC: ZHeap::print_extended_on() doesn't disable deferred delete
  • ce48f04: 8198617: java/awt/Focus/6382144/EndlessLoopTest.java fails on mac
  • 0438cea: 8136517: [macosx]Test java/awt/Focus/8073453/AWTFocusTransitionTest.java fails on MacOSX
  • 6b5e5d7: 8266181: compiler/eliminateAutobox/TestEliminateBoxInDebugInfo should be in driver mode
  • 81b1502: 8266161: mark hotspot compiler/rtm tests which ignore VM flags
  • 4a8324d: 8266180: compiler/vectorapi/TestVectorErgonomics should be run in driver mode
  • 0601aba: 8266175: mark hotspot compiler/jsr292 tests which ignore VM flags
  • 69ad8ac: 8266169: mark hotspot compiler/jvmci tests which ignore VM flags
  • 1a2a570: 8266166: mark hotspot compiler/linkage tests which ignore VM flags
  • ... and 109 more: https://git.openjdk.java.net/jdk/compare/ca6b1b49ab791d505573fa6ef000faec3b19256c...master

Your commit was automatically rebased without conflicts.

Pushed as commit ca37be1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8197800 branch Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants