Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8136517: [macosx]Test java/awt/Focus/8073453/AWTFocusTransitionTest.java fails on MacOSX #3624

Closed
wants to merge 2 commits into from

Conversation

pankaj-bansal
Copy link

@pankaj-bansal pankaj-bansal commented Apr 22, 2021

The tests java/awt/Focus/8073453/AWTFocusTransitionTest.java and java/awt/Focus/8073453/SwingFocusTransitionTest.java fail on MacOS intermittently and are problem listed. The test needs lot of Robot actions. It does not test if the components are visible on the screen.

The changes fix this issue. Also, the frame is moved to centre of screen and set to be at top always. Some more cleanup is done. The test is passing for multiple iterations on all platforms on CI. Link in JBS.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8136517: [macosx]Test java/awt/Focus/8073453/AWTFocusTransitionTest.java fails on MacOSX

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3624/head:pull/3624
$ git checkout pull/3624

Update a local copy of the PR:
$ git checkout pull/3624
$ git pull https://git.openjdk.java.net/jdk pull/3624/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3624

View PR using the GUI difftool:
$ git pr show -t 3624

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3624.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 22, 2021

👋 Welcome back pbansal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 22, 2021

@pankaj-bansal The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt client-libs-dev@openjdk.org label Apr 22, 2021
@pankaj-bansal pankaj-bansal marked this pull request as ready for review Apr 23, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 23, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 23, 2021

Webrevs

@pankaj-bansal
Copy link
Author

pankaj-bansal commented Apr 28, 2021

I have reverted the unnecessary changes and now effective changes are to move the frame in centre and increase auto delay from 50ms to 100ms. I do not see anything else in test which can create problem. I have ran more than 100 iterations of these 2 tests on all 3 platforms on our CI systems and there is no failure (Links in JBS).
I would propose that we should remove the tests from Problem list with these small changes and see if there are any failures. I do not think there will be any, but of there are failures, they may be because of product issues and we may fix those accordingly.
Otherwise, I can just close this PR without integration and leave the tests problem listed

mrserb
mrserb approved these changes Apr 28, 2021
@openjdk
Copy link

openjdk bot commented Apr 28, 2021

@pankaj-bansal This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8136517: [macosx]Test  java/awt/Focus/8073453/AWTFocusTransitionTest.java fails on MacOSX

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 227 new commits pushed to the master branch:

  • 6b5e5d7: 8266181: compiler/eliminateAutobox/TestEliminateBoxInDebugInfo should be in driver mode
  • 81b1502: 8266161: mark hotspot compiler/rtm tests which ignore VM flags
  • 4a8324d: 8266180: compiler/vectorapi/TestVectorErgonomics should be run in driver mode
  • 0601aba: 8266175: mark hotspot compiler/jsr292 tests which ignore VM flags
  • 69ad8ac: 8266169: mark hotspot compiler/jvmci tests which ignore VM flags
  • 1a2a570: 8266166: mark hotspot compiler/linkage tests which ignore VM flags
  • 5ee58b0: 8266164: mark hotspot compiler/loopstripmining tests which ignore VM flags
  • 1a37bce: 8263779: SSLEngine reports NEED_WRAP continuously without producing any further output
  • 889d246: 8265917: Different values computed by C2 and interpreter/C1 for Math.pow(x, 2.0) on x86_32
  • e144104: 8262908: JFR: Allow JFR to stream events from a known repository path
  • ... and 217 more: https://git.openjdk.java.net/jdk/compare/81877f7df20c29e6716a86a1dac3eb0868d768bf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 28, 2021
@pankaj-bansal
Copy link
Author

pankaj-bansal commented Apr 28, 2021

/integrate

@openjdk openjdk bot closed this Apr 28, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 28, 2021
@openjdk
Copy link

openjdk bot commented Apr 28, 2021

@pankaj-bansal Since your change was applied there have been 227 commits pushed to the master branch:

  • 6b5e5d7: 8266181: compiler/eliminateAutobox/TestEliminateBoxInDebugInfo should be in driver mode
  • 81b1502: 8266161: mark hotspot compiler/rtm tests which ignore VM flags
  • 4a8324d: 8266180: compiler/vectorapi/TestVectorErgonomics should be run in driver mode
  • 0601aba: 8266175: mark hotspot compiler/jsr292 tests which ignore VM flags
  • 69ad8ac: 8266169: mark hotspot compiler/jvmci tests which ignore VM flags
  • 1a2a570: 8266166: mark hotspot compiler/linkage tests which ignore VM flags
  • 5ee58b0: 8266164: mark hotspot compiler/loopstripmining tests which ignore VM flags
  • 1a37bce: 8263779: SSLEngine reports NEED_WRAP continuously without producing any further output
  • 889d246: 8265917: Different values computed by C2 and interpreter/C1 for Math.pow(x, 2.0) on x86_32
  • e144104: 8262908: JFR: Allow JFR to stream events from a known repository path
  • ... and 217 more: https://git.openjdk.java.net/jdk/compare/81877f7df20c29e6716a86a1dac3eb0868d768bf...master

Your commit was automatically rebased without conflicts.

Pushed as commit 0438cea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@pankaj-bansal pankaj-bansal deleted the JDK-8136517 branch Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awt client-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants