Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265689: JVMCI: InternalError: Class java.lang.Object does not implement interface jdk.vm.ci.meta.JavaType #3625

Closed
wants to merge 1 commit into from

Conversation

@iwanowww
Copy link

@iwanowww iwanowww commented Apr 22, 2021

The fix for JDK-8264918 (#3396) strengthened the checks on JVM side, but overlooked that CompilerToVM.getVtableIndexForInterfaceMethod callers should be adjusted as well to avoid calling into the JVM with сonflicting arguments.

Testing:

  • hs-tier1 - hs-tier4

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265689: JVMCI: InternalError: Class java.lang.Object does not implement interface jdk.vm.ci.meta.JavaType

Reviewers

Contributors

  • Doug Simon <dnsimon@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3625/head:pull/3625
$ git checkout pull/3625

Update a local copy of the PR:
$ git checkout pull/3625
$ git pull https://git.openjdk.java.net/jdk pull/3625/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3625

View PR using the GUI difftool:
$ git pr show -t 3625

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3625.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 22, 2021

👋 Welcome back vlivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 22, 2021

@iwanowww The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@iwanowww
Copy link
Author

@iwanowww iwanowww commented Apr 22, 2021

/contributor add dnsimon

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 22, 2021

@iwanowww
Contributor Doug Simon <dnsimon@openjdk.org> successfully added.

Loading

@iwanowww iwanowww marked this pull request as ready for review Apr 23, 2021
@openjdk openjdk bot added the rfr label Apr 23, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 23, 2021

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 23, 2021

@iwanowww This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265689: JVMCI: InternalError: Class java.lang.Object does not implement interface jdk.vm.ci.meta.JavaType

Co-authored-by: Doug Simon <dnsimon@openjdk.org>
Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 50 new commits pushed to the master branch:

  • 0d08d73: 8265702: ZGC on macOS/aarch64
  • 45c5da0: 8265746: Update java.time to use instanceof pattern variable (part II)
  • a85f6cb: 8265613: False positives for "Related Packages"
  • 6e5026a: 8198621: java/awt/Focus/KeyEventForBadFocusOwnerTest/KeyEventForBadFocusOwnerTest.java fails on mac
  • 7b609a2: 8264031: (zipfs) Typo in ZipFileSystem.deleteFile ZipException
  • 56fbef0: 8265681: G1: general cleanup for G1FullGCHeapRegionAttr
  • 578a0b3: 8261238: NMT should not limit baselining by size threshold
  • 3bf4c90: 8264317: Lanai: IncorrectUnmanagedImageRotatedClip.java fails on apple M1
  • f1f2afd: 8264028: Typo in javax.management.relation.RelationService::purgeRelations
  • f6e22d1: 8265890: ProblemList sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java on macOS-X64 and Linux-aarch64
  • ... and 40 more: https://git.openjdk.java.net/jdk/compare/86bd44fe80c6222f81662b2167c402571ed68f43...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Apr 23, 2021
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good.

Loading

@iwanowww
Copy link
Author

@iwanowww iwanowww commented Apr 26, 2021

Thanks for the reviews, Vladimir and Tobias.

Loading

@iwanowww
Copy link
Author

@iwanowww iwanowww commented Apr 26, 2021

/integrate

Loading

@openjdk openjdk bot closed this Apr 26, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 26, 2021

@iwanowww Since your change was applied there have been 50 commits pushed to the master branch:

  • 0d08d73: 8265702: ZGC on macOS/aarch64
  • 45c5da0: 8265746: Update java.time to use instanceof pattern variable (part II)
  • a85f6cb: 8265613: False positives for "Related Packages"
  • 6e5026a: 8198621: java/awt/Focus/KeyEventForBadFocusOwnerTest/KeyEventForBadFocusOwnerTest.java fails on mac
  • 7b609a2: 8264031: (zipfs) Typo in ZipFileSystem.deleteFile ZipException
  • 56fbef0: 8265681: G1: general cleanup for G1FullGCHeapRegionAttr
  • 578a0b3: 8261238: NMT should not limit baselining by size threshold
  • 3bf4c90: 8264317: Lanai: IncorrectUnmanagedImageRotatedClip.java fails on apple M1
  • f1f2afd: 8264028: Typo in javax.management.relation.RelationService::purgeRelations
  • f6e22d1: 8265890: ProblemList sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java on macOS-X64 and Linux-aarch64
  • ... and 40 more: https://git.openjdk.java.net/jdk/compare/86bd44fe80c6222f81662b2167c402571ed68f43...master

Your commit was automatically rebased without conflicts.

Pushed as commit 9647fb0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants