Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263621: Convert jdk.compiler to use Stream.toList() #3629

Closed

Conversation

@igraves
Copy link
Member

@igraves igraves commented Apr 22, 2021

Converting use of Collectors.toList() to Stream.toList() where appropriate. Per JDK-8260559.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263621: Convert jdk.compiler to use Stream.toList()

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3629/head:pull/3629
$ git checkout pull/3629

Update a local copy of the PR:
$ git checkout pull/3629
$ git pull https://git.openjdk.java.net/jdk pull/3629/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3629

View PR using the GUI difftool:
$ git pr show -t 3629

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3629.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 22, 2021

👋 Welcome back igraves! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Apr 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 22, 2021

@igraves The following labels will be automatically applied to this pull request:

  • compiler
  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 22, 2021

Webrevs

Loading

Copy link
Contributor

@mcimadamore mcimadamore left a comment

Looks good!

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 22, 2021

@igraves This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263621: Convert jdk.compiler to use Stream.toList()

Reviewed-by: mcimadamore, vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mcimadamore, @vicente-romero-oracle) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@openjdk openjdk bot added the ready label Apr 22, 2021
Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle left a comment

looks good

Loading

@igraves
Copy link
Member Author

@igraves igraves commented Apr 22, 2021

Thanks, all. Not a major change, ran tests last night and it was passing so given two reviewers I'll go ahead and integrate. This one will require a sponsor as I'm not a committer yet. If you want to wait for additional eyes on, that is fine by me too.

Loading

@igraves
Copy link
Member Author

@igraves igraves commented Apr 22, 2021

/integrate

Loading

@openjdk openjdk bot added the sponsor label Apr 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 22, 2021

@igraves
Your change (at version 19253b5) is now ready to be sponsored by a Committer.

Loading

@mcimadamore
Copy link
Contributor

@mcimadamore mcimadamore commented Apr 22, 2021

/sponsor

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 22, 2021

@mcimadamore @igraves Since your change was applied there have been 17 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 33a86b9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants