8241151: Incorrect lint warning for no definition of serialVersionUID in a record #363

vicente-romero-oracle · 2020-09-25T17:45:10Z

Co-authored-by: Bernard Blaser bsrbnd@gmail.com
Co-authored-by: Vicente Romero vicente.romero@oracle.com

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8241151: Incorrect lint warning for no definition of serialVersionUID in a record

Reviewers

Jonathan Gibbons (@jonathan-gibbons - Reviewer)

Contributors

Bernard Blaser <bsrbnd@gmail.com>
Vicente Romero <vicente.romero@oracle.com>

Download

$ git fetch https://git.openjdk.java.net/jdk pull/363/head:pull/363
$ git checkout pull/363

… in a record Co-authored-by: Bernard Blaser <bsrbnd@gmail.com> Co-authored-by: Vicente Romero <vicente.romero@oracle.com>

vicente-romero-oracle · 2020-09-25T17:45:34Z

/test tier1

bridgekeeper · 2020-09-25T17:47:13Z

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2020-09-25T17:48:50Z

@vicente-romero-oracle The following label will be automatically applied to this pull request: compiler.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

mlbridge · 2020-09-25T18:14:23Z

Webrevs

01: Full - Incremental (4479315)
00: Full (7b76244)

openjdk · 2020-09-25T18:36:35Z

Could not create test job

vicente-romero-oracle · 2020-09-28T19:40:55Z

/test tier1

openjdk · 2020-09-28T19:43:22Z

Could not create test job

jonathan-gibbons

You should add a bug number to the test.

jonathan-gibbons · 2020-09-28T19:50:42Z

test/langtools/tools/javac/records/RecordCompilationTests.java

    public RecordCompilationTests() {
-        boolean useAP = System.getProperty("useAP") == null ? false : System.getProperty("useAP").equals("true");
+        useAP = System.getProperty("useAP") == null ? false : System.getProperty("useAP").equals("true");


I know this is unrelated to your change, but this line could be improved with

useAP = System.getProperty("useAP", "false").equals("true")

vicente-romero-oracle · 2020-09-28T20:56:17Z

/test

openjdk · 2020-09-28T21:06:16Z

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8241151: Incorrect lint warning for no definition of serialVersionUID in a record

Co-authored-by: Bernard Blaser <bsrbnd@gmail.com>
Co-authored-by: Vicente Romero <vicente.romero@oracle.com>
Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

d25b03e: 8253616: Change to GCC 10.2 for building on Linux at Oracle
821bd08: 8253667: ProblemList tools/jlink/JLinkReproducible{,3}Test.java on linux-aarch64
1ae6b53: 8252194: Add automated test for fix done in JDK-8218469
77a0f39: 8253540: InterpreterRuntime::monitorexit should be a JRT_LEAF function
0054c15: 8253435: Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist
8e338f6: 8253646: ZGC: Avoid overhead of sorting ZStatIterableValues on bootstrap
ec9bee6: 8253015: Aarch64: Move linux code out from generic CPU feature detection
16b8c39: 8253053: Javadoc clean up in Authenticator and BasicAuthenicator
840aa2b: 8253424: Add support for running pre-submit testing using GitHub Actions
8e87d46: 8252857: AArch64: Shenandoah C1 CAS is not sequentially consistent
... and 17 more: https://git.openjdk.java.net/jdk/compare/a75edc29c6ce41116cc99530aa1710efb62c6d5a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

vicente-romero-oracle · 2020-09-28T21:17:00Z

/contributor add Bernard Blaser bsrbnd@gmail.com

vicente-romero-oracle · 2020-09-28T21:17:32Z

/contributor add Vicente Romero vicente.romero@oracle.com

openjdk · 2020-09-28T21:18:21Z

@vicente-romero-oracle
Contributor Bernard Blaser <bsrbnd@gmail.com> successfully added.

vicente-romero-oracle · 2020-09-28T21:18:32Z

/integrate

openjdk · 2020-09-28T21:18:46Z

@vicente-romero-oracle
Contributor Vicente Romero <vicente.romero@oracle.com> successfully added.

openjdk · 2020-09-28T21:20:33Z

@vicente-romero-oracle Since your change was applied there have been 27 commits pushed to the master branch:

d25b03e: 8253616: Change to GCC 10.2 for building on Linux at Oracle
821bd08: 8253667: ProblemList tools/jlink/JLinkReproducible{,3}Test.java on linux-aarch64
1ae6b53: 8252194: Add automated test for fix done in JDK-8218469
77a0f39: 8253540: InterpreterRuntime::monitorexit should be a JRT_LEAF function
0054c15: 8253435: Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist
8e338f6: 8253646: ZGC: Avoid overhead of sorting ZStatIterableValues on bootstrap
ec9bee6: 8253015: Aarch64: Move linux code out from generic CPU feature detection
16b8c39: 8253053: Javadoc clean up in Authenticator and BasicAuthenicator
840aa2b: 8253424: Add support for running pre-submit testing using GitHub Actions
8e87d46: 8252857: AArch64: Shenandoah C1 CAS is not sequentially consistent
... and 17 more: https://git.openjdk.java.net/jdk/compare/a75edc29c6ce41116cc99530aa1710efb62c6d5a...master

Your commit was automatically rebased without conflicts.

Pushed as commit ac15d64.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk · 2020-09-28T21:24:11Z

Could not create test job

JarvisCraft · 2020-09-29T00:05:25Z

test/langtools/tools/javac/records/RecordCompilationTests.java

    public RecordCompilationTests() {
-        boolean useAP = System.getProperty("useAP") == null ? false : System.getProperty("useAP").equals("true");
+        useAP = System.getProperty("useAP", "false").equals("true");


Can't Boolean.getBoolean("useAP") be used here instead?

it could be used, but the test could potentially be executed from command line too and there is no guarantee that the system property will be there if executed from the command line

As I understand, call to Boolean.getBoolean("useAP") is identical to your variant as it also relies on System#getProperty(String) so I cannot see any different behaviour if using it:

jdk/src/java.base/share/classes/java/lang/Boolean.java

Lines 272 to 279 in 8df3e72

public static boolean getBoolean(String name) {

boolean result = false;

try {

result = parseBoolean(System.getProperty(name));

} catch (IllegalArgumentException | NullPointerException e) {

}

return result;

}

mlbridge · 2020-09-29T22:29:51Z

Mailing list message from Jonathan Gibbons on compiler-dev:

Yes, Boolean.getBoolean could have been used, but to be accurate, the
behavior is not identical, and given this is just test code that has
already been integrated, I don't see the point in changing it.

-- Jon

On 9/29/20 3:16 PM, PROgrm_JARvis wrote:

8241151: Incorrect lint warning for no definition of serialVersionUID…

7b76244

… in a record Co-authored-by: Bernard Blaser <bsrbnd@gmail.com> Co-authored-by: Vicente Romero <vicente.romero@oracle.com>

openjdk bot added the rfr Pull request is ready for review label Sep 25, 2020

openjdk bot added the compiler compiler-dev@openjdk.org label Sep 25, 2020

jonathan-gibbons suggested changes Sep 28, 2020

View reviewed changes

adding bug number to test and updating code as per review comments

4479315

jonathan-gibbons approved these changes Sep 28, 2020

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Sep 28, 2020

openjdk bot closed this Sep 28, 2020

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 28, 2020

vicente-romero-oracle deleted the JDK-8241151 branch September 28, 2020 21:22

JarvisCraft reviewed Sep 29, 2020

View reviewed changes

8241151: Incorrect lint warning for no definition of serialVersionUID in a record #363

8241151: Incorrect lint warning for no definition of serialVersionUID in a record #363

vicente-romero-oracle commented Sep 25, 2020 •

edited by openjdk bot

vicente-romero-oracle commented Sep 25, 2020

bridgekeeper bot commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

mlbridge bot commented Sep 25, 2020 •

edited

openjdk bot commented Sep 25, 2020

vicente-romero-oracle commented Sep 28, 2020

openjdk bot commented Sep 28, 2020

jonathan-gibbons left a comment

jonathan-gibbons Sep 28, 2020

vicente-romero-oracle commented Sep 28, 2020

openjdk bot commented Sep 28, 2020 •

edited

vicente-romero-oracle commented Sep 28, 2020

vicente-romero-oracle commented Sep 28, 2020

openjdk bot commented Sep 28, 2020

vicente-romero-oracle commented Sep 28, 2020

openjdk bot commented Sep 28, 2020

openjdk bot commented Sep 28, 2020

openjdk bot commented Sep 28, 2020

JarvisCraft Sep 29, 2020

vicente-romero-oracle Sep 29, 2020

JarvisCraft Sep 29, 2020

mlbridge bot commented Sep 29, 2020

	public static boolean getBoolean(String name) {
	boolean result = false;
	try {
	result = parseBoolean(System.getProperty(name));
	} catch (IllegalArgumentException \| NullPointerException e) {
	}
	return result;
	}

8241151: Incorrect lint warning for no definition of serialVersionUID in a record #363

8241151: Incorrect lint warning for no definition of serialVersionUID in a record #363

Conversation

vicente-romero-oracle commented Sep 25, 2020 • edited by openjdk bot

Progress

Issue

Reviewers

Contributors

Download

vicente-romero-oracle commented Sep 25, 2020

bridgekeeper bot commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

mlbridge bot commented Sep 25, 2020 • edited

Webrevs

openjdk bot commented Sep 25, 2020

vicente-romero-oracle commented Sep 28, 2020

openjdk bot commented Sep 28, 2020

jonathan-gibbons left a comment

Choose a reason for hiding this comment

jonathan-gibbons Sep 28, 2020

Choose a reason for hiding this comment

vicente-romero-oracle commented Sep 28, 2020

openjdk bot commented Sep 28, 2020 • edited

vicente-romero-oracle commented Sep 28, 2020

vicente-romero-oracle commented Sep 28, 2020

openjdk bot commented Sep 28, 2020

vicente-romero-oracle commented Sep 28, 2020

openjdk bot commented Sep 28, 2020

openjdk bot commented Sep 28, 2020

openjdk bot commented Sep 28, 2020

JarvisCraft Sep 29, 2020

Choose a reason for hiding this comment

vicente-romero-oracle Sep 29, 2020

Choose a reason for hiding this comment

JarvisCraft Sep 29, 2020

Choose a reason for hiding this comment

mlbridge bot commented Sep 29, 2020

vicente-romero-oracle commented Sep 25, 2020 •

edited by openjdk bot

mlbridge bot commented Sep 25, 2020 •

edited

openjdk bot commented Sep 28, 2020 •

edited