8265683: vmTestbase/nsk/jdb tests failed with "JDWP exit error AGENT_ERROR_INTERNAL(181)" by plummercj · Pull Request #3634 · openjdk/jdk

plummercj · 2021-04-22T15:59:09Z

This bug was introduced by my recent changes for JDK-8265028, which attempted to speed up ThreadNode lookups by not looking in the runningThreads list if the TLS lookup failed. At the time it was thought that the thread could not possibly be on the list, but it turns out sometimes it can.

For now I'm just doing a quick fix to replace the assert being triggered with a lookup instead, which is pretty much how it worked before JDK-8265028. However, I eventually want to get back to not having to do the lookup, but first I need to better understand why this is happening in the first place, and the tests are failing too often to wait for that, thus the quick fix.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8265683: vmTestbase/nsk/jdb tests failed with "JDWP exit error AGENT_ERROR_INTERNAL(181)"

Reviewers

Alex Menkov (@alexmenkov - Reviewer) ⚠️ Review applies to 784962d
Daniel D. Daugherty (@dcubed-ojdk - Reviewer) ⚠️ Review applies to 784962d

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3634/head:pull/3634
$ git checkout pull/3634

Update a local copy of the PR:
$ git checkout pull/3634
$ git pull https://git.openjdk.java.net/jdk pull/3634/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3634

View PR using the GUI difftool:
$ git pr show -t 3634

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3634.diff

bridgekeeper · 2021-04-22T16:00:30Z

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-04-22T16:02:13Z

@plummercj The following label will be automatically applied to this pull request:

serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

plummercj · 2021-04-22T17:41:27Z

/issue JDK-8265683

openjdk · 2021-04-22T17:42:28Z

@plummercj This issue is referenced in the PR title - it will now be updated.

mlbridge · 2021-04-22T18:13:39Z

Webrevs

01: Full - Incremental (b65a64af)
00: Full (784962da)

openjdk · 2021-04-22T20:06:15Z

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265683: vmTestbase/nsk/jdb tests failed with "JDWP exit error AGENT_ERROR_INTERNAL(181)"

Reviewed-by: amenkov, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

7a55914: 8264196: Change link_and_cleanup_shared_classes(CATCH) to CHECK
b84f690: 8265793: Remove duplicate jtreg TEST.groups references for some client tests
0e00598: 8265782: Bump bootjdk to jdk-17+19 on macosx-aarch64 at Oracle
e81baea: 8265786: ProblemList serviceability/sa/sadebugd/DisableRegistryTest.java on ZGC
ca0de26: 8265699: (bf) Scopes passed to ScopedMemoryAccess.copy[Swap]Memory in incorrect order
b930bb1: 8265461: G1: Forwarding pointer removal thread sizing
f834557: 8258915: Temporary buffer cleanup
31d8a19: 8265105: gc/arguments/TestSelectDefaultGC.java fails when compiler1 is disabled
657f103: 8057543: Replace javac's Filter with Predicate (and lambdas)
8758b55: 8265591: Remove vestiages of intermediate JSR 175 annotation format
... and 2 more: https://git.openjdk.java.net/jdk/compare/9499175064a8073f37a63a2696fb47f26ae89865...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

dcubed-ojdk

Thumbs up for the quick and dirty fix.

Do you plan to another bug to continue your investigation?

dcubed-ojdk · 2021-04-22T20:10:26Z

src/jdk.jdwp.agent/share/native/libjdwp/threadControl.c

+         * Search runningThreads list. The TLS lookup may have failed because the
+         * thread has terminated, but the ThreadNode may still be present.
+         */
+        if ( node == NULL ) {


nit - s/( /(/ and s/ )/)/

The extra spaces are intentional to remain consistent with the surrounding code.

dcubed-ojdk · 2021-04-22T20:10:43Z

src/jdk.jdwp.agent/share/native/libjdwp/threadControl.c

+         * thread has terminated, but the ThreadNode may still be present.
+         */
+        if ( node == NULL ) {
+            if (list == NULL || list == &runningThreads ) {


nit - s/ )/)/

In that case, this one is inconsistent.

plummercj · 2021-04-22T21:44:12Z

Do you plan to another bug to continue your investigation?

Yes. The search of runningThreads becomes a performance issue in Loom when the list could have a million items.

dcubed-ojdk · 2021-04-22T21:52:20Z

src/jdk.jdwp.agent/share/native/libjdwp/threadControl.c

+         * thread has terminated, but the ThreadNode may still be present.
+         */
+        if ( node == NULL ) {
+            if (list == NULL || list == &runningThreads ) {


In that case, this one is inconsistent.

plummercj · 2021-04-22T23:26:45Z

/integrate

openjdk · 2021-04-22T23:27:55Z

@plummercj Since your change was applied there have been 12 commits pushed to the master branch:

7a55914: 8264196: Change link_and_cleanup_shared_classes(CATCH) to CHECK
b84f690: 8265793: Remove duplicate jtreg TEST.groups references for some client tests
0e00598: 8265782: Bump bootjdk to jdk-17+19 on macosx-aarch64 at Oracle
e81baea: 8265786: ProblemList serviceability/sa/sadebugd/DisableRegistryTest.java on ZGC
ca0de26: 8265699: (bf) Scopes passed to ScopedMemoryAccess.copy[Swap]Memory in incorrect order
b930bb1: 8265461: G1: Forwarding pointer removal thread sizing
f834557: 8258915: Temporary buffer cleanup
31d8a19: 8265105: gc/arguments/TestSelectDefaultGC.java fails when compiler1 is disabled
657f103: 8057543: Replace javac's Filter with Predicate (and lambdas)
8758b55: 8265591: Remove vestiages of intermediate JSR 175 annotation format
... and 2 more: https://git.openjdk.java.net/jdk/compare/9499175064a8073f37a63a2696fb47f26ae89865...master

Your commit was automatically rebased without conflicts.

Pushed as commit a8ddbd1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Lookup node in runningThreads list rather than assert.

784962d

openjdk bot added the serviceability serviceability-dev@openjdk.org label Apr 22, 2021

plummercj changed the title ~~8261702: vmTestbase/nsk/jdb tests failed with "JDWP exit error AGENT_ERROR_INTERNAL(181)"~~ 8265683: vmTestbase/nsk/jdb tests failed with "JDWP exit error AGENT_ERROR_INTERNAL(181)" Apr 22, 2021

plummercj marked this pull request as ready for review April 22, 2021 18:01

openjdk bot added the rfr Pull request is ready for review label Apr 22, 2021

alexmenkov approved these changes Apr 22, 2021

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 22, 2021

dcubed-ojdk approved these changes Apr 22, 2021

View reviewed changes

Minor formatting fix.

b65a64a

openjdk bot closed this Apr 22, 2021

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 22, 2021

plummercj deleted the 8265683_tls_fix branch December 13, 2021 19:12

Conversation

plummercj commented Apr 22, 2021 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Apr 22, 2021

Uh oh!

openjdk bot commented Apr 22, 2021

Uh oh!

plummercj commented Apr 22, 2021

Uh oh!

openjdk bot commented Apr 22, 2021

Uh oh!

mlbridge bot commented Apr 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

openjdk bot commented Apr 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dcubed-ojdk left a comment

Choose a reason for hiding this comment

Uh oh!

dcubed-ojdk Apr 22, 2021

Choose a reason for hiding this comment

Uh oh!

plummercj Apr 22, 2021

Choose a reason for hiding this comment

Uh oh!

dcubed-ojdk Apr 22, 2021

Choose a reason for hiding this comment

Uh oh!

dcubed-ojdk Apr 22, 2021

Choose a reason for hiding this comment

Uh oh!

plummercj Apr 22, 2021

Choose a reason for hiding this comment

Uh oh!

plummercj commented Apr 22, 2021

Uh oh!

dcubed-ojdk Apr 22, 2021

Choose a reason for hiding this comment

Uh oh!

plummercj commented Apr 22, 2021

Uh oh!

openjdk bot commented Apr 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

plummercj commented Apr 22, 2021 •

edited by openjdk bot

Loading

mlbridge bot commented Apr 22, 2021 •

edited

Loading

openjdk bot commented Apr 22, 2021 •

edited

Loading