8264196: Change link_and_cleanup_shared_classes(CATCH) to CHECK

[calvinccheung]

Please review this simple fix for passing in CHECK instead of CATCH when calling link_and_cleanup_shared_classes() since it could throw an exception.

Testing: tiers 1 and 2 on mach5.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8264196: Change link_and_cleanup_shared_classes(CATCH) to CHECK

Reviewers

• Yumin Qi (@yminqi - Reviewer)
• Ioi Lam (@iklam - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3640/head:pull/3640
$ git checkout pull/3640

Update a local copy of the PR:
$ git checkout pull/3640
$ git pull https://git.openjdk.java.net/jdk pull/3640/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3640

View PR using the GUI difftool:
$ git pr show -t 3640

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3640.diff

[bridgekeeper]

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[calvinccheung]

/label add hotspot-runtime

[openjdk]

@calvinccheung
The hotspot-runtime label was successfully added.

[mlbridge]

Webrevs

• 00: Full (232c00ef)

[yminqi]

LGTM

[openjdk]

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264196: Change link_and_cleanup_shared_classes(CATCH) to CHECK

Reviewed-by: minqi, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 0e00598: 8265782: Bump bootjdk to jdk-17+19 on macosx-aarch64 at Oracle
• e81baea: 8265786: ProblemList serviceability/sa/sadebugd/DisableRegistryTest.java on ZGC
• ca0de26: 8265699: (bf) Scopes passed to ScopedMemoryAccess.copy[Swap]Memory in incorrect order
• b930bb1: 8265461: G1: Forwarding pointer removal thread sizing
• f834557: 8258915: Temporary buffer cleanup
• 31d8a19: 8265105: gc/arguments/TestSelectDefaultGC.java fails when compiler1 is disabled

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[iklam]

Looks good and trivial.

[calvinccheung]

@yminqi, @iklam, thanks for your quick review.

[calvinccheung]

/integrate

[openjdk]

@calvinccheung Since your change was applied there have been 7 commits pushed to the master branch:

• b84f690: 8265793: Remove duplicate jtreg TEST.groups references for some client tests
• 0e00598: 8265782: Bump bootjdk to jdk-17+19 on macosx-aarch64 at Oracle
• e81baea: 8265786: ProblemList serviceability/sa/sadebugd/DisableRegistryTest.java on ZGC
• ca0de26: 8265699: (bf) Scopes passed to ScopedMemoryAccess.copy[Swap]Memory in incorrect order
• b930bb1: 8265461: G1: Forwarding pointer removal thread sizing
• f834557: 8258915: Temporary buffer cleanup
• 31d8a19: 8265105: gc/arguments/TestSelectDefaultGC.java fails when compiler1 is disabled

Your commit was automatically rebased without conflicts.

Pushed as commit 7a55914.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.