8265248: Implementation Specific Properties: change prefix, plus add existing properties #3644

JoeWang-Java · 2021-04-23T00:41:17Z

Update module summary, add a few existing properties and features into the tables.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8265248: Implementation Specific Properties: change prefix, plus add existing properties

Reviewers

Lance Andersen (@LanceAndersen - Reviewer)
Roger Riggs (@RogerRiggs - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3644/head:pull/3644
$ git checkout pull/3644

Update a local copy of the PR:
$ git checkout pull/3644
$ git pull https://git.openjdk.java.net/jdk pull/3644/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3644

View PR using the GUI difftool:
$ git pr show -t 3644

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3644.diff

…existing properties

bridgekeeper · 2021-04-23T00:42:05Z

👋 Welcome back joehw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-04-23T00:44:06Z

@JoeWang-Java The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2021-04-23T00:47:48Z

Webrevs

JoeWang-Java · 2021-04-23T04:50:56Z

/csr

openjdk · 2021-04-23T04:51:36Z

@JoeWang-Java this pull request will not be integrated until the CSR request JDK-8265252 for issue JDK-8265248 has been approved.

LanceAndersen

Good morning Joe,

The changes look good based on the discussions we have had about the change and the property documentation is more convenient to find

RogerRiggs · 2021-04-28T16:21:00Z

src/java.xml/share/classes/com/sun/org/apache/xalan/internal/utils/XMLSecurityManager.java

-            try {
+            int temp;
+            if (Integer.class.isAssignableFrom(value.getClass())) {
+                temp = (Integer)value;


Why not use pattern matching?
`if (value instanceof Integer intValue) {
temp = intValue;
}

Good question. Given that the earlier changes in the whole set (impl-specific properties) were backported, I assumed this would too, to be complete. Code consistency and clean backport may exceed the benefit of a more advanced code feature (e.g. pattern matching).

I also am still doing works based on JDK 8, that provides a much quicker turnaround.

Saw Patrick's pattern matching changesets for some lib code. It's possible we could do it as well for the xml code. But in general, xml code, esp. those from Apache support a lower source level.

ok, JDK 8 could use instanceof instead of isAssignable.

Thanks. Updated.

LanceAndersen

Looks fine Joe. Thank you for the additional updates for clarity

RogerRiggs

The new table looks fine, ut I think it will be less confusing if the property names are fully qualified (with the jdk.xml prefix) and can be seen as identical to the names in the previous table.

…left instead of center

RogerRiggs

Look good, Thanks

openjdk · 2021-05-17T17:17:23Z

@JoeWang-Java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265248: Implementation Specific Properties: change prefix, plus add existing properties

Reviewed-by: lancea, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 87 new commits pushed to the master branch:

de91643: 8267611: Print more info when pointer_delta assert fails
a4c46e1: 8263202: Update Hebrew/Indonesian/Yiddish ISO 639 language codes to current
9c346a1: 8266963: Remove safepoint poll introduced in 8262443 due to reentrance issue
45e0597: 8264302: Create implementation for Accessibility native peer for Splitpane java role
4343997: 8267708: Remove references to com.sun.tools.javadoc.**
f632254: 8267221: jshell feedback is incorrect when creating method with array varargs parameter
bf8d4a8: 8267583: jmod fails on symlink to class file
083416d: 8267130: Memory Overflow in Disassembler::load_library
9d305b9: 8252372: Check if cloning is required to move loads out of loops in PhaseIdealLoop::split_if_with_blocks_post()
0394416: 8267468: Rename refill waster counters in ThreadLocalAllocBuffer
... and 77 more: https://git.openjdk.java.net/jdk/compare/8e3549fc736539a45534dfe2b417170b5c991c7d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

involve many (57) classes.

…made new ones take preference

JoeWang-Java · 2021-05-26T19:32:58Z

/integrate

openjdk · 2021-05-26T19:34:29Z

@JoeWang-Java Since your change was applied there have been 88 commits pushed to the master branch:

c59484e: 8267653: Remove Mutex::_safepoint_check_sometimes
de91643: 8267611: Print more info when pointer_delta assert fails
a4c46e1: 8263202: Update Hebrew/Indonesian/Yiddish ISO 639 language codes to current
9c346a1: 8266963: Remove safepoint poll introduced in 8262443 due to reentrance issue
45e0597: 8264302: Create implementation for Accessibility native peer for Splitpane java role
4343997: 8267708: Remove references to com.sun.tools.javadoc.**
f632254: 8267221: jshell feedback is incorrect when creating method with array varargs parameter
bf8d4a8: 8267583: jmod fails on symlink to class file
083416d: 8267130: Memory Overflow in Disassembler::load_library
9d305b9: 8252372: Check if cloning is required to move loads out of loops in PhaseIdealLoop::split_if_with_blocks_post()
... and 78 more: https://git.openjdk.java.net/jdk/compare/8e3549fc736539a45534dfe2b417170b5c991c7d...master

Your commit was automatically rebased without conflicts.

Pushed as commit 8c4719a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8265248: Implementation Specific Properties: change prefix, plus add …

dde2e36

…existing properties

openjdk bot added the rfr Pull request is ready for review label Apr 23, 2021

openjdk bot added the core-libs core-libs-dev@openjdk.org label Apr 23, 2021

openjdk bot added the csr Pull request needs approved CSR before integration label Apr 23, 2021

LanceAndersen approved these changes Apr 25, 2021

View reviewed changes

Update the CSR. See Update 03 in the CSR

e88be26

RogerRiggs reviewed Apr 28, 2021

View reviewed changes

replace isAssignableFrom with instanceof

78047dc

RogerRiggs approved these changes May 3, 2021

View reviewed changes

Add legacy property names table

466dc3b

LanceAndersen approved these changes May 12, 2021

View reviewed changes

RogerRiggs suggested changes May 12, 2021

View reviewed changes

Thanks Roger. Changed to fully qualified names. Also made them align …

70f634d

…left instead of center

RogerRiggs approved these changes May 12, 2021

View reviewed changes

LanceAndersen approved these changes May 12, 2021

View reviewed changes

openjdk bot removed the csr Pull request needs approved CSR before integration label May 17, 2021

openjdk bot added the ready Pull request is ready to be integrated label May 17, 2021

JoeWang-Java added 2 commits May 20, 2021 05:02

Merge branch 'master' into JDK-8265248 before a major commit that will

d435692

involve many (57) classes.

Consolidated impl specific properties; deprecated legacy properties; …

ab349bb

…made new ones take preference

LanceAndersen approved these changes May 26, 2021

View reviewed changes

RogerRiggs approved these changes May 26, 2021

View reviewed changes

openjdk bot closed this May 26, 2021

openjdk bot added the integrated Pull request has been integrated label May 26, 2021

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 26, 2021

JoeWang-Java deleted the JDK-8265248 branch May 26, 2021 22:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8265248: Implementation Specific Properties: change prefix, plus add existing properties #3644

8265248: Implementation Specific Properties: change prefix, plus add existing properties #3644

JoeWang-Java commented Apr 23, 2021 •

edited by openjdk bot

Loading

bridgekeeper bot commented Apr 23, 2021

openjdk bot commented Apr 23, 2021

mlbridge bot commented Apr 23, 2021 •

edited

Loading

JoeWang-Java commented Apr 23, 2021

openjdk bot commented Apr 23, 2021

LanceAndersen left a comment

RogerRiggs Apr 28, 2021

JoeWang-Java Apr 28, 2021

RogerRiggs Apr 28, 2021

JoeWang-Java Apr 28, 2021

LanceAndersen left a comment

RogerRiggs left a comment

RogerRiggs left a comment

openjdk bot commented May 17, 2021 •

edited

Loading

JoeWang-Java commented May 26, 2021

openjdk bot commented May 26, 2021

8265248: Implementation Specific Properties: change prefix, plus add existing properties #3644

8265248: Implementation Specific Properties: change prefix, plus add existing properties #3644

Conversation

JoeWang-Java commented Apr 23, 2021 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Apr 23, 2021

openjdk bot commented Apr 23, 2021

mlbridge bot commented Apr 23, 2021 • edited Loading

Webrevs

JoeWang-Java commented Apr 23, 2021

openjdk bot commented Apr 23, 2021

LanceAndersen left a comment

Choose a reason for hiding this comment

RogerRiggs Apr 28, 2021

Choose a reason for hiding this comment

JoeWang-Java Apr 28, 2021

Choose a reason for hiding this comment

RogerRiggs Apr 28, 2021

Choose a reason for hiding this comment

JoeWang-Java Apr 28, 2021

Choose a reason for hiding this comment

LanceAndersen left a comment

Choose a reason for hiding this comment

RogerRiggs left a comment

Choose a reason for hiding this comment

RogerRiggs left a comment

Choose a reason for hiding this comment

openjdk bot commented May 17, 2021 • edited Loading

JoeWang-Java commented May 26, 2021

openjdk bot commented May 26, 2021

JoeWang-Java commented Apr 23, 2021 •

edited by openjdk bot

Loading

mlbridge bot commented Apr 23, 2021 •

edited

Loading

openjdk bot commented May 17, 2021 •

edited

Loading