8265816: Handle new VectorMaskCast node for x86

[sviswa7]

To eliminate unnecessary vector mask conversion during unboxing a
VectorMaskCast node was added as part of JDK-8264104 for aarch64. This patch handles the x86 side of it.

Please review.

Best Regards,
Sandhya

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8265816: Handle new VectorMaskCast node for x86

Reviewers

• Vladimir Ivanov (@iwanowww - Reviewer)
• Nils Eliasson (@neliasso - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3645/head:pull/3645
$ git checkout pull/3645

Update a local copy of the PR:
$ git checkout pull/3645
$ git pull https://git.openjdk.java.net/jdk pull/3645/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3645

View PR using the GUI difftool:
$ git pr show -t 3645

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3645.diff

[bridgekeeper]

👋 Welcome back sviswanathan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sviswa7 The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (7250543d)

[DamonFool]

Is there a small program which can be used to verify the effect of this opt?
I just want to learn how this kind of opt works, not to require a jtreg test.
Thanks.

[iwanowww]

Looks good.

[openjdk]

@sviswa7 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265816: Handle new VectorMaskCast node for x86

Reviewed-by: vlivanov, neliasso

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• bebfae4: 8264208: Console charset API
• 5aab160: 8265531: doc/building.md should mention homebrew install freetype
• d8e638f: 8265794: Remove ProblemList-non-cds-mode
• ac23870: 8265831: 8257831 broke Windows x86 build
• 8e31229: 8265327: Remove check_safepoint_and_suspend_for_native_trans()
• c9b70c8: 8265240: runtime/Thread/SuspendAtExit.java needs updating
• 891f72f: 8265606: Reduce allocations in AdapterHandlerLibrary::get_adapter
• bfc1cd8: 8264320: ShouldNotReachHere in Compile::print_inlining_move_to()
• 5db64c3: 8265268: Unify ReservedSpace reservation code in initialize and try_reserve_heap
• 191f1fc: 8265759: Shenandoah: Avoid race for referent in assert
• ... and 11 more: https://git.openjdk.java.net/jdk/compare/f834557ae0ddc5a0c54aeec952c0b3391d70c3ac...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[sviswa7]

@DamonFool I see this case come up for the existing Vector API jtreg tests e.g. Float256VectorTests.EQFloat256VectorTestsMasked.

[sviswa7]

@iwanowww Thanks a lot for the review.

[neliasso]

Looks good!

[sviswa7]

@neliasso Thanks a lot for the review.

[sviswa7]

/integrate

[openjdk]

@sviswa7 Since your change was applied there have been 21 commits pushed to the master branch:

• bebfae4: 8264208: Console charset API
• 5aab160: 8265531: doc/building.md should mention homebrew install freetype
• d8e638f: 8265794: Remove ProblemList-non-cds-mode
• ac23870: 8265831: 8257831 broke Windows x86 build
• 8e31229: 8265327: Remove check_safepoint_and_suspend_for_native_trans()
• c9b70c8: 8265240: runtime/Thread/SuspendAtExit.java needs updating
• 891f72f: 8265606: Reduce allocations in AdapterHandlerLibrary::get_adapter
• bfc1cd8: 8264320: ShouldNotReachHere in Compile::print_inlining_move_to()
• 5db64c3: 8265268: Unify ReservedSpace reservation code in initialize and try_reserve_heap
• 191f1fc: 8265759: Shenandoah: Avoid race for referent in assert
• ... and 11 more: https://git.openjdk.java.net/jdk/compare/f834557ae0ddc5a0c54aeec952c0b3391d70c3ac...master

Your commit was automatically rebased without conflicts.

Pushed as commit e08f506.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[DamonFool]

@DamonFool I see this case come up for the existing Vector API jtreg tests e.g. Float256VectorTests.EQFloat256VectorTestsMasked.

Thanks for your kind reply.