Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265816: Handle new VectorMaskCast node for x86 #3645

Closed
wants to merge 1 commit into from

Conversation

@sviswa7
Copy link

@sviswa7 sviswa7 commented Apr 23, 2021

To eliminate unnecessary vector mask conversion during unboxing a
VectorMaskCast node was added as part of JDK-8264104 for aarch64. This patch handles the x86 side of it.

Please review.

Best Regards,
Sandhya


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3645/head:pull/3645
$ git checkout pull/3645

Update a local copy of the PR:
$ git checkout pull/3645
$ git pull https://git.openjdk.java.net/jdk pull/3645/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3645

View PR using the GUI difftool:
$ git pr show -t 3645

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3645.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 23, 2021

👋 Welcome back sviswanathan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 23, 2021

@sviswa7 The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@sviswa7 sviswa7 marked this pull request as ready for review Apr 23, 2021
@openjdk openjdk bot added the rfr label Apr 23, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 23, 2021

Webrevs

Loading

@DamonFool
Copy link
Member

@DamonFool DamonFool commented Apr 23, 2021

Is there a small program which can be used to verify the effect of this opt?
I just want to learn how this kind of opt works, not to require a jtreg test.
Thanks.

Loading

Copy link

@iwanowww iwanowww left a comment

Looks good.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 23, 2021

@sviswa7 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265816: Handle new VectorMaskCast node for x86

Reviewed-by: vlivanov, neliasso

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Apr 23, 2021
@sviswa7
Copy link
Author

@sviswa7 sviswa7 commented Apr 23, 2021

@DamonFool I see this case come up for the existing Vector API jtreg tests e.g. Float256VectorTests.EQFloat256VectorTestsMasked.

Loading

@sviswa7
Copy link
Author

@sviswa7 sviswa7 commented Apr 23, 2021

@iwanowww Thanks a lot for the review.

Loading

Copy link
Contributor

@neliasso neliasso left a comment

Looks good!

Loading

@sviswa7
Copy link
Author

@sviswa7 sviswa7 commented Apr 23, 2021

@neliasso Thanks a lot for the review.

Loading

@sviswa7
Copy link
Author

@sviswa7 sviswa7 commented Apr 23, 2021

/integrate

Loading

@openjdk openjdk bot closed this Apr 23, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 23, 2021

@sviswa7 Since your change was applied there have been 21 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit e08f506.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@DamonFool
Copy link
Member

@DamonFool DamonFool commented Apr 24, 2021

@DamonFool I see this case come up for the existing Vector API jtreg tests e.g. Float256VectorTests.EQFloat256VectorTestsMasked.

Thanks for your kind reply.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants