Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253548: jvmFlagAccess.cpp: clang 9.0.0 format specifier error #365

Closed

Conversation

@iklam
Copy link
Member

@iklam iklam commented Sep 25, 2020

Please review this trivial fix for older clang compiler printf format warning. As mentioned on JDK-8253548, these's an existing typecast in logFileOutput.cpp for the same reason that SIZE_MAX is not actually of the size_t type for older clang compilers.

Testing with mach5 tier1.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253548: jvmFlagAccess.cpp: clang 9.0.0 format specifier error

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/365/head:pull/365
$ git checkout pull/365

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 25, 2020

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2020

@iklam The following label will be automatically applied to this pull request: hotspot-runtime.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

Loading

@iklam iklam marked this pull request as ready for review Sep 25, 2020
@openjdk openjdk bot added the rfr label Sep 25, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 25, 2020

Webrevs

Loading

Copy link
Member

@lfoltan lfoltan left a comment

Looks good & trivial.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2020

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253548: jvmFlagAccess.cpp: clang 9.0.0 format specifier error

Reviewed-by: lfoltan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • ec9bee6: 8253015: Aarch64: Move linux code out from generic CPU feature detection
  • 16b8c39: 8253053: Javadoc clean up in Authenticator and BasicAuthenicator
  • 840aa2b: 8253424: Add support for running pre-submit testing using GitHub Actions
  • 8e87d46: 8252857: AArch64: Shenandoah C1 CAS is not sequentially consistent
  • c2692f8: 8225329: -XX:+PrintBiasedLockingStatistics causes crash during initia…
  • e9c1782: 8252752: Clear card table for old regions during scan in G1
  • 276fcee: 8252835: Revert fix for JDK-8246051
  • ca1ed16: 8253639: Change os::attempt_reserve_memory_at parameter order
  • fed3636: 8252219: C2: Randomize IGVN worklist for stress testing
  • 625a935: 8253638: Cleanup os::reserve_memory and remove MAP_FIXED
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/0187567704d79ecf394d4cb656d0ba4c886351f1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 28, 2020
@iklam
Copy link
Member Author

@iklam iklam commented Sep 29, 2020

/integrate

Loading

@openjdk openjdk bot closed this Sep 29, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 29, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2020

@iklam Since your change was applied there have been 42 commits pushed to the master branch:

  • ff6843c: 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
  • d5be829: 8253770: Test tools/javac/parser/JavacParserTest.java fails on Windows after JDK-8253584
  • 6e5d4f3: 8253607: [mlvm] meth/func/jdi/breakpointOtherStratum: un-problemlist and add randomness keyword
  • 3ed960e: 8253640: Make MEMFLAGS an enum class
  • 86491a5: 8253584: Redunant errors for partial member selects
  • ebf443a: 8253590: java/foreign tests are still failing on x86_32 after foreign-memaccess integration
  • 431338b: 8212107: VMThread issues and cleanup
  • 6bddeb7: 8238761: Asynchronous handshakes
  • 6d19fe6: 8253763: ParallelObjectIterator should have virtual destructor
  • 55c90a1: 6514600: AbstractAction can throw NullPointerException when clone()d
  • ... and 32 more: https://git.openjdk.java.net/jdk/compare/0187567704d79ecf394d4cb656d0ba4c886351f1...master

Your commit was automatically rebased without conflicts.

Pushed as commit b1ce6bd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants