Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264317: Lanai: IncorrectUnmanagedImageRotatedClip.java fails on apple M1 #3651

Closed
wants to merge 1 commit into from

Conversation

@avu
Copy link

@avu avu commented Apr 23, 2021

Explicitly set storeAction in clear pass for stencil texture


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264317: Lanai: IncorrectUnmanagedImageRotatedClip.java fails on apple M1

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3651/head:pull/3651
$ git checkout pull/3651

Update a local copy of the PR:
$ git checkout pull/3651
$ git pull https://git.openjdk.java.net/jdk pull/3651/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3651

View PR using the GUI difftool:
$ git pr show -t 3651

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3651.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 23, 2021

👋 Welcome back avu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 23, 2021

@avu The following label will be automatically applied to this pull request:

  • 2d

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the 2d label Apr 23, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 23, 2021

Webrevs

@mrserb
Copy link
Member

@mrserb mrserb commented Apr 23, 2021

Please add this bugid to the test.

…e M1

Explicitly set storeAction in clear pass for stencil texture
@avu
Copy link
Author

@avu avu commented Apr 23, 2021

Please add this bugid to the test.

Done

mrserb
mrserb approved these changes Apr 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 23, 2021

@avu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264317: Lanai: IncorrectUnmanagedImageRotatedClip.java fails on apple M1

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • 4b7f027: 8231179: Investigate why tools/javac/options/BCPOrSystemNotSpecified.java fails on Window
  • d87a4c3: 8239596: PARAMETER annotation on receiver type does not cause error
  • 52f9d22: 8265884: ProblemList compiler/codecache/jmx/PoolsIndependenceTest.java on macOS-X64
  • 5aed446: 8265403: consolidate definition of CPU features
  • 20a373a: 8265393: VM crashes if both -XX:+RecordDynamicDumpInfo and -XX:SharedArchiveFile options are specified
  • 6803ab2: 8265880: ProblemList serviceability/dcmd/gc/RunFinalizationTest.java on Linux-X64
  • e08f506: 8265816: Handle new VectorMaskCast node for x86
  • bebfae4: 8264208: Console charset API
  • 5aab160: 8265531: doc/building.md should mention homebrew install freetype
  • d8e638f: 8265794: Remove ProblemList-non-cds-mode
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/191f1fc46c30f7e92ba09d04bc000256442e64ed...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Apr 23, 2021
@avu
Copy link
Author

@avu avu commented Apr 24, 2021

/integrate

@openjdk openjdk bot added the sponsor label Apr 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 24, 2021

@avu
Your change (at version bf56928) is now ready to be sponsored by a Committer.

@mrserb
Copy link
Member

@mrserb mrserb commented Apr 25, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Apr 25, 2021

@mrserb @avu Since your change was applied there have been 19 commits pushed to the master branch:

  • f1f2afd: 8264028: Typo in javax.management.relation.RelationService::purgeRelations
  • f6e22d1: 8265890: ProblemList sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java on macOS-X64 and Linux-aarch64
  • 0257ac1: 8252089: Remove psParallelCompact internal debug counters
  • 4b7f027: 8231179: Investigate why tools/javac/options/BCPOrSystemNotSpecified.java fails on Window
  • d87a4c3: 8239596: PARAMETER annotation on receiver type does not cause error
  • 52f9d22: 8265884: ProblemList compiler/codecache/jmx/PoolsIndependenceTest.java on macOS-X64
  • 5aed446: 8265403: consolidate definition of CPU features
  • 20a373a: 8265393: VM crashes if both -XX:+RecordDynamicDumpInfo and -XX:SharedArchiveFile options are specified
  • 6803ab2: 8265880: ProblemList serviceability/dcmd/gc/RunFinalizationTest.java on Linux-X64
  • e08f506: 8265816: Handle new VectorMaskCast node for x86
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/191f1fc46c30f7e92ba09d04bc000256442e64ed...master

Your commit was automatically rebased without conflicts.

Pushed as commit 3bf4c90.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants