New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8265587: IGV: track nodes across matching #3654
Conversation
|
@robcasloz The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a nice enhancement, looks good to me!
@robcasloz This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 94 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
Thanks for reviewing, Tobias! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thanks Vladimir! |
/summary |
@robcasloz Setting summary to:
|
/integrate |
@robcasloz Since your change was applied there have been 94 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit e879f8c. |
This change preserves, as much as possible, the IGV node identifier of Ideal nodes in their corresponding machine nodes created by
Matcher::match()
. This makes it possible to track nodes when stepping from "Before matching" to "After matching" in IGV, as illustrated for an extracted compare-and-branch subgraph in the following screenshot:Limitations
This solution preserves most of the node relations across matching, however if an Ideal node is expanded into multiple machine nodes, only one of them is assigned the IGV identifier of the Ideal node (since IGV identifiers need to be unique within a compilation phase). This limitation can be seen in the following example, where the
CmpU
Ideal node is implemented with threecompU_rReg
machine nodes (one for eachjmpConU
machine node), but only one of thecompU_rReg
machine nodes (50) preserves the IGV identifier:Overcoming this limitation would require explicitly serializing the entire before-after relation among nodes and adapting IGV's node selection and graph difference logic, which seems too complex for a relatively infrequent case.
Testing
java -Xcomp -XX:-TieredCompilation -XX:PrintIdealGraphLevel=4 ...
on an instrumented IGV. Loading and scheduling are useful graph well-formedness tests, as they tend to fail for incorrect graphs, e.g. with repeated node identifiers.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3654/head:pull/3654
$ git checkout pull/3654
Update a local copy of the PR:
$ git checkout pull/3654
$ git pull https://git.openjdk.java.net/jdk pull/3654/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3654
View PR using the GUI difftool:
$ git pr show -t 3654
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3654.diff