JDK-8265613: False positives for "Related Packages"

[hns]

The suggested simple fix to only include sibling packages if there is a common non-empty super package seems to work quite well. I have compiled a list to show the change in related packages listings generated for the JDK documentation (old output on the left, new output on the right).

https://gist.github.com/hns/d0f946255a69027405836201b047965d/revisions?diff=split

I updated the test to include an unlisted sibling package.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8265613: False positives for "Related Packages"

Reviewers

• Jonathan Gibbons (@jonathan-gibbons - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3655/head:pull/3655
$ git checkout pull/3655

Update a local copy of the PR:
$ git checkout pull/3655
$ git pull https://git.openjdk.java.net/jdk pull/3655/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3655

View PR using the GUI difftool:
$ git pr show -t 3655

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3655.diff

[bridgekeeper]

👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@hns The following label will be automatically applied to this pull request:

• javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0e77d5f9)

[jonathan-gibbons]

I note that com.sun.source.* now falls off the list :-( but that's probably better less bad than what we had before.

[openjdk]

@hns This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265613: False positives for "Related Packages"

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• 4b7f027: 8231179: Investigate why tools/javac/options/BCPOrSystemNotSpecified.java fails on Window
• d87a4c3: 8239596: PARAMETER annotation on receiver type does not cause error
• 52f9d22: 8265884: ProblemList compiler/codecache/jmx/PoolsIndependenceTest.java on macOS-X64
• 5aed446: 8265403: consolidate definition of CPU features
• 20a373a: 8265393: VM crashes if both -XX:+RecordDynamicDumpInfo and -XX:SharedArchiveFile options are specified
• 6803ab2: 8265880: ProblemList serviceability/dcmd/gc/RunFinalizationTest.java on Linux-X64
• e08f506: 8265816: Handle new VectorMaskCast node for x86
• bebfae4: 8264208: Console charset API
• 5aab160: 8265531: doc/building.md should mention homebrew install freetype
• d8e638f: 8265794: Remove ProblemList-non-cds-mode
• ... and 6 more: https://git.openjdk.java.net/jdk/compare/191f1fc46c30f7e92ba09d04bc000256442e64ed...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[hns]

/integrate

[openjdk]

@hns Since your change was applied there have been 24 commits pushed to the master branch:

• 6e5026a: 8198621: java/awt/Focus/KeyEventForBadFocusOwnerTest/KeyEventForBadFocusOwnerTest.java fails on mac
• 7b609a2: 8264031: (zipfs) Typo in ZipFileSystem.deleteFile ZipException
• 56fbef0: 8265681: G1: general cleanup for G1FullGCHeapRegionAttr
• 578a0b3: 8261238: NMT should not limit baselining by size threshold
• 3bf4c90: 8264317: Lanai: IncorrectUnmanagedImageRotatedClip.java fails on apple M1
• f1f2afd: 8264028: Typo in javax.management.relation.RelationService::purgeRelations
• f6e22d1: 8265890: ProblemList sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java on macOS-X64 and Linux-aarch64
• 0257ac1: 8252089: Remove psParallelCompact internal debug counters
• 4b7f027: 8231179: Investigate why tools/javac/options/BCPOrSystemNotSpecified.java fails on Window
• d87a4c3: 8239596: PARAMETER annotation on receiver type does not cause error
• ... and 14 more: https://git.openjdk.java.net/jdk/compare/191f1fc46c30f7e92ba09d04bc000256442e64ed...master

Your commit was automatically rebased without conflicts.

Pushed as commit a85f6cb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.