Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258625: [JVMCI] refactor and unify JVMCI readFieldValue path #3659

Closed

Conversation

@tkrodriguez
Copy link
Contributor

@tkrodriguez tkrodriguez commented Apr 23, 2021

This was originally just a cleanup but it turned out to be a partial safety fix for folding reads during compilation. I've rolled in a couple other safety checks that were found along the way, along with jtreg test improvements that exercise the new paths.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258625: [JVMCI] refactor and unify JVMCI readFieldValue path

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3659/head:pull/3659
$ git checkout pull/3659

Update a local copy of the PR:
$ git checkout pull/3659
$ git pull https://git.openjdk.java.net/jdk pull/3659/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3659

View PR using the GUI difftool:
$ git pr show -t 3659

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3659.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 23, 2021

👋 Welcome back never! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Apr 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 23, 2021

@tkrodriguez The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 23, 2021

Webrevs

Loading

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Seems good.
Doug should review it too.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 26, 2021

@tkrodriguez This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258625: [JVMCI] refactor and unify JVMCI readFieldValue path

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

  • 851b219: 8265901: Use pattern matching for instanceof at module jdk.compiler(part 3)
  • fb8f0c5: 8261168: Convert javadoc tool to use Stream.toList()
  • 8559a53: 8265394: G1: Improve assert in HeapRegion::reset_not_compacted_after_full_gc
  • 68011c6: 8265928: G1: Update copyright in several files
  • 222f9f0: 8265682: G1: Mutex::_name dangling in HeapRegionRemSet references after JDK-8264146
  • 2b09ff2: 8232765: NullPointerException at Types.eraseNotNeeded() when compiling a class
  • b9f66d9: 8264188: Improve handling of assembly files in the JDK
  • c3ac690: 8261759: ZGC: ZWorker Threads Continue Marking After System.exit() called
  • 31abe68: 8265116: ZGC: Steal local stacks instead of flushing them
  • 83364a4: 8264258: Unknown lookups in the java package give misleading compilation errors
  • ... and 25 more: https://git.openjdk.java.net/jdk/compare/8e312297d806f581c7a069af6c2ee2d8381b46b6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Apr 26, 2021
@dougxc
Copy link
Member

@dougxc dougxc commented Apr 26, 2021

LGTM.

Loading

@tkrodriguez
Copy link
Contributor Author

@tkrodriguez tkrodriguez commented Apr 26, 2021

/integrate

Loading

@openjdk openjdk bot closed this Apr 26, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 26, 2021

@tkrodriguez Since your change was applied there have been 40 commits pushed to the master branch:

  • b5c6351: 8264663: Update test SuspendWithCurrentThread.java to verify that suspend doesn't exit until resumed
  • b524a81: 8265982: JDK-8264188 breaks build on macOS-aarch64
  • efe6b93: 8265961: Fix comments in logging.properties
  • 65c19c4: 4926314: Optimize Reader.read(CharBuffer)
  • 082abbd: 8265900: Use pattern matching for instanceof at module jdk.compiler(part 2)
  • 851b219: 8265901: Use pattern matching for instanceof at module jdk.compiler(part 3)
  • fb8f0c5: 8261168: Convert javadoc tool to use Stream.toList()
  • 8559a53: 8265394: G1: Improve assert in HeapRegion::reset_not_compacted_after_full_gc
  • 68011c6: 8265928: G1: Update copyright in several files
  • 222f9f0: 8265682: G1: Mutex::_name dangling in HeapRegionRemSet references after JDK-8264146
  • ... and 30 more: https://git.openjdk.java.net/jdk/compare/8e312297d806f581c7a069af6c2ee2d8381b46b6...master

Your commit was automatically rebased without conflicts.

Pushed as commit 852a41d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants