Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253637: Update EC removal #366

Closed
wants to merge 8 commits into from
Closed

8253637: Update EC removal #366

wants to merge 8 commits into from

Conversation

@ascarpino
Copy link
Contributor

@ascarpino ascarpino commented Sep 25, 2020

Hi,

I need a quick review for two changes. The primary is a failure that shows up on linux-aarch64 because the systems do not have NSS. The default was to allow all curves tested, which before the native library removal was ok. The second was a missed changeset that got left in the local repo that helped find the curve name on an exception message.

Thanks

Tony


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/366/head:pull/366
$ git checkout pull/366

@ascarpino ascarpino changed the title 8253637: Update EC removal {RFR] 8253637: Update EC removal Sep 25, 2020
@ascarpino ascarpino changed the title {RFR] 8253637: Update EC removal [RFR] 8253637: Update EC removal Sep 25, 2020
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 25, 2020

👋 Welcome back ascarpino! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2020

@ascarpino The following label will be automatically applied to this pull request: security.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the security label Sep 25, 2020
@ascarpino ascarpino changed the title [RFR] 8253637: Update EC removal 8253637: Update EC removal Sep 25, 2020
@ascarpino ascarpino marked this pull request as ready for review Sep 25, 2020
@openjdk openjdk bot added the rfr label Sep 25, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 25, 2020

Webrevs

bridgekeeper[bot]
Copy link

bridgekeeper bot commented on 9150b90 Sep 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bridgekeeper[bot]
Copy link

bridgekeeper bot commented on 0e855fe Sep 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2020

⚠️ @ascarpino This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Sep 25, 2020

@ascarpino - Thanks for removing the ProblemList entry that I added
with JDK-8253659. I did check the status of your bug (JDK-8253637)
but apparently I did that just before you started working on it today
(about 1400 ET was the last time I checked it).

My apologies.

@ascarpino
Copy link
Contributor Author

@ascarpino ascarpino commented Sep 25, 2020

@dcubed-ojdk That's ok. I had been working on it all morning (PT). If I realized you were looking at the bug status I would have changed it right away. Though given my PR has been sitting for a while, maybe on the list was for the best.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2020

@ascarpino This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253637: Update EC removal

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

  • b1ce6bd: 8253548: jvmFlagAccess.cpp: clang 9.0.0 format specifier error
  • ff6843c: 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
  • d5be829: 8253770: Test tools/javac/parser/JavacParserTest.java fails on Windows after JDK-8253584
  • 6e5d4f3: 8253607: [mlvm] meth/func/jdi/breakpointOtherStratum: un-problemlist and add randomness keyword
  • 3ed960e: 8253640: Make MEMFLAGS an enum class
  • 86491a5: 8253584: Redunant errors for partial member selects
  • ebf443a: 8253590: java/foreign tests are still failing on x86_32 after foreign-memaccess integration
  • 431338b: 8212107: VMThread issues and cleanup
  • 6bddeb7: 8238761: Asynchronous handshakes
  • 6d19fe6: 8253763: ParallelObjectIterator should have virtual destructor
  • ... and 31 more: https://git.openjdk.java.net/jdk/compare/0e855fe5fac8a9ade3da4b1eeda4111966f39f16...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 29, 2020
@ascarpino
Copy link
Contributor Author

@ascarpino ascarpino commented Sep 29, 2020

/integrate

@openjdk openjdk bot closed this Sep 29, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 29, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2020

@ascarpino Since your change was applied there have been 41 commits pushed to the master branch:

  • b1ce6bd: 8253548: jvmFlagAccess.cpp: clang 9.0.0 format specifier error
  • ff6843c: 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
  • d5be829: 8253770: Test tools/javac/parser/JavacParserTest.java fails on Windows after JDK-8253584
  • 6e5d4f3: 8253607: [mlvm] meth/func/jdi/breakpointOtherStratum: un-problemlist and add randomness keyword
  • 3ed960e: 8253640: Make MEMFLAGS an enum class
  • 86491a5: 8253584: Redunant errors for partial member selects
  • ebf443a: 8253590: java/foreign tests are still failing on x86_32 after foreign-memaccess integration
  • 431338b: 8212107: VMThread issues and cleanup
  • 6bddeb7: 8238761: Asynchronous handshakes
  • 6d19fe6: 8253763: ParallelObjectIterator should have virtual destructor
  • ... and 31 more: https://git.openjdk.java.net/jdk/compare/0e855fe5fac8a9ade3da4b1eeda4111966f39f16...master

Your commit was automatically rebased without conflicts.

Pushed as commit fb20690.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@ascarpino ascarpino deleted the ecfix branch Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants