New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8253637: Update EC removal #366
Conversation
👋 Welcome back ascarpino! A progress list of the required criteria for merging this PR into |
@ascarpino The following label will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the |
Webrevs
|
Reviewed-by: iklam
Reviewed-by: weijun
|
@ascarpino - Thanks for removing the ProblemList entry that I added My apologies. |
@dcubed-ojdk That's ok. I had been working on it all morning (PT). If I realized you were looking at the bug status I would have changed it right away. Though given my PR has been sitting for a while, maybe on the list was for the best. |
@ascarpino This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 41 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@ascarpino Since your change was applied there have been 41 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit fb20690. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi,
I need a quick review for two changes. The primary is a failure that shows up on linux-aarch64 because the systems do not have NSS. The default was to allow all curves tested, which before the native library removal was ok. The second was a missed changeset that got left in the local repo that helped find the curve name on an exception message.
Thanks
Tony
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/366/head:pull/366
$ git checkout pull/366