Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264663: Update test SuspendWithCurrentThread.java to verify that suspend doesn't exit until resumed #3665

Closed
wants to merge 1 commit into from

Conversation

lmesnik
Copy link
Member

@lmesnik lmesnik commented Apr 23, 2021

Test test/hotspot/jtreg/serviceability/jvmti/SuspendWithCurrentThread/SuspendWithCurrentThread.java
doesn't check that thread stops in SuspendThreadList(...).

Actually, before https://bugs.openjdk.java.net/browse/JDK-8257831 the thread didn't suspend itself but only get a request to be suspended. So it continued to execute and stopped a little bit later.

Such behavior is a violation of spec which says " If the calling thread is specified in the request_list array, this function will not return until some other thread resumes it."

While the bug is fixed it is still useful to verify correct behavior. If the fix is backported without JDK-8257831 test should start failing.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264663: Update test SuspendWithCurrentThread.java to verify that suspend doesn't exit until resumed

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3665/head:pull/3665
$ git checkout pull/3665

Update a local copy of the PR:
$ git checkout pull/3665
$ git pull https://git.openjdk.java.net/jdk pull/3665/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3665

View PR using the GUI difftool:
$ git pr show -t 3665

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3665.diff

…WithCurrentThread.java to verify that suspend don't exit until resumed
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 23, 2021

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 23, 2021

@lmesnik The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability label Apr 23, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 23, 2021

Webrevs

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Thumbs up.

I'm good with the changes. I just a question about the use
of std::atomic.

#include "jvmti.h"

extern "C" {

static jvmtiEnv* jvmti = NULL;
static jthread* threads = NULL;
static jsize threads_count = 0;
static std::atomic<bool> is_exited_from_suspend;
Copy link
Member

@dcubed-ojdk dcubed-ojdk Apr 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is use of std::atomic permitted in tests?

Copy link
Contributor

@sspitsyn sspitsyn Apr 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never seen any such restrictions in our development guidelines.
In general, there are cases where using atomic vs raw monitors is desirable to avoid over sync in tests when there is a need to stress multi-threading.

Copy link
Member Author

@lmesnik lmesnik Apr 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know anything about such restrictions also. The atomics are required in this test because the thread actually managed to process the suspend request during RawMonitorEnter if it is used and just suspend right before entering the critical section. So RawMonitorEnter/RawMonitorExitt might not show the problem. Also, as Serguei mentioned atomics synchronization might help us in stress tests.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 23, 2021

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264663: Update test SuspendWithCurrentThread.java to verify that suspend doesn't exit until resumed

Reviewed-by: dcubed, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 20a373a: 8265393: VM crashes if both -XX:+RecordDynamicDumpInfo and -XX:SharedArchiveFile options are specified
  • 6803ab2: 8265880: ProblemList serviceability/dcmd/gc/RunFinalizationTest.java on Linux-X64

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 23, 2021
Copy link
Contributor

@sspitsyn sspitsyn left a comment

Hi Leonid,

It looks good to me.
I just wonder if it works on all platforms including Windows.

Thanks,
serguei

@lmesnik
Copy link
Member Author

@lmesnik lmesnik commented Apr 24, 2021

Dan, Serguei. Thank you for review. I've verified that test build and passed on linux/win/mac x64 and linux-aarch64.

@lmesnik
Copy link
Member Author

@lmesnik lmesnik commented Apr 26, 2021

/integrate

@openjdk openjdk bot closed this Apr 26, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 26, 2021

@lmesnik Since your change was applied there have been 34 commits pushed to the master branch:

  • b524a81: 8265982: JDK-8264188 breaks build on macOS-aarch64
  • efe6b93: 8265961: Fix comments in logging.properties
  • 65c19c4: 4926314: Optimize Reader.read(CharBuffer)
  • 082abbd: 8265900: Use pattern matching for instanceof at module jdk.compiler(part 2)
  • 851b219: 8265901: Use pattern matching for instanceof at module jdk.compiler(part 3)
  • fb8f0c5: 8261168: Convert javadoc tool to use Stream.toList()
  • 8559a53: 8265394: G1: Improve assert in HeapRegion::reset_not_compacted_after_full_gc
  • 68011c6: 8265928: G1: Update copyright in several files
  • 222f9f0: 8265682: G1: Mutex::_name dangling in HeapRegionRemSet references after JDK-8264146
  • 2b09ff2: 8232765: NullPointerException at Types.eraseNotNeeded() when compiling a class
  • ... and 24 more: https://git.openjdk.java.net/jdk/compare/e08f506fa7fabb2d2d4bfe16d4e01397b4d9ac5a...master

Your commit was automatically rebased without conflicts.

Pushed as commit b5c6351.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@lmesnik lmesnik deleted the 8264663 branch Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated serviceability
3 participants