Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265884: ProblemList compiler/codecache/jmx/PoolsIndependenceTest.java on macOS-X64 #3667

Closed
wants to merge 2 commits into from

Conversation

@dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Apr 23, 2021

A trivial fix to ProblemList compiler/codecache/jmx/PoolsIndependenceTest.java on macOS-X64.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265884: ProblemList compiler/codecache/jmx/PoolsIndependenceTest.java on macOS-X64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3667/head:pull/3667
$ git checkout pull/3667

Update a local copy of the PR:
$ git checkout pull/3667
$ git pull https://git.openjdk.java.net/jdk pull/3667/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3667

View PR using the GUI difftool:
$ git pr show -t 3667

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3667.diff

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Apr 23, 2021

/label add hotspot-runtime
/label add hotspot-compiler

Loading

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Apr 23, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 23, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 23, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 23, 2021

@dcubed-ojdk
The hotspot-compiler label was successfully added.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 23, 2021

Webrevs

Loading

@@ -68,6 +68,8 @@ compiler/whitebox/ClearMethodStateTest.java 8265360 macosx-aarch64
compiler/whitebox/EnqueueMethodForCompilationTest.java 8265360 macosx-aarch64
compiler/whitebox/MakeMethodNotCompilableTest.java 8265360 macosx-aarch64

compiler/codecache/jmx/PoolsIndependenceTest.java 8264632 macos-x64
Copy link
Contributor

@vidmik vidmik Apr 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing an 'x' - macosx-x64

Loading

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Apr 23, 2021

@vidmik - Thanks for catching the typo. Fixed.

Loading

vidmik
vidmik approved these changes Apr 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 24, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265884: ProblemList compiler/codecache/jmx/PoolsIndependenceTest.java on macOS-X64

Reviewed-by: mikael

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 5aed446: 8265403: consolidate definition of CPU features
  • 20a373a: 8265393: VM crashes if both -XX:+RecordDynamicDumpInfo and -XX:SharedArchiveFile options are specified
  • 6803ab2: 8265880: ProblemList serviceability/dcmd/gc/RunFinalizationTest.java on Linux-X64
  • e08f506: 8265816: Handle new VectorMaskCast node for x86

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Apr 24, 2021
@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Apr 24, 2021

@vidmik - Thanks for the re-review!

/integrate

Loading

@openjdk openjdk bot closed this Apr 24, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 24, 2021

@dcubed-ojdk Since your change was applied there have been 4 commits pushed to the master branch:

  • 5aed446: 8265403: consolidate definition of CPU features
  • 20a373a: 8265393: VM crashes if both -XX:+RecordDynamicDumpInfo and -XX:SharedArchiveFile options are specified
  • 6803ab2: 8265880: ProblemList serviceability/dcmd/gc/RunFinalizationTest.java on Linux-X64
  • e08f506: 8265816: Handle new VectorMaskCast node for x86

Your commit was automatically rebased without conflicts.

Pushed as commit 52f9d22.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@dcubed-ojdk dcubed-ojdk deleted the JDK-8265884 branch Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants