Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265890: ProblemList sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java on macOS-X64 and Linux-aarch64 #3668

Closed
wants to merge 2 commits into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Apr 24, 2021

A trivial fix to ProblemList sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java
on macOS-X64 and Linux-aarch64. It is already ProblemListed on linux-x64.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265890: ProblemList sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java on macOS-X64 and Linux-aarch64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3668/head:pull/3668
$ git checkout pull/3668

Update a local copy of the PR:
$ git checkout pull/3668
$ git pull https://git.openjdk.java.net/jdk pull/3668/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3668

View PR using the GUI difftool:
$ git pr show -t 3668

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3668.diff

…wsWrongExceptions.java on macOS-X64 and Linux-aarch64
@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Apr 24, 2021

/label add hotspot-runtime
/label add security

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Apr 24, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 24, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr hotspot-runtime labels Apr 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 24, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the security label Apr 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 24, 2021

@dcubed-ojdk
The security label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 24, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Apr 24, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265890: ProblemList sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java on macOS-X64 and Linux-aarch64

Reviewed-by: rriggs, xuelei

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 24, 2021
@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Apr 25, 2021

@RogerRiggs and @XueleiFan - Thanks for the reviews.

/integrate

@openjdk openjdk bot closed this Apr 25, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 25, 2021

@dcubed-ojdk Since your change was applied there has been 1 commit pushed to the master branch:

  • 0257ac1: 8252089: Remove psParallelCompact internal debug counters

Your commit was automatically rebased without conflicts.

Pushed as commit f6e22d1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8265890 branch Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated security
3 participants