Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8223347: Integration of Vector API (Incubator) #367

Closed
wants to merge 11 commits into from

Conversation

@PaulSandoz
Copy link
Member

@PaulSandoz PaulSandoz commented Sep 25, 2020

This pull request is for integration of the Vector API. It was previously reviewed under conditions when mercurial was used for the source code control system. Review threads can be found here (searching for issue number 8223347 in the title):

https://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2020-April/thread.html
https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-May/thread.html
https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-July/thread.html

If mercurial was still being used the code would be pushed directly, once the CSR is approved. However, in this case a pull request is required and needs explicit reviewer approval. Between the final review and this pull request no code has changed, except for that related to merging.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

Reviewers

Contributors

  • Vivek Deshpande <vdeshpande@openjdk.org>
  • Qi Feng <qfeng@openjdk.org>
  • Ian Graves <igraves@openjdk.org>
  • Jean-Philippe Halimi <jphalimi@openjdk.org>
  • Vladimir Ivanov <vlivanov@openjdk.org>
  • Ningsheng Jian <njian@openjdk.org>
  • Razvan Lupusoru <rlupusoru@openjdk.org>
  • Smita Kamath <svkamath@openjdk.org>
  • Rahul Kandu <rkandu@openjdk.org>
  • Kishor Kharbas <kkharbas@openjdk.org>
  • Eric Liu <Eric.Liu2@arm.com>
  • Aaloan Miftah <someusername3@gmail.com>
  • John R Rose <jrose@openjdk.org>
  • Shravya Rukmannagari <srukmannagar@openjdk.org>
  • Paul Sandoz <psandoz@openjdk.org>
  • Sandhya Viswanathan <sviswanathan@openjdk.org>
  • Lauren Walkowski <lauren.walkowski@arm.com>
  • Yang Zang <Yang.Zhang@arm.com>
  • Joshua Zhu <jzhu@openjdk.org>
  • Wang Zhuo <wzhuo@openjdk.org>
  • Jatin Bhateja <jbhateja@openjdk.org>

Download

$ git fetch https://git.openjdk.java.net/jdk pull/367/head:pull/367
$ git checkout pull/367

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 25, 2020

👋 Welcome back psandoz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2020

@PaulSandoz this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8223347
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2020

@PaulSandoz The following labels will be automatically applied to this pull request: build core-libs hotspot.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label (add|remove) "label" command.

@PaulSandoz
Copy link
Member Author

@PaulSandoz PaulSandoz commented Sep 25, 2020

/reviewer credit forax

@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2020

@PaulSandoz
Reviewer forax successfully credited.

@PaulSandoz
Copy link
Member Author

@PaulSandoz PaulSandoz commented Sep 25, 2020

/review credit briangoetz, aph, chegar, erikj, kvn, epavlova, coleenp

@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2020

@PaulSandoz Unknown command review - for a list of valid commands use /help.

@PaulSandoz
Copy link
Member Author

@PaulSandoz PaulSandoz commented Sep 25, 2020

/reviewer credit briangoetz, aph, chegar, erikj, kvn, epavlova, coleenp

@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2020

@PaulSandoz
Reviewer briangoetz successfully credited.

Reviewer aph successfully credited.

Reviewer chegar successfully credited.

Reviewer erikj successfully credited.

Reviewer kvn successfully credited.

Reviewer epavlova successfully credited.

Reviewer coleenp successfully credited.

@PaulSandoz
Copy link
Member Author

@PaulSandoz PaulSandoz commented Sep 25, 2020

/contributor add jbhateja
/contributor add vdeshpande
/contributor add qfeng
/contributor add igraves
/contributor add jphalimi
/contributor add vlivanov
/contributor add njian
/contributor add rlupusoru
/contributor add svkamath
/contributor add rkandu
/contributor add kkharbas
/contributor add Eric Liu Eric.Liu2@arm.com
/contributor add Aaloan Miftah someusername3@gmail.com
/contributor add jrose
/contributor add srukmannagar
/contributor add psandoz
/contributor add sviswanathan
/contributor add Lauren Walkowski lauren.walkowski@arm.com
/contributor add Yang Zang Yang.Zhang@arm.com
/contributor add jzhu
/contributor add wzhuo

@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2020

@PaulSandoz
Contributor Jatin Bhateja <jbhateja@openjdk.org> successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2020

@PaulSandoz
Contributor Vivek Deshpande <vdeshpande@openjdk.org> successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2020

@PaulSandoz
Contributor Qi Feng <qfeng@openjdk.org> successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2020

@PaulSandoz
Contributor Ian Graves <igraves@openjdk.org> successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2020

@PaulSandoz
Contributor Jean-Philippe Halimi <jphalimi@openjdk.org> successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2020

@PaulSandoz
Contributor Vladimir Ivanov <vlivanov@openjdk.org> successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2020

@PaulSandoz
Contributor Ningsheng Jian <njian@openjdk.org> successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2020

@PaulSandoz
Contributor Razvan Lupusoru <rlupusoru@openjdk.org> successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2020

@PaulSandoz
Contributor Smita Kamath <svkamath@openjdk.org> successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2020

@PaulSandoz
Contributor Rahul Kandu <rkandu@openjdk.org> successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2020

@PaulSandoz
Contributor Kishor Kharbas <kkharbas@openjdk.org> successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2020

@PaulSandoz
Contributor Eric Liu <Eric.Liu2@arm.com> successfully added.

@PaulSandoz
Copy link
Member Author

@PaulSandoz PaulSandoz commented Sep 25, 2020

/csr needed

@openjdk
Copy link

@openjdk openjdk bot commented Sep 27, 2020

@PaulSandoz
Contributor Aaloan Miftah <someusername3@gmail.com> successfully added.

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Good

@openjdk openjdk bot removed the csr label Oct 12, 2020
Copy link
Member

@erikj79 erikj79 left a comment

Build changes look good.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 12, 2020

@PaulSandoz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8223347: Integration of Vector API (Incubator)

Co-authored-by: Vivek Deshpande <vdeshpande@openjdk.org>
Co-authored-by: Qi Feng <qfeng@openjdk.org>
Co-authored-by: Ian Graves <igraves@openjdk.org>
Co-authored-by: Jean-Philippe Halimi <jphalimi@openjdk.org>
Co-authored-by: Vladimir Ivanov <vlivanov@openjdk.org>
Co-authored-by: Ningsheng Jian <njian@openjdk.org>
Co-authored-by: Razvan Lupusoru <rlupusoru@openjdk.org>
Co-authored-by: Smita Kamath <svkamath@openjdk.org>
Co-authored-by: Rahul Kandu <rkandu@openjdk.org>
Co-authored-by: Kishor Kharbas <kkharbas@openjdk.org>
Co-authored-by: Eric Liu <Eric.Liu2@arm.com>
Co-authored-by: Aaloan Miftah <someusername3@gmail.com>
Co-authored-by: John R Rose <jrose@openjdk.org>
Co-authored-by: Shravya Rukmannagari <srukmannagar@openjdk.org>
Co-authored-by: Paul Sandoz <psandoz@openjdk.org>
Co-authored-by: Sandhya Viswanathan <sviswanathan@openjdk.org>
Co-authored-by: Lauren Walkowski <lauren.walkowski@arm.com>
Co-authored-by: Yang Zang <Yang.Zhang@arm.com>
Co-authored-by: Joshua Zhu <jzhu@openjdk.org>
Co-authored-by: Wang Zhuo <wzhuo@openjdk.org>
Co-authored-by: Jatin Bhateja <jbhateja@openjdk.org>
Reviewed-by: erikj, chegar, kvn, darcy, forax, briangoetz, aph, epavlova, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 386e7e8: 8254789: ProblemList compiler/graalunit/HotspotTest.java
  • cd33abb: 8249623: test @Ignore-d due to 7013634 should be returned back to execution
  • b7daf84: 8254345: com/sun/jdi/JdwpAttachTest.java reports error incorrectly
  • fde02e2: 8254012: NMT: MetaspaceSnapshot::snapshot uses wrong enum

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready and removed merge-conflict labels Oct 12, 2020
@katyapav
Copy link
Member

@katyapav katyapav commented Oct 13, 2020

There are several gc tests crashed in panama-vector tier3 testing which seems are not observed in openjdk repo.
The crashes look like:

#  assert(oopDesc::is_oop(obj)) failed: not an oop: 0xfffffffffffffff1
#
# JRE version: Java(TM) SE Runtime Environment (16.0+3) (fastdebug build 16-panama+3-216)
# Java VM: Java HotSpot(TM) 64-Bit Server VM (fastdebug 16-panama+3-216, mixed mode, sharing, tiered, compressed oops, g1 gc, linux-amd64)
# Problematic frame:
# V  [libjvm.so+0xd8ef94]  HandleArea::allocate_handle(oop)+0x144

and the issue is actually tracked by JDK-8233199.

This issue needs to be at least analyzed before integrating Vector API.

@sviswa7
Copy link

@sviswa7 sviswa7 commented Oct 14, 2020

@katyapav Is the failure observed on vector-unstable branch of panama-vector?
The code in this pull request is from vector-unstable branch.
The bug report https://bugs.openjdk.java.net/browse/JDK-8233199 refers to repo-valhalla and not panama-vector:vector-unstable.
@PaulSandoz is doing final testing of the pull request today before integration tomorrow hopefully.

@katyapav
Copy link
Member

@katyapav katyapav commented Oct 14, 2020

@sviswa7 you are right, the failure is observed on vector-unstable branch of panama-vector.
I referred to JDK-8233199 because it seems both panama-vector and valhalla-repo have the same issue/crash.
@PaulSandoz also mentioned that panama-vector was not in sync with master and this is perhaps the issue is in vector-unstable. He said that he tested the PR separately and didn't observe this issue in the PR.

@openjdk openjdk bot added merge-conflict and removed ready labels Oct 14, 2020
@openjdk openjdk bot added ready and removed merge-conflict labels Oct 14, 2020
@PaulSandoz
Copy link
Member Author

@PaulSandoz PaulSandoz commented Oct 14, 2020

/integrate

@openjdk openjdk bot closed this Oct 14, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2020

@PaulSandoz Since your change was applied there have been 4 commits pushed to the master branch:

  • 386e7e8: 8254789: ProblemList compiler/graalunit/HotspotTest.java
  • cd33abb: 8249623: test @Ignore-d due to 7013634 should be returned back to execution
  • b7daf84: 8254345: com/sun/jdi/JdwpAttachTest.java reports error incorrectly
  • fde02e2: 8254012: NMT: MetaspaceSnapshot::snapshot uses wrong enum

Your commit was automatically rebased without conflicts.

Pushed as commit 0c99b19.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment