8223347: Integration of Vector API (Incubator) #367

PaulSandoz · 2020-09-25T20:14:29Z

This pull request is for integration of the Vector API. It was previously reviewed under conditions when mercurial was used for the source code control system. Review threads can be found here (searching for issue number 8223347 in the title):

https://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2020-April/thread.html
https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-May/thread.html
https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-July/thread.html

If mercurial was still being used the code would be pushed directly, once the CSR is approved. However, in this case a pull request is required and needs explicit reviewer approval. Between the final review and this pull request no code has changed, except for that related to merging.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Testing

	Linux x64	Windows x64	macOS x64
Build	✔️ (5/5 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)
Test (tier1)	✔️ (9/9 passed)	✔️ (9/9 passed)	✔️ (9/9 passed)

Issue

JDK-8223347: Integration of Vector API (Incubator)

Reviewers

Erik Joelsson (@erikj79 - Reviewer) ⚠️ Review applies to f2a45af
Chris Hegarty (@ChrisHegarty - Reviewer) ⚠️ Review applies to f2a45af
Vladimir Kozlov (@vnkozlov - Reviewer) ⚠️ Review applies to f2a45af
Joe Darcy (@jddarcy - Reviewer) ⚠️ Review applies to f2a45af
forax - no project role ⚠️ Added manually
briangoetz - Reviewer ⚠️ Added manually
aph - Reviewer ⚠️ Added manually
epavlova - Committer ⚠️ Added manually
coleenp - Reviewer ⚠️ Added manually

Contributors

Vivek Deshpande <vdeshpande@openjdk.org>
Qi Feng <qfeng@openjdk.org>
Ian Graves <igraves@openjdk.org>
Jean-Philippe Halimi <jphalimi@openjdk.org>
Vladimir Ivanov <vlivanov@openjdk.org>
Ningsheng Jian <njian@openjdk.org>
Razvan Lupusoru <rlupusoru@openjdk.org>
Smita Kamath <svkamath@openjdk.org>
Rahul Kandu <rkandu@openjdk.org>
Kishor Kharbas <kkharbas@openjdk.org>
Eric Liu <Eric.Liu2@arm.com>
Aaloan Miftah <someusername3@gmail.com>
John R Rose <jrose@openjdk.org>
Shravya Rukmannagari <srukmannagar@openjdk.org>
Paul Sandoz <psandoz@openjdk.org>
Sandhya Viswanathan <sviswanathan@openjdk.org>
Lauren Walkowski <lauren.walkowski@arm.com>
Yang Zang <Yang.Zhang@arm.com>
Joshua Zhu <jzhu@openjdk.org>
Wang Zhuo <wzhuo@openjdk.org>
Jatin Bhateja <jbhateja@openjdk.org>

Download

$ git fetch https://git.openjdk.java.net/jdk pull/367/head:pull/367
$ git checkout pull/367

bridgekeeper · 2020-09-25T20:15:53Z

👋 Welcome back psandoz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2020-09-25T20:17:15Z

@PaulSandoz this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8223347
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

openjdk · 2020-09-25T20:17:52Z

@PaulSandoz The following labels will be automatically applied to this pull request: build core-libs hotspot.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label (add|remove) "label" command.

PaulSandoz · 2020-09-25T20:21:29Z

/reviewer credit forax

openjdk · 2020-09-25T20:22:01Z

@PaulSandoz
Reviewer forax successfully credited.

PaulSandoz · 2020-09-25T20:24:43Z

/review credit briangoetz, aph, chegar, erikj, kvn, epavlova, coleenp

openjdk · 2020-09-25T20:25:35Z

@PaulSandoz Unknown command review - for a list of valid commands use /help.

PaulSandoz · 2020-09-25T20:26:17Z

/reviewer credit briangoetz, aph, chegar, erikj, kvn, epavlova, coleenp

openjdk · 2020-09-25T20:27:02Z

@PaulSandoz
Reviewer briangoetz successfully credited.

Reviewer aph successfully credited.

Reviewer chegar successfully credited.

Reviewer erikj successfully credited.

Reviewer kvn successfully credited.

Reviewer epavlova successfully credited.

Reviewer coleenp successfully credited.

PaulSandoz · 2020-09-25T20:39:32Z

/contributor add jbhateja
/contributor add vdeshpande
/contributor add qfeng
/contributor add igraves
/contributor add jphalimi
/contributor add vlivanov
/contributor add njian
/contributor add rlupusoru
/contributor add svkamath
/contributor add rkandu
/contributor add kkharbas
/contributor add Eric Liu Eric.Liu2@arm.com
/contributor add Aaloan Miftah someusername3@gmail.com
/contributor add jrose
/contributor add srukmannagar
/contributor add psandoz
/contributor add sviswanathan
/contributor add Lauren Walkowski lauren.walkowski@arm.com
/contributor add Yang Zang Yang.Zhang@arm.com
/contributor add jzhu
/contributor add wzhuo

openjdk · 2020-09-25T20:40:26Z

@PaulSandoz
Contributor Jatin Bhateja <jbhateja@openjdk.org> successfully added.

openjdk · 2020-09-25T20:41:03Z

@PaulSandoz
Contributor Vivek Deshpande <vdeshpande@openjdk.org> successfully added.

openjdk · 2020-09-25T20:41:42Z

@PaulSandoz
Contributor Qi Feng <qfeng@openjdk.org> successfully added.

openjdk · 2020-09-25T20:42:29Z

@PaulSandoz
Contributor Ian Graves <igraves@openjdk.org> successfully added.

openjdk · 2020-09-25T20:43:05Z

@PaulSandoz
Contributor Jean-Philippe Halimi <jphalimi@openjdk.org> successfully added.

openjdk · 2020-09-25T20:43:39Z

@PaulSandoz
Contributor Vladimir Ivanov <vlivanov@openjdk.org> successfully added.

openjdk · 2020-09-25T20:44:13Z

@PaulSandoz
Contributor Ningsheng Jian <njian@openjdk.org> successfully added.

openjdk · 2020-09-25T20:44:46Z

@PaulSandoz
Contributor Razvan Lupusoru <rlupusoru@openjdk.org> successfully added.

openjdk · 2020-09-25T20:45:52Z

@PaulSandoz
Contributor Smita Kamath <svkamath@openjdk.org> successfully added.

openjdk · 2020-09-25T20:46:58Z

@PaulSandoz
Contributor Rahul Kandu <rkandu@openjdk.org> successfully added.

openjdk · 2020-09-25T20:48:14Z

@PaulSandoz
Contributor Kishor Kharbas <kkharbas@openjdk.org> successfully added.

openjdk · 2020-09-25T20:49:25Z

@PaulSandoz
Contributor Eric Liu <Eric.Liu2@arm.com> successfully added.

PaulSandoz · 2020-09-25T21:00:23Z

/csr needed

openjdk · 2020-09-27T18:39:03Z

@PaulSandoz
Contributor Aaloan Miftah <someusername3@gmail.com> successfully added.

vnkozlov

Good

erikj79

Build changes look good.

openjdk · 2020-10-12T23:06:40Z

@PaulSandoz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8223347: Integration of Vector API (Incubator)

Co-authored-by: Vivek Deshpande <vdeshpande@openjdk.org>
Co-authored-by: Qi Feng <qfeng@openjdk.org>
Co-authored-by: Ian Graves <igraves@openjdk.org>
Co-authored-by: Jean-Philippe Halimi <jphalimi@openjdk.org>
Co-authored-by: Vladimir Ivanov <vlivanov@openjdk.org>
Co-authored-by: Ningsheng Jian <njian@openjdk.org>
Co-authored-by: Razvan Lupusoru <rlupusoru@openjdk.org>
Co-authored-by: Smita Kamath <svkamath@openjdk.org>
Co-authored-by: Rahul Kandu <rkandu@openjdk.org>
Co-authored-by: Kishor Kharbas <kkharbas@openjdk.org>
Co-authored-by: Eric Liu <Eric.Liu2@arm.com>
Co-authored-by: Aaloan Miftah <someusername3@gmail.com>
Co-authored-by: John R Rose <jrose@openjdk.org>
Co-authored-by: Shravya Rukmannagari <srukmannagar@openjdk.org>
Co-authored-by: Paul Sandoz <psandoz@openjdk.org>
Co-authored-by: Sandhya Viswanathan <sviswanathan@openjdk.org>
Co-authored-by: Lauren Walkowski <lauren.walkowski@arm.com>
Co-authored-by: Yang Zang <Yang.Zhang@arm.com>
Co-authored-by: Joshua Zhu <jzhu@openjdk.org>
Co-authored-by: Wang Zhuo <wzhuo@openjdk.org>
Co-authored-by: Jatin Bhateja <jbhateja@openjdk.org>
Reviewed-by: erikj, chegar, kvn, darcy, forax, briangoetz, aph, epavlova, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

386e7e8: 8254789: ProblemList compiler/graalunit/HotspotTest.java
cd33abb: 8249623: test @Ignore-d due to 7013634 should be returned back to execution
b7daf84: 8254345: com/sun/jdi/JdwpAttachTest.java reports error incorrectly
fde02e2: 8254012: NMT: MetaspaceSnapshot::snapshot uses wrong enum

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

katyapav · 2020-10-13T21:29:52Z

There are several gc tests crashed in panama-vector tier3 testing which seems are not observed in openjdk repo.
The crashes look like:

#  assert(oopDesc::is_oop(obj)) failed: not an oop: 0xfffffffffffffff1
#
# JRE version: Java(TM) SE Runtime Environment (16.0+3) (fastdebug build 16-panama+3-216)
# Java VM: Java HotSpot(TM) 64-Bit Server VM (fastdebug 16-panama+3-216, mixed mode, sharing, tiered, compressed oops, g1 gc, linux-amd64)
# Problematic frame:
# V  [libjvm.so+0xd8ef94]  HandleArea::allocate_handle(oop)+0x144

and the issue is actually tracked by JDK-8233199.

This issue needs to be at least analyzed before integrating Vector API.

sviswa7 · 2020-10-14T00:34:04Z

@katyapav Is the failure observed on vector-unstable branch of panama-vector?
The code in this pull request is from vector-unstable branch.
The bug report https://bugs.openjdk.java.net/browse/JDK-8233199 refers to repo-valhalla and not panama-vector:vector-unstable.
@PaulSandoz is doing final testing of the pull request today before integration tomorrow hopefully.

katyapav · 2020-10-14T00:47:49Z

@sviswa7 you are right, the failure is observed on vector-unstable branch of panama-vector.
I referred to JDK-8233199 because it seems both panama-vector and valhalla-repo have the same issue/crash.
@PaulSandoz also mentioned that panama-vector was not in sync with master and this is perhaps the issue is in vector-unstable. He said that he tested the PR separately and didn't observe this issue in the PR.

PaulSandoz · 2020-10-14T20:01:29Z

/integrate

openjdk · 2020-10-14T20:03:20Z

@PaulSandoz Since your change was applied there have been 4 commits pushed to the master branch:

386e7e8: 8254789: ProblemList compiler/graalunit/HotspotTest.java
cd33abb: 8249623: test @Ignore-d due to 7013634 should be returned back to execution
b7daf84: 8254345: com/sun/jdi/JdwpAttachTest.java reports error incorrectly
fde02e2: 8254012: NMT: MetaspaceSnapshot::snapshot uses wrong enum

Your commit was automatically rebased without conflicts.

Pushed as commit 0c99b19.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

sviswa7 added 2 commits September 18, 2020 17:56

Integration of Vector API (Incubator)

fff1d2d

Vector API new files

67ad48e

openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Sep 25, 2020

openjdk bot added hotspot hotspot-dev@openjdk.org build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Sep 25, 2020

ChrisHegarty approved these changes Oct 2, 2020

View reviewed changes

vnkozlov approved these changes Oct 2, 2020

View reviewed changes

openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Oct 7, 2020

jddarcy approved these changes Oct 12, 2020

View reviewed changes

openjdk bot removed the csr Pull request needs approved CSR before integration label Oct 12, 2020

erikj79 approved these changes Oct 12, 2020

View reviewed changes

sviswa7 added 2 commits October 12, 2020 15:59

Merge master

db60149

HotspotIntrinsicCandidate to IntrinsicCandidate

9cca17b

openjdk bot added ready Pull request is ready to be integrated and removed merge-conflict Pull request has merge conflict with target branch labels Oct 12, 2020

sviswa7 added 2 commits October 13, 2020 09:04

Fix related to merge

d5acb4f

Merge master

d8651ff

openjdk bot added merge-conflict Pull request has merge conflict with target branch and removed ready Pull request is ready to be integrated labels Oct 14, 2020

Merge master

0fd2f08

openjdk bot added ready Pull request is ready to be integrated and removed merge-conflict Pull request has merge conflict with target branch labels Oct 14, 2020

Merge master

3346d29

openjdk bot closed this Oct 14, 2020

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 14, 2020

DamonFool mentioned this pull request Oct 15, 2020

8254814: [Vector API] Fix an AVX512 crash after JDK-8223347 #676

Closed

3 tasks

PaulSandoz deleted the JDK-8223347 branch October 29, 2020 23:05

8223347: Integration of Vector API (Incubator) #367

8223347: Integration of Vector API (Incubator) #367

PaulSandoz commented Sep 25, 2020 •

edited by openjdk bot

bridgekeeper bot commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

PaulSandoz commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

PaulSandoz commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

PaulSandoz commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

PaulSandoz commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

PaulSandoz commented Sep 25, 2020

openjdk bot commented Sep 27, 2020

vnkozlov left a comment

erikj79 left a comment

openjdk bot commented Oct 12, 2020 •

edited

katyapav commented Oct 13, 2020 •

edited by bridgekeeper bot

sviswa7 commented Oct 14, 2020

katyapav commented Oct 14, 2020

PaulSandoz commented Oct 14, 2020

openjdk bot commented Oct 14, 2020

8223347: Integration of Vector API (Incubator) #367

8223347: Integration of Vector API (Incubator) #367

Conversation

PaulSandoz commented Sep 25, 2020 • edited by openjdk bot

Progress

Testing

Issue

Reviewers

Contributors

Download

bridgekeeper bot commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

PaulSandoz commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

PaulSandoz commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

PaulSandoz commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

PaulSandoz commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

PaulSandoz commented Sep 25, 2020

openjdk bot commented Sep 27, 2020

vnkozlov left a comment

Choose a reason for hiding this comment

erikj79 left a comment

Choose a reason for hiding this comment

openjdk bot commented Oct 12, 2020 • edited

katyapav commented Oct 13, 2020 • edited by bridgekeeper bot

sviswa7 commented Oct 14, 2020

katyapav commented Oct 14, 2020

PaulSandoz commented Oct 14, 2020

openjdk bot commented Oct 14, 2020

PaulSandoz commented Sep 25, 2020 •

edited by openjdk bot

openjdk bot commented Oct 12, 2020 •

edited

katyapav commented Oct 13, 2020 •

edited by bridgekeeper bot