Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265911: assert(comp != __null) failed: Compiler instance missing #3672

Closed
wants to merge 1 commit into from

Conversation

@whjpji
Copy link

@whjpji whjpji commented Apr 25, 2021

As I debugged into the code, the _c1_count was set to 1 [1] with flags -XX:+EnableJVMCI -XX:+UseJVMCICompiler -XX:JVMCIHostThreads=1. However, [2] would never be executed, and thus _compilers[0] was NULL.

When C1 is disabled, _c1_count should always be 0, so I added this #ifdef guard to avoid changing value of _c1_count under this circumstance.

[1]

_c1_count = JVMCIHostThreads;

[2]
_compilers[0] = new Compiler();


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265911: assert(comp != __null) failed: Compiler instance missing

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3672/head:pull/3672
$ git checkout pull/3672

Update a local copy of the PR:
$ git checkout pull/3672
$ git pull https://git.openjdk.java.net/jdk pull/3672/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3672

View PR using the GUI difftool:
$ git pr show -t 3672

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3672.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 25, 2021

👋 Welcome back whjpji! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 25, 2021

@whjpji The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 25, 2021

Webrevs

@whjpji
Copy link
Author

@whjpji whjpji commented Apr 25, 2021

/test builds

@openjdk
Copy link

@openjdk openjdk bot commented Apr 25, 2021

@whjpji you need to get approval to run the tests in tier1 for commits up until 4cf206f

@openjdk openjdk bot added the test-request label Apr 25, 2021
@whjpji
Copy link
Author

@whjpji whjpji commented Apr 25, 2021

/test tier1

@openjdk
Copy link

@openjdk openjdk bot commented Apr 25, 2021

@whjpji you need to get approval to run the tests in tier1 for commits up until 4cf206f

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Good.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 25, 2021

⚠️ @whjpji the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout jdk-8265911
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full name'
$ git push
@openjdk
Copy link

@openjdk openjdk bot commented Apr 25, 2021

@whjpji This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265911: assert(comp != __null) failed: Compiler instance missing

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 0d08d73: 8265702: ZGC on macOS/aarch64
  • 45c5da0: 8265746: Update java.time to use instanceof pattern variable (part II)
  • a85f6cb: 8265613: False positives for "Related Packages"
  • 6e5026a: 8198621: java/awt/Focus/KeyEventForBadFocusOwnerTest/KeyEventForBadFocusOwnerTest.java fails on mac
  • 7b609a2: 8264031: (zipfs) Typo in ZipFileSystem.deleteFile ZipException
  • 56fbef0: 8265681: G1: general cleanup for G1FullGCHeapRegionAttr
  • 578a0b3: 8261238: NMT should not limit baselining by size threshold
  • 3bf4c90: 8264317: Lanai: IncorrectUnmanagedImageRotatedClip.java fails on apple M1
  • f1f2afd: 8264028: Typo in javax.management.relation.RelationService::purgeRelations

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov, @TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Apr 25, 2021
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good. Is it worth adding a regression test?

@whjpji
Copy link
Author

@whjpji whjpji commented Apr 26, 2021

Looks good. Is it worth adding a regression test?

Thanks @TobiHartmann.

Actually, this bug is produced by runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java (4 of 10).

@whjpji
Copy link
Author

@whjpji whjpji commented Apr 26, 2021

/integrate

@openjdk openjdk bot added the sponsor label Apr 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 26, 2021

@whjpji
Your change (at version 4cf206f) is now ready to be sponsored by a Committer.

@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Apr 26, 2021

Okay, thanks for the clarification.

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Apr 26, 2021

@TobiHartmann @whjpji Since your change was applied there have been 10 commits pushed to the master branch:

  • 9647fb0: 8265689: JVMCI: InternalError: Class java.lang.Object does not implement interface jdk.vm.ci.meta.JavaType
  • 0d08d73: 8265702: ZGC on macOS/aarch64
  • 45c5da0: 8265746: Update java.time to use instanceof pattern variable (part II)
  • a85f6cb: 8265613: False positives for "Related Packages"
  • 6e5026a: 8198621: java/awt/Focus/KeyEventForBadFocusOwnerTest/KeyEventForBadFocusOwnerTest.java fails on mac
  • 7b609a2: 8264031: (zipfs) Typo in ZipFileSystem.deleteFile ZipException
  • 56fbef0: 8265681: G1: general cleanup for G1FullGCHeapRegionAttr
  • 578a0b3: 8261238: NMT should not limit baselining by size threshold
  • 3bf4c90: 8264317: Lanai: IncorrectUnmanagedImageRotatedClip.java fails on apple M1
  • f1f2afd: 8264028: Typo in javax.management.relation.RelationService::purgeRelations

Your commit was automatically rebased without conflicts.

Pushed as commit 1580a47.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants