8265901: Use pattern matching for instanceof at module jdk.compiler(part 3)

[lgxbslgx]

Hi all,

This series of patches update the code of the module jdk.compiler by using the pattern matching for instanceof.

This patch only revises the package com.sun.tools.sjavac.

Thank you for taking the time to review.

--
Best Regards,
Guoxiong.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8265901: Use pattern matching for instanceof at module jdk.compiler(part 3)

Reviewers

• Maurizio Cimadamore (@mcimadamore - Reviewer)
• Joel Borggrén-Franck (@jbf - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3675/head:pull/3675
$ git checkout pull/3675

Update a local copy of the PR:
$ git checkout pull/3675
$ git pull https://git.openjdk.java.net/jdk pull/3675/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3675

View PR using the GUI difftool:
$ git pr show -t 3675

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3675.diff

[bridgekeeper]

👋 Welcome back gli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lgxbslgx The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (fcb45e28)

[mcimadamore]

Looks good

[openjdk]

@lgxbslgx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265901: Use pattern matching for instanceof at module jdk.compiler(part 3)

Reviewed-by: mcimadamore, jfranck

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• b9f66d9: 8264188: Improve handling of assembly files in the JDK
• c3ac690: 8261759: ZGC: ZWorker Threads Continue Marking After System.exit() called
• 31abe68: 8265116: ZGC: Steal local stacks instead of flushing them
• 83364a4: 8264258: Unknown lookups in the java package give misleading compilation errors
• a9367db: 8265127: ZGC: Fix incorrect reporting of reclaimed memory
• 1580a47: 8265911: assert(comp != __null) failed: Compiler instance missing
• 9647fb0: 8265689: JVMCI: InternalError: Class java.lang.Object does not implement interface jdk.vm.ci.meta.JavaType
• 0d08d73: 8265702: ZGC on macOS/aarch64
• 45c5da0: 8265746: Update java.time to use instanceof pattern variable (part II)
• a85f6cb: 8265613: False positives for "Related Packages"
• ... and 6 more: https://git.openjdk.java.net/jdk/compare/f6e22d14e3ee529f21ab8747cfbafe72b906ec68...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mcimadamore, @jbf) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[lgxbslgx]

@mcimadamore @jbf Thank you for your review. Could I get your help to sponsor this patch?

/integrate

[openjdk]

@lgxbslgx
Your change (at version fcb45e2) is now ready to be sponsored by a Committer.

[jbf]

/sponsor

[openjdk]

@jbf @lgxbslgx Since your change was applied there have been 21 commits pushed to the master branch:

• fb8f0c5: 8261168: Convert javadoc tool to use Stream.toList()
• 8559a53: 8265394: G1: Improve assert in HeapRegion::reset_not_compacted_after_full_gc
• 68011c6: 8265928: G1: Update copyright in several files
• 222f9f0: 8265682: G1: Mutex::_name dangling in HeapRegionRemSet references after JDK-8264146
• 2b09ff2: 8232765: NullPointerException at Types.eraseNotNeeded() when compiling a class
• b9f66d9: 8264188: Improve handling of assembly files in the JDK
• c3ac690: 8261759: ZGC: ZWorker Threads Continue Marking After System.exit() called
• 31abe68: 8265116: ZGC: Steal local stacks instead of flushing them
• 83364a4: 8264258: Unknown lookups in the java package give misleading compilation errors
• a9367db: 8265127: ZGC: Fix incorrect reporting of reclaimed memory
• ... and 11 more: https://git.openjdk.java.net/jdk/compare/f6e22d14e3ee529f21ab8747cfbafe72b906ec68...master

Your commit was automatically rebased without conflicts.

Pushed as commit 851b219.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.