8265915: adjust state_unloading_cycle compuation order in nmethod::is_unloading

[miao-zheng]

Trivial change of moving state_unloading_cycle computation after state_is_unloading checking. Avoiding useless state_unloading_cycle computation when state_is_unloading is true.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8265915: adjust state_unloading_cycle compuation order in nmethod::is_unloading

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3676/head:pull/3676
$ git checkout pull/3676

Update a local copy of the PR:
$ git checkout pull/3676
$ git pull https://git.openjdk.java.net/jdk pull/3676/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3676

View PR using the GUI difftool:
$ git pr show -t 3676

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3676.diff

[bridgekeeper]

Hi @miao-zheng, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user miao-zheng" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

@miao-zheng The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[miao-zheng]

/covered

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[mlbridge]

Webrevs

• 00: Full (e0523d90)

[TobiHartmann]

Looks good and trivial.

[openjdk]

⚠️ @miao-zheng the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8265915
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full name'
$ git push

[openjdk]

@miao-zheng This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265915: adjust state_unloading_cycle compuation order in nmethod::is_unloading

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 297 new commits pushed to the master branch:

• 20ad428: 8180568: Refactor javax/crypto shell tests to plain java tests
• 138d573: 8262392: Update Mesa 3-D Headers to version 21.0.3
• 9de62a4: 8266505: Cleanup LibraryCallKit::make_unsafe_address()
• 1885c83: 8266504: Remove leftovers from BarrierSetAssemblerC1
• 6018336: 8259316: [REDO] C1/C2 compiler support for blackholes
• f07bb2f: 8250766: javadoc adds redundant spaces when @see program element is wrapped
• 61bb6ec: 8266453: Shenandoah: Disable write protections before patching nmethod in nmethod_barrier on MacOSX/AArch64
• a05e8e2: 8266497: Remove unnecessary EMCP liveness indication
• 6ba911d: 8266498: Make debug ps() call print_stack
• ef0f693: 8266499: Delete dead code in aarch64.ad
• ... and 287 more: https://git.openjdk.java.net/jdk/compare/787908c7788021395885280946de70d03b7ab39b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[miao-zheng]

/integrate

[openjdk]

@miao-zheng
Your change (at version e0523d9) is now ready to be sponsored by a Committer.

[johnshajiang]

/sponsor

[openjdk]

@johnshajiang @miao-zheng Since your change was applied there have been 297 commits pushed to the master branch:

• 20ad428: 8180568: Refactor javax/crypto shell tests to plain java tests
• 138d573: 8262392: Update Mesa 3-D Headers to version 21.0.3
• 9de62a4: 8266505: Cleanup LibraryCallKit::make_unsafe_address()
• 1885c83: 8266504: Remove leftovers from BarrierSetAssemblerC1
• 6018336: 8259316: [REDO] C1/C2 compiler support for blackholes
• f07bb2f: 8250766: javadoc adds redundant spaces when @see program element is wrapped
• 61bb6ec: 8266453: Shenandoah: Disable write protections before patching nmethod in nmethod_barrier on MacOSX/AArch64
• a05e8e2: 8266497: Remove unnecessary EMCP liveness indication
• 6ba911d: 8266498: Make debug ps() call print_stack
• ef0f693: 8266499: Delete dead code in aarch64.ad
• ... and 287 more: https://git.openjdk.java.net/jdk/compare/787908c7788021395885280946de70d03b7ab39b...master

Your commit was automatically rebased without conflicts.

Pushed as commit 7835cdb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.