8163367: Test javax/swing/JComboBox/8033069/bug8033069NoScrollBar.java javax/swing/JComboBox/8033069/bug8033069ScrollBar.java fails intermittently #3678
Conversation
…a javax/swing/JComboBox/8033069/bug8033069ScrollBar.java fails intermittently
|
👋 Welcome back pbansal! A progress list of the required criteria for merging this PR into |
|
@pankaj-bansal The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
|
@aivanov-jdk please take a look |
| private Point p; | ||
| private Dimension d; |
There was a problem hiding this comment.
Both should be volatile as they're accessed from two different threads.
| p = cb1.getLocationOnScreen(); | ||
| d = cb1.getSize(); | ||
| }); | ||
| robot.waitForIdle(); |
There was a problem hiding this comment.
Is it needed here?
The block above does not modify the state of the UI.
| robot.mouseMove(p.x + d.width / 2, p.y + d.height / 2); | ||
| robot.waitForIdle(); |
There was a problem hiding this comment.
I believe the delay between mouseMove and mousePress/Release is unneeded, does it really make a difference?
| if (frame != null) { | ||
| frame.dispose(); | ||
| SwingUtilities.invokeAndWait(frame::dispose); | ||
| } |
There was a problem hiding this comment.
The frame is still accessed from two different threads.
test/jdk/javax/swing/JComboBox/8033069/bug8033069NoScrollBar.java
Outdated
Show resolved
Hide resolved
Review comments Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk@users.noreply.github.com>
|
@pankaj-bansal This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 199 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
openjdk
bot
added
integrated
|
@pankaj-bansal Since your change was applied there have been 202 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 9481fad. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The tests a javax/swing/JComboBox/8033069/bug8033069ScrollBar.java and javax/swing/JComboBox/8033069/bug8033069NoScrollBar.java fails intermittently. The tests have a few problems which could cause this behaviour and the are being fixed here.
There is some additional cleanup done in the fix and moved the frame in centre. The tests pass with multiple iterations on CI. Link in the JBS.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3678/head:pull/3678$ git checkout pull/3678Update a local copy of the PR:
$ git checkout pull/3678$ git pull https://git.openjdk.java.net/jdk pull/3678/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3678View PR using the GUI difftool:
$ git pr show -t 3678Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3678.diff