8253660: Need better error report when artifact resolution fails in AotCompiler.java

[erikj79]

In AotCompiler.java, if artifact resolution fails, we have no way of diagnosing the error. This patch improves the default toString() of ArtifactResolverException to automatically include the toString() method of the root cause. It also adds stack trace printing specifically in AotCompiler.java.

I also found a similar issue in PKCS11Test, and fixed it by adding the ArtifactResolverException there as cause for the RuntimeException being thrown. This causes the stack trace to be printed on failure.

I looked through all other uses of ArtifactResolver, but they are handling the exception in a way that already prints the stack trace.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8253660: Need better error report when artifact resolution fails in AotCompiler.java

Reviewers

• Magnus Ihse Bursie (@magicus - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/368/head:pull/368
$ git checkout pull/368

[erikj79]

/label build

[bridgekeeper]

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@erikj79
The build label was successfully added.

[mlbridge]

Webrevs

• 00: Full (ed9fdf1)

[magicus]

Looks good to me.

[openjdk]

@erikj79 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8253660: Need better error report when artifact resolution fails in AotCompiler.java

Reviewed-by: ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 306 new commits pushed to the master branch:

• 011dd0d: 8254824: SignalHandlerMark have no purpose
• 736e077: 8254178: Remove .hgignore
• 51a865d: 8254085: javax/swing/text/Caret/TestCaretPositionJTextPane.java failed with "RuntimeException: Wrong caret position"
• dd032b7: 8254798: Deprecate for removal an empty finalize() methods in java.desktop module
• 272bb5d: 8253455: Record Classes javax.lang.model changes
• c17d585: 8246774: implement Record Classes as a standard feature in Java
• 0b3e6c5: 8194126: Regression automated Test '/open/test/jdk/javax/swing/JColorChooser/Test7194184.java' fails
• ce1aac1: 8028707: javax/swing/JComboBox/6236162/bug6236162.java fails on azure
• 83ea863: 8253559: The INDEX page should link to Serialized Form and Constant Values pages
• e66c6bb: 8254349: The TestNoScreenMenuBar test should be updated
• ... and 296 more: https://git.openjdk.java.net/jdk/compare/0187567704d79ecf394d4cb656d0ba4c886351f1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[erikj79]

/integrate

[openjdk]

@erikj79 Since your change was applied there have been 321 commits pushed to the master branch:

• 52cb329: 8254862: lldb in devkit doesn't work
• 60f63ec: 8254796: Cleanup pervasive unnecessary parameter
• 953e472: 8254967: com.sun.net.HttpsServer spins on TLS session close
• 1da28de: 8255009: delta apply fixes for JDK-8246774 and JDK-8253455, pushed too soon
• a0382cd: 8253235: JFR.dump does not respect maxage parameter
• cb7701b: 8253970: Build error: address argument to atomic builtin must be a pointer to integer or pointer ('volatile narrowOop *' invalid)
• 4ffed32: 8254940: AArch64: Cleanup non-product thread members
• cd66e0f: 8253877: gc/g1/TestGCLogMessages.java fails - missing "Evacuation failure" message
• e76de18: 8223051: support loops with long (64b) trip counts
• e9be2db: 8253453: SourceFileInfoTable should be allocated lazily
• ... and 311 more: https://git.openjdk.java.net/jdk/compare/0187567704d79ecf394d4cb656d0ba4c886351f1...master

Your commit was automatically rebased without conflicts.

Pushed as commit 0b51016.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.