-
Notifications
You must be signed in to change notification settings - Fork 6.2k
JDK-8265394: G1: Improve assert in HeapRegion::reset_not_compacted_after_full_gc #3680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back mli! A progress list of the required criteria for merging this PR into |
|
@Hamlin-Li The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
seems that the Build failure on mac is not related to this change. |
tschatzl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and trivial.
|
@Hamlin-Li this pull request can not be integrated into git checkout improve-assert
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
|
Thanks Thomas for your review. |
|
/integrate |
|
@Hamlin-Li This PR has not yet been marked as ready for integration. |
|
/integrate |
|
@Hamlin-Li This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
@Hamlin-Li Pushed as commit 8559a53. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This is a trivial assert message improvement/fix.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3680/head:pull/3680$ git checkout pull/3680Update a local copy of the PR:
$ git checkout pull/3680$ git pull https://git.openjdk.java.net/jdk pull/3680/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3680View PR using the GUI difftool:
$ git pr show -t 3680Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3680.diff