Skip to content

Conversation

@Hamlin-Li
Copy link

@Hamlin-Li Hamlin-Li commented Apr 26, 2021

This is a trivial assert message improvement/fix.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265394: G1: Improve assert in HeapRegion::reset_not_compacted_after_full_gc

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3680/head:pull/3680
$ git checkout pull/3680

Update a local copy of the PR:
$ git checkout pull/3680
$ git pull https://git.openjdk.java.net/jdk pull/3680/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3680

View PR using the GUI difftool:
$ git pr show -t 3680

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3680.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 26, 2021

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 26, 2021

@Hamlin-Li The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Apr 26, 2021
@Hamlin-Li Hamlin-Li changed the title G1: Improve assert in HeapRegion::reset_not_compacted_after_full_gc JDK-8265394: G1: Improve assert in HeapRegion::reset_not_compacted_after_full_gc Apr 26, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 26, 2021
@Hamlin-Li
Copy link
Author

seems that the Build failure on mac is not related to this change.

@mlbridge
Copy link

mlbridge bot commented Apr 26, 2021

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and trivial.

@openjdk
Copy link

openjdk bot commented Apr 26, 2021

@Hamlin-Li this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout improve-assert
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Apr 26, 2021
@Hamlin-Li
Copy link
Author

Thanks Thomas for your review.

@Hamlin-Li
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 26, 2021

@Hamlin-Li This PR has not yet been marked as ready for integration.

@Hamlin-Li
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 26, 2021

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265394: G1: Improve assert in HeapRegion::reset_not_compacted_after_full_gc

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed merge-conflict Pull request has merge conflict with target branch labels Apr 26, 2021
@openjdk openjdk bot closed this Apr 26, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 26, 2021
@openjdk
Copy link

openjdk bot commented Apr 26, 2021

@Hamlin-Li Pushed as commit 8559a53.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Hamlin-Li Hamlin-Li deleted the improve-assert branch May 11, 2021 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants