New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8265928: G1: Update copyright in several files #3682
Conversation
|
@Hamlin-Li The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
Please upper case the first word in the description (here and in the CR).
Edit: I also added "G1:" to the title in the CR.
@Hamlin-Li This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 226 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
Thanks Thomas for your review. |
/integrate |
@Hamlin-Li Since your change was applied there have been 226 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 68011c6. |
/help |
@Hamlin-Li Available commands:
|
I missed update the copyrights in several files, and per suggested in #2379 (review), it's better to update them in a separate CR, this is the one to fix them in a batch.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3682/head:pull/3682
$ git checkout pull/3682
Update a local copy of the PR:
$ git checkout pull/3682
$ git pull https://git.openjdk.java.net/jdk pull/3682/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3682
View PR using the GUI difftool:
$ git pr show -t 3682
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3682.diff