Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8265928: G1: Update copyright in several files #3682

Closed
wants to merge 1 commit into from

Conversation

Hamlin-Li
Copy link

@Hamlin-Li Hamlin-Li commented Apr 26, 2021

I missed update the copyrights in several files, and per suggested in #2379 (review), it's better to update them in a separate CR, this is the one to fix them in a batch.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3682/head:pull/3682
$ git checkout pull/3682

Update a local copy of the PR:
$ git checkout pull/3682
$ git pull https://git.openjdk.java.net/jdk pull/3682/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3682

View PR using the GUI difftool:
$ git pr show -t 3682

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3682.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 26, 2021

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 26, 2021
@openjdk
Copy link

openjdk bot commented Apr 26, 2021

@Hamlin-Li The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Apr 26, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 26, 2021

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

Please upper case the first word in the description (here and in the CR).

Edit: I also added "G1:" to the title in the CR.

@openjdk
Copy link

openjdk bot commented Apr 26, 2021

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265928: G1: Update copyright in several files

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 226 new commits pushed to the master branch:

  • 222f9f0: 8265682: G1: Mutex::_name dangling in HeapRegionRemSet references after JDK-8264146
  • 2b09ff2: 8232765: NullPointerException at Types.eraseNotNeeded() when compiling a class
  • b9f66d9: 8264188: Improve handling of assembly files in the JDK
  • c3ac690: 8261759: ZGC: ZWorker Threads Continue Marking After System.exit() called
  • 31abe68: 8265116: ZGC: Steal local stacks instead of flushing them
  • 83364a4: 8264258: Unknown lookups in the java package give misleading compilation errors
  • a9367db: 8265127: ZGC: Fix incorrect reporting of reclaimed memory
  • 1580a47: 8265911: assert(comp != __null) failed: Compiler instance missing
  • 9647fb0: 8265689: JVMCI: InternalError: Class java.lang.Object does not implement interface jdk.vm.ci.meta.JavaType
  • 0d08d73: 8265702: ZGC on macOS/aarch64
  • ... and 216 more: https://git.openjdk.java.net/jdk/compare/1935655622226421797ea9109bebd4a00fe60402...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 26, 2021
@Hamlin-Li Hamlin-Li changed the title JDK-8265928: update copyright in several files JDK-8265928: G1: Update copyright in several files Apr 26, 2021
@Hamlin-Li
Copy link
Author

Thanks Thomas for your review.

@Hamlin-Li
Copy link
Author

/integrate

@openjdk openjdk bot closed this Apr 26, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 26, 2021
@openjdk
Copy link

openjdk bot commented Apr 26, 2021

@Hamlin-Li Since your change was applied there have been 226 commits pushed to the master branch:

  • 222f9f0: 8265682: G1: Mutex::_name dangling in HeapRegionRemSet references after JDK-8264146
  • 2b09ff2: 8232765: NullPointerException at Types.eraseNotNeeded() when compiling a class
  • b9f66d9: 8264188: Improve handling of assembly files in the JDK
  • c3ac690: 8261759: ZGC: ZWorker Threads Continue Marking After System.exit() called
  • 31abe68: 8265116: ZGC: Steal local stacks instead of flushing them
  • 83364a4: 8264258: Unknown lookups in the java package give misleading compilation errors
  • a9367db: 8265127: ZGC: Fix incorrect reporting of reclaimed memory
  • 1580a47: 8265911: assert(comp != __null) failed: Compiler instance missing
  • 9647fb0: 8265689: JVMCI: InternalError: Class java.lang.Object does not implement interface jdk.vm.ci.meta.JavaType
  • 0d08d73: 8265702: ZGC on macOS/aarch64
  • ... and 216 more: https://git.openjdk.java.net/jdk/compare/1935655622226421797ea9109bebd4a00fe60402...master

Your commit was automatically rebased without conflicts.

Pushed as commit 68011c6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Hamlin-Li Hamlin-Li deleted the copy-rights-update branch May 11, 2021 01:23
@Hamlin-Li
Copy link
Author

/help

@openjdk
Copy link

openjdk bot commented May 26, 2021

@Hamlin-Li Available commands:

  • covered - used when employer has signed the OCA
  • help - shows this text
  • signed - used after signing the OCA
  • test - used to run tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
2 participants