Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8196300: java/awt/TextArea/TextAreaScrolling/TextAreaScrolling.java times out #3686

Closed
wants to merge 1 commit into from

Conversation

@prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Apr 26, 2021

This test was timing out on windows during nightly testing possibly due to samevm mode issue when it was problemlisted.
Modified test to increase the timing delay after frame is made visible, added waitForIdle() at suitable places and delays to make sure the execution steps are visible during execution.
Modified test pass in several iterations in all platforms.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8196300: java/awt/TextArea/TextAreaScrolling/TextAreaScrolling.java times out

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3686/head:pull/3686
$ git checkout pull/3686

Update a local copy of the PR:
$ git checkout pull/3686
$ git pull https://git.openjdk.java.net/jdk pull/3686/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3686

View PR using the GUI difftool:
$ git pr show -t 3686

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3686.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 26, 2021

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 26, 2021

@prsadhuk The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt label Apr 26, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 26, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Apr 27, 2021

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8196300: java/awt/TextArea/TextAreaScrolling/TextAreaScrolling.java times out

Reviewed-by: jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

  • 694aced: 8264805: Remove the experimental Ahead-of-Time Compiler
  • 15d4787: 8265496: improve null check in DeflaterOutputStream/InflaterInputStream
  • 1d37b98: 8265972: Remove declarations with no implementations in javaClasses.hpp
  • cb29b19: 8184134: HeapRegion::LogOfHRGrainWords is unused
  • 41daa88: 8265899: Use pattern matching for instanceof at module jdk.compiler(part 1)
  • a6f2863: 8266003: ProblemList sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java on macosx-all
  • 852a41d: 8258625: [JVMCI] refactor and unify JVMCI readFieldValue path
  • b5c6351: 8264663: Update test SuspendWithCurrentThread.java to verify that suspend doesn't exit until resumed
  • b524a81: 8265982: JDK-8264188 breaks build on macOS-aarch64
  • efe6b93: 8265961: Fix comments in logging.properties
  • ... and 16 more: https://git.openjdk.java.net/jdk/compare/45c5da0fd3bb37e5564a8af6f41a484109599723...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 27, 2021
@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Apr 27, 2021

/integrate

@openjdk openjdk bot closed this Apr 27, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 27, 2021

@prsadhuk Since your change was applied there have been 26 commits pushed to the master branch:

  • 694aced: 8264805: Remove the experimental Ahead-of-Time Compiler
  • 15d4787: 8265496: improve null check in DeflaterOutputStream/InflaterInputStream
  • 1d37b98: 8265972: Remove declarations with no implementations in javaClasses.hpp
  • cb29b19: 8184134: HeapRegion::LogOfHRGrainWords is unused
  • 41daa88: 8265899: Use pattern matching for instanceof at module jdk.compiler(part 1)
  • a6f2863: 8266003: ProblemList sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java on macosx-all
  • 852a41d: 8258625: [JVMCI] refactor and unify JVMCI readFieldValue path
  • b5c6351: 8264663: Update test SuspendWithCurrentThread.java to verify that suspend doesn't exit until resumed
  • b524a81: 8265982: JDK-8264188 breaks build on macOS-aarch64
  • efe6b93: 8265961: Fix comments in logging.properties
  • ... and 16 more: https://git.openjdk.java.net/jdk/compare/45c5da0fd3bb37e5564a8af6f41a484109599723...master

Your commit was automatically rebased without conflicts.

Pushed as commit 7db9330.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the prsadhuk:JDK-8196300 branch Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants