Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265961: Fix comments in logging.properties #3688

Closed
wants to merge 2 commits into from

Conversation

@pavelrappo
Copy link
Member

@pavelrappo pavelrappo commented Apr 26, 2021

I had been looking for an example of a "properties" file when spotted a typo in logging.properties. I decided to proofread the file. That resulted in finding a few other issues.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3688/head:pull/3688
$ git checkout pull/3688

Update a local copy of the PR:
$ git checkout pull/3688
$ git pull https://git.openjdk.java.net/jdk pull/3688/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3688

View PR using the GUI difftool:
$ git pr show -t 3688

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3688.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 26, 2021

👋 Welcome back prappo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 26, 2021

@pavelrappo The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Apr 26, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 26, 2021

Webrevs

dfuch
dfuch approved these changes Apr 26, 2021
Copy link
Member

@dfuch dfuch left a comment

LGTM, but English is not my primary language.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 26, 2021

@pavelrappo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265961: Fix comments in logging.properties

Reviewed-by: dfuchs, mr, iris, jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • 851b219: 8265901: Use pattern matching for instanceof at module jdk.compiler(part 3)
  • fb8f0c5: 8261168: Convert javadoc tool to use Stream.toList()
  • 8559a53: 8265394: G1: Improve assert in HeapRegion::reset_not_compacted_after_full_gc
  • 68011c6: 8265928: G1: Update copyright in several files
  • 222f9f0: 8265682: G1: Mutex::_name dangling in HeapRegionRemSet references after JDK-8264146
  • 2b09ff2: 8232765: NullPointerException at Types.eraseNotNeeded() when compiling a class
  • b9f66d9: 8264188: Improve handling of assembly files in the JDK
  • c3ac690: 8261759: ZGC: ZWorker Threads Continue Marking After System.exit() called
  • 31abe68: 8265116: ZGC: Steal local stacks instead of flushing them
  • 83364a4: 8264258: Unknown lookups in the java package give misleading compilation errors
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/45c5da0fd3bb37e5564a8af6f41a484109599723...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 26, 2021
@pavelrappo
Copy link
Member Author

@pavelrappo pavelrappo commented Apr 26, 2021

Thanks, Daniel. Let's maybe wait for one more reviewer then. I am also a bit skeptical about this use of "the" here:

# Limit the messages that are printed on the console to INFO and above.
        ^

I don't think it's required.

Copy link
Member

@mbreinhold mbreinhold left a comment

Otherwise, these changes look fine.

src/java.logging/share/conf/logging.properties Outdated Show resolved Hide resolved
@pavelrappo
Copy link
Member Author

@pavelrappo pavelrappo commented Apr 26, 2021

/integrate

@openjdk openjdk bot closed this Apr 26, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 26, 2021

@pavelrappo Since your change was applied there have been 16 commits pushed to the master branch:

  • 65c19c4: 4926314: Optimize Reader.read(CharBuffer)
  • 082abbd: 8265900: Use pattern matching for instanceof at module jdk.compiler(part 2)
  • 851b219: 8265901: Use pattern matching for instanceof at module jdk.compiler(part 3)
  • fb8f0c5: 8261168: Convert javadoc tool to use Stream.toList()
  • 8559a53: 8265394: G1: Improve assert in HeapRegion::reset_not_compacted_after_full_gc
  • 68011c6: 8265928: G1: Update copyright in several files
  • 222f9f0: 8265682: G1: Mutex::_name dangling in HeapRegionRemSet references after JDK-8264146
  • 2b09ff2: 8232765: NullPointerException at Types.eraseNotNeeded() when compiling a class
  • b9f66d9: 8264188: Improve handling of assembly files in the JDK
  • c3ac690: 8261759: ZGC: ZWorker Threads Continue Marking After System.exit() called
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/45c5da0fd3bb37e5564a8af6f41a484109599723...master

Your commit was automatically rebased without conflicts.

Pushed as commit efe6b93.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@pavelrappo pavelrappo deleted the logging.properties branch Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants