Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263972: C2: LoadVector/StoreVector type mismatch in MemNode::can_see_stored_value() #3698

Closed
wants to merge 3 commits into from

Conversation

@iwanowww
Copy link

@iwanowww iwanowww commented Apr 26, 2021

MemNode::can_see_stored_value() doesn't take type info for LoadVector/StoreVector into account.

Eliminating LoadVector/StoreVector pair in presence of a type mismatch leads to a broken graph (omitting vector cast nodes) and sometimes manifest as a broken generated code.

The fix adds necessary checks for vector case.

Testing:

  • regression test
  • hs-tier1 - hs-tier4

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263972: C2: LoadVector/StoreVector type mismatch in MemNode::can_see_stored_value()

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3698/head:pull/3698
$ git checkout pull/3698

Update a local copy of the PR:
$ git checkout pull/3698
$ git pull https://git.openjdk.java.net/jdk pull/3698/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3698

View PR using the GUI difftool:
$ git pr show -t 3698

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3698.diff

Vladimir Ivanov added 2 commits Apr 26, 2021
@iwanowww iwanowww marked this pull request as ready for review Apr 26, 2021
@iwanowww iwanowww marked this pull request as draft Apr 26, 2021
@iwanowww
Copy link
Author

@iwanowww iwanowww commented Apr 26, 2021

/label add hotspot-compiler

@iwanowww iwanowww marked this pull request as ready for review Apr 26, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 26, 2021

👋 Welcome back vlivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 26, 2021

@iwanowww
The hotspot-compiler label was successfully added.

@openjdk openjdk bot added the rfr label Apr 26, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 26, 2021

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Good.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 26, 2021

@iwanowww This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263972: C2: LoadVector/StoreVector type mismatch in MemNode::can_see_stored_value()

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • 0a4c338: 8263432: javac may report an invalid package/class clash on case insensitive filesystems
  • 82b3719: 8265967: Unused NullCheckNode forward declaration in node.hpp
  • 468c847: 8234020: Remove FullGCCount_lock
  • 4785e11: 8264806: Remove the experimental JIT compiler
  • 7db9330: 8196300: java/awt/TextArea/TextAreaScrolling/TextAreaScrolling.java times out
  • 694aced: 8264805: Remove the experimental Ahead-of-Time Compiler
  • 15d4787: 8265496: improve null check in DeflaterOutputStream/InflaterInputStream
  • 1d37b98: 8265972: Remove declarations with no implementations in javaClasses.hpp
  • cb29b19: 8184134: HeapRegion::LogOfHRGrainWords is unused
  • 41daa88: 8265899: Use pattern matching for instanceof at module jdk.compiler(part 1)
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/8559a53056c2d4eed51d9df4a212d10b62bb9878...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 26, 2021
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good.

@iwanowww
Copy link
Author

@iwanowww iwanowww commented Apr 27, 2021

Thanks for the reviews, Vladimir and Tobias.

/integrate

@openjdk openjdk bot closed this Apr 27, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 27, 2021

@iwanowww Since your change was applied there have been 27 commits pushed to the master branch:

  • 377b346: 8264752: SIGFPE crash with option FlightRecorderOptions:threadbuffersize=30M
  • dc323a9: 8263421: Module image file is opened twice during VM startup
  • fbfd4ea: 8265914: Duplicated NotANode and not_a_node
  • 9481fad: 8163367: Test javax/swing/JComboBox/8033069/bug8033069NoScrollBar.java javax/swing/JComboBox/8033069/bug8033069ScrollBar.java fails intermittently
  • 9adbf15: 8265995: Shenandoah: Move ShenandoahInitMarkRootsClosure close to its use
  • 879a77f: 8265757: stack-use-after-scope in perfMemory_posix.cpp get_user_name_slow()
  • e4be968: 8265980: Fix systemDictionary and loaderConstraints printing
  • f6e26f6: 8265756: AArch64: initialize memory allocated for locals according to Windows AArch64 stack page growth requirement in template interpreter
  • 0a4c338: 8263432: javac may report an invalid package/class clash on case insensitive filesystems
  • 82b3719: 8265967: Unused NullCheckNode forward declaration in node.hpp
  • ... and 17 more: https://git.openjdk.java.net/jdk/compare/8559a53056c2d4eed51d9df4a212d10b62bb9878...master

Your commit was automatically rebased without conflicts.

Pushed as commit b2628d1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants