Skip to content

Conversation

@zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Apr 26, 2021

ShenandoahInitMarkRootsClosure is only used by STW mark, let's move it there.

Test:

  • hotspot_gc_shenandoah

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265995: Shenandoah: Move ShenandoahInitMarkRootsClosure close to its use

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3701/head:pull/3701
$ git checkout pull/3701

Update a local copy of the PR:
$ git checkout pull/3701
$ git pull https://git.openjdk.java.net/jdk pull/3701/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3701

View PR using the GUI difftool:
$ git pr show -t 3701

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3701.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 26, 2021

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 26, 2021

@zhengyu123 The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Apr 26, 2021
@zhengyu123 zhengyu123 marked this pull request as ready for review April 26, 2021 19:14
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 26, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 26, 2021

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@openjdk
Copy link

openjdk bot commented Apr 27, 2021

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265995: Shenandoah: Move ShenandoahInitMarkRootsClosure close to its use

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • 7db9330: 8196300: java/awt/TextArea/TextAreaScrolling/TextAreaScrolling.java times out
  • 694aced: 8264805: Remove the experimental Ahead-of-Time Compiler
  • 15d4787: 8265496: improve null check in DeflaterOutputStream/InflaterInputStream
  • 1d37b98: 8265972: Remove declarations with no implementations in javaClasses.hpp
  • cb29b19: 8184134: HeapRegion::LogOfHRGrainWords is unused
  • 41daa88: 8265899: Use pattern matching for instanceof at module jdk.compiler(part 1)
  • a6f2863: 8266003: ProblemList sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java on macosx-all
  • 852a41d: 8258625: [JVMCI] refactor and unify JVMCI readFieldValue path
  • b5c6351: 8264663: Update test SuspendWithCurrentThread.java to verify that suspend doesn't exit until resumed
  • b524a81: 8265982: JDK-8264188 breaks build on macOS-aarch64
  • ... and 3 more: https://git.openjdk.java.net/jdk/compare/851b219d74d177bb73ccef0b4d873802f03abe2a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 27, 2021
@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Apr 27, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 27, 2021
@openjdk
Copy link

openjdk bot commented Apr 27, 2021

@zhengyu123 Since your change was applied there have been 20 commits pushed to the master branch:

  • 879a77f: 8265757: stack-use-after-scope in perfMemory_posix.cpp get_user_name_slow()
  • e4be968: 8265980: Fix systemDictionary and loaderConstraints printing
  • f6e26f6: 8265756: AArch64: initialize memory allocated for locals according to Windows AArch64 stack page growth requirement in template interpreter
  • 0a4c338: 8263432: javac may report an invalid package/class clash on case insensitive filesystems
  • 82b3719: 8265967: Unused NullCheckNode forward declaration in node.hpp
  • 468c847: 8234020: Remove FullGCCount_lock
  • 4785e11: 8264806: Remove the experimental JIT compiler
  • 7db9330: 8196300: java/awt/TextArea/TextAreaScrolling/TextAreaScrolling.java times out
  • 694aced: 8264805: Remove the experimental Ahead-of-Time Compiler
  • 15d4787: 8265496: improve null check in DeflaterOutputStream/InflaterInputStream
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/851b219d74d177bb73ccef0b4d873802f03abe2a...master

Your commit was automatically rebased without conflicts.

Pushed as commit 9adbf15.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@zhengyu123 zhengyu123 deleted the JDK-8265995-init-mark-roots branch October 26, 2023 01:47
@zhengyu123 zhengyu123 restored the JDK-8265995-init-mark-roots branch October 26, 2023 01:47
@zhengyu123 zhengyu123 deleted the JDK-8265995-init-mark-roots branch October 26, 2023 01:47
@zhengyu123 zhengyu123 restored the JDK-8265995-init-mark-roots branch October 26, 2023 01:47
@zhengyu123 zhengyu123 deleted the JDK-8265995-init-mark-roots branch October 26, 2023 01:47
@zhengyu123 zhengyu123 restored the JDK-8265995-init-mark-roots branch October 26, 2023 01:48
@zhengyu123 zhengyu123 deleted the JDK-8265995-init-mark-roots branch October 26, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants