8251464: make Node::dump(int depth) support indent

[navyxliu]

Node::dump(depth) indents 2 whitespaces for each level.
The function isnot on until the depth of the ideal graph isnot greater
than PrintIdealIndentThreshold (0 by default).

/cc hotspot-compiler

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8251464: make Node::dump(int depth) support indent

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer) ⚠️ Review applies to 2c5376f092f50a6e918f6730a472de9a64cca6ee

Download

$ git fetch https://git.openjdk.java.net/jdk pull/371/head:pull/371
$ git checkout pull/371

[bridgekeeper]

👋 Welcome back xliu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@navyxliu
The hotspot-compiler label was successfully added.

[mlbridge]

Webrevs

• 02: Full (f66d346)
• 01: Full - Incremental (af23f1759b683651562ac961988e47f9d9c27462)
• 00: Full (2c5376f092f50a6e918f6730a472de9a64cca6ee)

[TobiHartmann]

This looks good to me but please make sure that there are no other tests depending on the tab character in the output.

[openjdk]

@navyxliu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8251464: make Node::dump(int depth) support indent

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[navyxliu]

Thanks Tobias!
I ran tier1 test and it looks good. Let me verify it using submit repo before I integrate it.

[navyxliu]

/submit

[openjdk]

@navyxliu Unknown command submit - for a list of valid commands use /help.

[navyxliu]

pass all tests: https://github.com/navyxliu/jdk/actions/runs/283309901
/integrate

[openjdk]

@navyxliu
Your change (at version f66d346) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

@phohensee @navyxliu Since your change was applied there have been 8 commits pushed to the master branch:

• fff8c8d: 8253882: remove PropertyResolvingWrapper
• 7dcdc1f: 8253865: Pre-submit testing using GitHub Actions does not detect failures reliably
• 0fd41c3: 8253470: Javadoc clean up in Filter and Headers
• f686a38: 8253926: Use extra_size correctly in anon_mmap_aligned
• b8966e1: 8253928: G1: Remove G1ConcurrentMarkThread::set_in_progress declaration
• 4185ed3: 5078989: Null Pointer exception in SpinnerListMode
• 6f40a41: 8253891: Debug x86_32 builds fail after JDK-8239090
• b9505df: 8253118: Avoid unnecessary deopts when OSR nmethods of the same level are present.

Your commit was automatically rebased without conflicts.

Pushed as commit ea5a2b1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.