8266018: Shenandoah: fix an incorrect assert

[wattsun110]

May I get reviews for this one-line change which fixes an incorrect assert?

thanks
watt

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8266018: Shenandoah: fix an incorrect assert

Reviewers

• Roman Kennke (@rkennke - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3710/head:pull/3710
$ git checkout pull/3710

Update a local copy of the PR:
$ git checkout pull/3710
$ git pull https://git.openjdk.java.net/jdk pull/3710/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3710

View PR using the GUI difftool:
$ git pr show -t 3710

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3710.diff

[bridgekeeper]

Hi @wattsun110, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user wattsun110" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

⚠️ @wattsun110 a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master 694acedf1830d16042aceeebcbaf6ced2c95ee2c
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

[openjdk]

@wattsun110 The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[wattsun110]

/covered

[wattsun110]

/covered by Tencent

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[mlbridge]

Webrevs

• 00: Full (9fe0dca4)

[rkennke]

Looks good! Thanks for the contribution!

[openjdk]

@wattsun110 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266018: Shenandoah: fix an incorrect assert

Reviewed-by: rkennke

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 171 new commits pushed to the master branch:

• 138d573: 8262392: Update Mesa 3-D Headers to version 21.0.3
• 9de62a4: 8266505: Cleanup LibraryCallKit::make_unsafe_address()
• 1885c83: 8266504: Remove leftovers from BarrierSetAssemblerC1
• 6018336: 8259316: [REDO] C1/C2 compiler support for blackholes
• f07bb2f: 8250766: javadoc adds redundant spaces when @see program element is wrapped
• 61bb6ec: 8266453: Shenandoah: Disable write protections before patching nmethod in nmethod_barrier on MacOSX/AArch64
• a05e8e2: 8266497: Remove unnecessary EMCP liveness indication
• 6ba911d: 8266498: Make debug ps() call print_stack
• ef0f693: 8266499: Delete dead code in aarch64.ad
• 71d0858: 8266522: Shenandoah: Shenandoah LRB calls wrong runtime barrier on aarch64
• ... and 161 more: https://git.openjdk.java.net/jdk/compare/694acedf1830d16042aceeebcbaf6ced2c95ee2c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rkennke) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[wattsun110]

/integrate

[openjdk]

@wattsun110
Your change (at version 9fe0dca) is now ready to be sponsored by a Committer.

[rkennke]

/sponsor

[openjdk]

@rkennke @wattsun110 Since your change was applied there have been 174 commits pushed to the master branch:

• 22ca62c: 8266542: Remove broken -XX:-UseLoopSafepoints flag
• 7835cdb: 8265915: adjust state_unloading_cycle compuation order in nmethod::is_unloading
• 20ad428: 8180568: Refactor javax/crypto shell tests to plain java tests
• 138d573: 8262392: Update Mesa 3-D Headers to version 21.0.3
• 9de62a4: 8266505: Cleanup LibraryCallKit::make_unsafe_address()
• 1885c83: 8266504: Remove leftovers from BarrierSetAssemblerC1
• 6018336: 8259316: [REDO] C1/C2 compiler support for blackholes
• f07bb2f: 8250766: javadoc adds redundant spaces when @see program element is wrapped
• 61bb6ec: 8266453: Shenandoah: Disable write protections before patching nmethod in nmethod_barrier on MacOSX/AArch64
• a05e8e2: 8266497: Remove unnecessary EMCP liveness indication
• ... and 164 more: https://git.openjdk.java.net/jdk/compare/694acedf1830d16042aceeebcbaf6ced2c95ee2c...master

Your commit was automatically rebased without conflicts.

Pushed as commit 2dd5667.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.